Re: [f2fs-dev] [PATCH] f2fs: skip adding a discard command if exists

2023-11-30 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Tue, 14 Nov 2023 13:24:14 -0800 you wrote: > When recovering zoned UFS, sometimes we add the same zone to discard multiple > times. Simple workaround is to bypass adding it. > > Signed-off-by: Jaegeuk Kim > --- >

Re: [f2fs-dev] [PATCH] f2fs: skip adding a discard command if exists

2023-11-19 Thread Chao Yu
On 2023/11/18 1:41, Jaegeuk Kim wrote: Not sure other cases yet.. let's do one by one, since I hit this in real. Sure. Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thansk, ___ Linux-f2fs-devel mailing list

Re: [f2fs-dev] [PATCH] f2fs: skip adding a discard command if exists

2023-11-17 Thread Jaegeuk Kim
On 11/15, Chao Yu wrote: > On 2023/11/15 10:45, Jaegeuk Kim wrote: > > On 11/15, Chao Yu wrote: > > > On 2023/11/15 5:24, Jaegeuk Kim wrote: > > > > When recovering zoned UFS, sometimes we add the same zone to discard > > > > multiple > > > > times. Simple workaround is to bypass adding it. > > >

Re: [f2fs-dev] [PATCH] f2fs: skip adding a discard command if exists

2023-11-14 Thread Chao Yu
On 2023/11/15 10:45, Jaegeuk Kim wrote: On 11/15, Chao Yu wrote: On 2023/11/15 5:24, Jaegeuk Kim wrote: When recovering zoned UFS, sometimes we add the same zone to discard multiple times. Simple workaround is to bypass adding it. What about skipping f2fs_bug_on() just for zoned UFS case? so

Re: [f2fs-dev] [PATCH] f2fs: skip adding a discard command if exists

2023-11-14 Thread Jaegeuk Kim
On 11/15, Chao Yu wrote: > On 2023/11/15 5:24, Jaegeuk Kim wrote: > > When recovering zoned UFS, sometimes we add the same zone to discard > > multiple > > times. Simple workaround is to bypass adding it. > > What about skipping f2fs_bug_on() just for zoned UFS case? so that the check >

Re: [f2fs-dev] [PATCH] f2fs: skip adding a discard command if exists

2023-11-14 Thread Chao Yu
On 2023/11/15 5:24, Jaegeuk Kim wrote: When recovering zoned UFS, sometimes we add the same zone to discard multiple times. Simple workaround is to bypass adding it. What about skipping f2fs_bug_on() just for zoned UFS case? so that the check condition can still be used for non-zoned UFS case.

[f2fs-dev] [PATCH] f2fs: skip adding a discard command if exists

2023-11-14 Thread Jaegeuk Kim
When recovering zoned UFS, sometimes we add the same zone to discard multiple times. Simple workaround is to bypass adding it. Signed-off-by: Jaegeuk Kim --- fs/f2fs/segment.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index