Re: [f2fs-dev] [PATCH 02/18] fs: add get_acl helper

2013-12-17 Thread Christoph Hellwig
On Thu, Dec 12, 2013 at 08:06:09PM +0100, Andreas Gruenbacher wrote: > > + /* > > +* A filesystem can force a ACL callback by just never filling the > > +* ACL cache. But normally you'd fill the cache either at inode > > +* instantiation time, or on the first ->get_acl call. > > +

Re: [f2fs-dev] [PATCH 02/18] fs: add get_acl helper

2013-12-17 Thread Andreas Gruenbacher
Christoph, > +struct posix_acl *get_acl(struct inode *inode, int type) > +{ > + struct posix_acl *acl; > + > + acl = get_cached_acl(inode, type); > + if (acl != ACL_NOT_CACHED) > + return acl; > + > + if (!IS_POSIXACL(inode)) > + return NULL; > + > + /*

[f2fs-dev] [PATCH 02/18] fs: add get_acl helper

2013-12-11 Thread Christoph Hellwig
Factor out the code to get an ACL either from the inode or disk from check_acl, so that it can be used elsewhere later on. Signed-off-by: Christoph Hellwig Reviewed-by: Jan Kara --- fs/namei.c| 24 +++- fs/posix_acl.c| 26 +

Re: [f2fs-dev] [PATCH 02/18] fs: add get_acl helper

2013-12-02 Thread Jan Kara
On Sun 01-12-13 03:59:05, Christoph Hellwig wrote: > Factor out the code to get an ACL either from the inode or disk from > check_acl, so that it can be used elsewhere later on. > > Signed-off-by: Christoph Hellwig Looks good. You can add: Reviewed-by: Jan Kara

[f2fs-dev] [PATCH 02/18] fs: add get_acl helper

2013-12-02 Thread Christoph Hellwig
Factor out the code to get an ACL either from the inode or disk from check_acl, so that it can be used elsewhere later on. Signed-off-by: Christoph Hellwig --- fs/namei.c| 24 +++- fs/posix_acl.c| 23 +++ include/linux/posix