Re: [f2fs-dev] [PATCH 12/15] f2fs: remove the create argument to f2fs_map_blocks

2022-12-14 Thread Jaegeuk Kim
On 12/13, Christoph Hellwig wrote: > On Mon, Dec 12, 2022 at 05:22:41PM -0800, Jaegeuk Kim wrote: > > > struct dnode_of_data dn; > > > @@ -1484,11 +1483,7 @@ int f2fs_map_blocks(struct inode *inode, struct > > > f2fs_map_blocks *map, > > > pgofs = (pgoff_t)map->m_lblk; > > > end = pgofs +

Re: [f2fs-dev] [PATCH 12/15] f2fs: remove the create argument to f2fs_map_blocks

2022-12-12 Thread Christoph Hellwig
On Mon, Dec 12, 2022 at 05:22:41PM -0800, Jaegeuk Kim wrote: > > struct dnode_of_data dn; > > @@ -1484,11 +1483,7 @@ int f2fs_map_blocks(struct inode *inode, struct > > f2fs_map_blocks *map, > > pgofs = (pgoff_t)map->m_lblk; > > end = pgofs + maxblocks; > > > > - if (!create &&

Re: [f2fs-dev] [PATCH 12/15] f2fs: remove the create argument to f2fs_map_blocks

2022-12-12 Thread Jaegeuk Kim
Hi Christoph, On 11/28, Christoph Hellwig wrote: > The create argument is always identicaly to map->m_may_create, so use > that consistently. > > Signed-off-by: Christoph Hellwig > --- > fs/f2fs/data.c | 32 ++-- > fs/f2fs/f2fs.h | 3 +-- >

[f2fs-dev] [PATCH 12/15] f2fs: remove the create argument to f2fs_map_blocks

2022-11-28 Thread Christoph Hellwig
The create argument is always identicaly to map->m_may_create, so use that consistently. Signed-off-by: Christoph Hellwig --- fs/f2fs/data.c | 32 ++-- fs/f2fs/f2fs.h | 3 +-- fs/f2fs/file.c | 12 ++--