[f2fs-dev] [PATCH 2/2] f2fs: compress: fix to relocate check condition in f2fs_ioc_{, de}compress_file()

[Chao Yu]

Compress flag should be checked after inode lock held to avoid
racing w/ f2fs_setflags_common() , fix it.

Fixes: 5fdb322ff2c2 ("f2fs: add F2FS_IOC_DECOMPRESS_FILE and 
F2FS_IOC_COMPRESS_FILE")
Reported-by: Zhiguo Niu <zhiguo....@unisoc.com>
Closes: 
https://lore.kernel.org/linux-f2fs-devel/cahj8p3ldzxlc2rqeyjvymgyhr2+yluj0slg9ddsjzmwo7de...@mail.gmail.com
Signed-off-by: Chao Yu <c...@kernel.org>
---
 fs/f2fs/file.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index ca401cf8152a..232dd5fc8ab3 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -4142,9 +4142,6 @@ static int f2fs_ioc_decompress_file(struct file *filp)
        if (!(filp->f_mode & FMODE_WRITE))
                return -EBADF;
 
-       if (!f2fs_compressed_file(inode))
-               return -EINVAL;
-
        f2fs_balance_fs(sbi, true);
 
        file_start_write(filp);
@@ -4155,7 +4152,8 @@ static int f2fs_ioc_decompress_file(struct file *filp)
                goto out;
        }
 
-       if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) {
+       if (!f2fs_compressed_file(inode) ||
+               is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) {
                ret = -EINVAL;
                goto out;
        }
@@ -4220,9 +4218,6 @@ static int f2fs_ioc_compress_file(struct file *filp)
        if (!(filp->f_mode & FMODE_WRITE))
                return -EBADF;
 
-       if (!f2fs_compressed_file(inode))
-               return -EINVAL;
-
        f2fs_balance_fs(sbi, true);
 
        file_start_write(filp);
@@ -4233,7 +4228,8 @@ static int f2fs_ioc_compress_file(struct file *filp)
                goto out;
        }
 
-       if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) {
+       if (!f2fs_compressed_file(inode) ||
+               is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) {
                ret = -EINVAL;
                goto out;
        }
-- 
2.40.1



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel