Re: [f2fs-dev] [PATCH 2/5] fs: affs: initialize fsdata in affs_truncate()

2023-01-10 Thread Eric Biggers
On Tue, Jan 10, 2023 at 01:27:03PM +0100, Alexander Potapenko wrote: > On Tue, Nov 22, 2022 at 3:56 PM David Sterba wrote: > > > > On Mon, Nov 21, 2022 at 12:21:31PM +0100, Alexander Potapenko wrote: > > > When aops->write_begin() does not initialize fsdata, KMSAN may report > > > an error

Re: [f2fs-dev] [PATCH 2/5] fs: affs: initialize fsdata in affs_truncate()

2023-01-10 Thread David Sterba
On Tue, Jan 10, 2023 at 01:27:03PM +0100, Alexander Potapenko wrote: > On Tue, Nov 22, 2022 at 3:56 PM David Sterba wrote: > > > > On Mon, Nov 21, 2022 at 12:21:31PM +0100, Alexander Potapenko wrote: > > > When aops->write_begin() does not initialize fsdata, KMSAN may report > > > an error

Re: [f2fs-dev] [PATCH 2/5] fs: affs: initialize fsdata in affs_truncate()

2023-01-10 Thread Alexander Potapenko via Linux-f2fs-devel
On Tue, Nov 22, 2022 at 3:56 PM David Sterba wrote: > > On Mon, Nov 21, 2022 at 12:21:31PM +0100, Alexander Potapenko wrote: > > When aops->write_begin() does not initialize fsdata, KMSAN may report > > an error passing the latter to aops->write_end(). > > > > Fix this by unconditionally

Re: [f2fs-dev] [PATCH 2/5] fs: affs: initialize fsdata in affs_truncate()

2022-11-22 Thread David Sterba
On Mon, Nov 21, 2022 at 12:21:31PM +0100, Alexander Potapenko wrote: > When aops->write_begin() does not initialize fsdata, KMSAN may report > an error passing the latter to aops->write_end(). > > Fix this by unconditionally initializing fsdata. > > Suggested-by: Eric Biggers > Fixes:

Re: [f2fs-dev] [PATCH 2/5] fs: affs: initialize fsdata in affs_truncate()

2022-11-22 Thread Alexander Potapenko via Linux-f2fs-devel
On Mon, Nov 21, 2022 at 8:46 PM Eric Biggers wrote: > > On Mon, Nov 21, 2022 at 12:21:31PM +0100, Alexander Potapenko wrote: > > When aops->write_begin() does not initialize fsdata, KMSAN may report > > an error passing the latter to aops->write_end(). > > > > Fix this by unconditionally

Re: [f2fs-dev] [PATCH 2/5] fs: affs: initialize fsdata in affs_truncate()

2022-11-21 Thread Eric Biggers
On Mon, Nov 21, 2022 at 12:21:31PM +0100, Alexander Potapenko wrote: > When aops->write_begin() does not initialize fsdata, KMSAN may report > an error passing the latter to aops->write_end(). > > Fix this by unconditionally initializing fsdata. > > Suggested-by: Eric Biggers > Fixes:

[f2fs-dev] [PATCH 2/5] fs: affs: initialize fsdata in affs_truncate()

2022-11-21 Thread Alexander Potapenko via Linux-f2fs-devel
When aops->write_begin() does not initialize fsdata, KMSAN may report an error passing the latter to aops->write_end(). Fix this by unconditionally initializing fsdata. Suggested-by: Eric Biggers Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Alexander Potapenko --- fs/affs/file.c |