Re: [f2fs-dev] [PATCH 6/9] dm crypt: support diskcipher

2019-08-23 Thread boojin.kim
On Fri, Aug 23, 2019 at 01:28:37PM +0900, Herbert Xu wrote: > > No. If you're after total offload then the crypto API is not for > you. What we can support is the offloading of encryption/decryption > over many sectors. > > Cheers, FMP doesn't use encrypt/decrypt of crypto API because it doesn't

Re: [f2fs-dev] [PATCH 6/9] dm crypt: support diskcipher

2019-08-22 Thread Herbert Xu
On Fri, Aug 23, 2019 at 01:20:37PM +0900, boojin.kim wrote: > > If yes, I think the following API needs to be added to skcipher: > - _set(): BIO submitter (dm-crypt, f2fs, ext4) sets cipher to BIO. > - _mergeable(): Block layer checks if two BIOs have the same cipher. > - _get(): Storage driver g

Re: [f2fs-dev] [PATCH 6/9] dm crypt: support diskcipher

2019-08-22 Thread boojin.kim
On Wed, Aug 21, 2019 at 17:19:41PM +0900, Herbert Xu wrote: > On Wed, Aug 21, 2019 at 04:57:41PM +0900, boojin.kim wrote: > > > > Can you tell me which patch you mentioned? Is this? > > https://patches.linaro.org/project/linux-crypto/list/?series=22762 > > > > Yes this is the one. > > Cheers, I l

Re: [f2fs-dev] [PATCH 6/9] dm crypt: support diskcipher

2019-08-21 Thread Herbert Xu
On Wed, Aug 21, 2019 at 04:57:41PM +0900, boojin.kim wrote: > > Can you tell me which patch you mentioned? Is this? > https://patches.linaro.org/project/linux-crypto/list/?series=22762 Yes this is the one. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: htt

Re: [f2fs-dev] [PATCH 6/9] dm crypt: support diskcipher

2019-08-21 Thread boojin.kim
On Wed, Aug 21, 2019 at 09:35:36AM +0200, Herbert Xu Herbert wrote: > I agree. Please take a look at the recent ESSIV patches on > linux-crypto and build multi-block operations on top of them > which can then be implemented by the hardware. > > Cheers, Can you tell me which patch you mentioned?

Re: [f2fs-dev] [PATCH 6/9] dm crypt: support diskcipher

2019-08-21 Thread boojin.kim
On Wed, Aug 21, 2019 at 09:13:36AM +0200, Milan Broz wrote: > > NACK. > > The whole principle of dm-crypt target is that it NEVER EVER submits > plaintext data down the stack in bio. > > If you want to do some lower/higher layer encryption, use key management > on a different layer. > So here, j

[f2fs-dev] [PATCH 6/9] dm crypt: support diskcipher

2019-08-20 Thread boojin.kim
This patch supports dm-crypt to use diskcipher in a specific ivmode (disk or fmp). Dm-crypt allocates diskcipher and sets the key on it. Then, dm-crypt sets diskcipher into BIO and submits the BIO without any additional data encryption. Cc: Alasdair Kergon Cc: Mike Snitzer Cc: dm-de...@redhat.co