Re: [f2fs-dev] [PATCH V1] f2fs: fix potentail deadloop issue in do_recover_data

2024-01-24 Thread Zhiguo Niu
Hi Chao, On Wed, Jan 24, 2024 at 10:54 PM Chao Yu wrote: > > Zhiguo, >m > Can you please check below version? Is it fine to you? > > https://lore.kernel.org/linux-f2fs-devel/20240124144915.19445-1-c...@kernel.org it is ok to me and more reasonable than my version thanks~ > > On 2024/1/22 13:46,

Re: [f2fs-dev] [PATCH V1] f2fs: fix potentail deadloop issue in do_recover_data

2024-01-24 Thread Chao Yu
Zhiguo, Can you please check below version? Is it fine to you? https://lore.kernel.org/linux-f2fs-devel/20240124144915.19445-1-c...@kernel.org On 2024/1/22 13:46, Zhiguo Niu wrote: Hi Chao On Mon, Jan 22, 2024 at 11:46 AM Chao Yu wrote: On 2023/12/25 19:11, Zhiguo Niu wrote: There is a po

Re: [f2fs-dev] [PATCH V1] f2fs: fix potentail deadloop issue in do_recover_data

2024-01-21 Thread Zhiguo Niu
Hi Chao On Mon, Jan 22, 2024 at 11:46 AM Chao Yu wrote: > > On 2023/12/25 19:11, Zhiguo Niu wrote: > > There is a potentail deadloop issue in the corner case of > > CONFIG_F2FS_FAULT_INJECTION is enabled and the return value > > of f2fs_reserve_new_block is error but not -ENOSPC, such as > > this

Re: [f2fs-dev] [PATCH V1] f2fs: fix potentail deadloop issue in do_recover_data

2024-01-21 Thread Chao Yu
On 2023/12/25 19:11, Zhiguo Niu wrote: There is a potentail deadloop issue in the corner case of CONFIG_F2FS_FAULT_INJECTION is enabled and the return value of f2fs_reserve_new_block is error but not -ENOSPC, such as this error case: if (unlikely(is_inode_flag_set(dn->inode, FI_NO_ALLOC)))

[f2fs-dev] [PATCH V1] f2fs: fix potentail deadloop issue in do_recover_data

2023-12-25 Thread Zhiguo Niu
There is a potentail deadloop issue in the corner case of CONFIG_F2FS_FAULT_INJECTION is enabled and the return value of f2fs_reserve_new_block is error but not -ENOSPC, such as this error case: if (unlikely(is_inode_flag_set(dn->inode, FI_NO_ALLOC))) return -EPERM; besides, the mai