Re: [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion

2025-05-07 Thread Jaegeuk Kim via Linux-f2fs-devel
On 05/07, Eric Sandeen wrote: > On 5/7/25 2:48 PM, Jaegeuk Kim wrote: > > On 05/07, Eric Sandeen wrote: > >> On 5/7/25 9:46 AM, Jaegeuk Kim wrote: > >> > >>> I meant: > >>> > >>> # mkfs/mkfs.f2fs -c /dev/v...@vdc.file /dev/vdb > >>> # mount /dev/vdb mnt > >>> > >>> It's supposed to be successful, s

Re: [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion

2025-05-07 Thread Jaegeuk Kim via Linux-f2fs-devel
On 05/07, Eric Sandeen wrote: > On 5/7/25 3:28 PM, Jaegeuk Kim wrote: > >> But as far as I can tell, at least for the extent cache, remount is handled > >> properly already (with the hunk above): > >> > >> # mkfs/mkfs.f2fs -c /dev/v...@vdc.file /dev/vdb > >> # mount /dev/vdb mnt > >> # mount -o rem

Re: [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion

2025-05-07 Thread Eric Sandeen via Linux-f2fs-devel
On 5/7/25 3:28 PM, Jaegeuk Kim wrote: >> But as far as I can tell, at least for the extent cache, remount is handled >> properly already (with the hunk above): >> >> # mkfs/mkfs.f2fs -c /dev/v...@vdc.file /dev/vdb >> # mount /dev/vdb mnt >> # mount -o remount,noextent_cache mnt >> mount: /root/mnt:

Re: [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion

2025-05-07 Thread Eric Sandeen via Linux-f2fs-devel
On 5/7/25 2:48 PM, Jaegeuk Kim wrote: > On 05/07, Eric Sandeen wrote: >> On 5/7/25 9:46 AM, Jaegeuk Kim wrote: >> >>> I meant: >>> >>> # mkfs/mkfs.f2fs -c /dev/v...@vdc.file /dev/vdb >>> # mount /dev/vdb mnt >>> >>> It's supposed to be successful, since extent_cache is enabled by default. >> >> I'm

Re: [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion

2025-05-07 Thread Jaegeuk Kim via Linux-f2fs-devel
On 05/07, Eric Sandeen wrote: > On 5/7/25 9:46 AM, Jaegeuk Kim wrote: > > > I meant: > > > > # mkfs/mkfs.f2fs -c /dev/v...@vdc.file /dev/vdb > > # mount /dev/vdb mnt > > > > It's supposed to be successful, since extent_cache is enabled by default. > > I'm sorry, clearly I was too sleepy last ni

Re: [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion

2025-05-07 Thread Eric Sandeen via Linux-f2fs-devel
On 5/7/25 9:46 AM, Jaegeuk Kim wrote: > I meant: > > # mkfs/mkfs.f2fs -c /dev/v...@vdc.file /dev/vdb > # mount /dev/vdb mnt > > It's supposed to be successful, since extent_cache is enabled by default. I'm sorry, clearly I was too sleepy last night. This fixes it for me. We have to test the ma

Re: [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion

2025-05-07 Thread Jaegeuk Kim via Linux-f2fs-devel
On 05/06, Eric Sandeen wrote: > On 5/6/25 9:56 PM, Eric Sandeen wrote: > > On 5/6/25 8:23 PM, Jaegeuk Kim wrote: > > ... > > >> What about: > >> # mount -o loop,noextent_cache f2fsfile.img mnt > >> > >> In this case, 1) ctx_clear_opt(), 2) set_opt() in default_options, > >> 3) clear_opt since mas

Re: [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion

2025-05-06 Thread Eric Sandeen via Linux-f2fs-devel
On 5/6/25 9:56 PM, Eric Sandeen wrote: > On 5/6/25 8:23 PM, Jaegeuk Kim wrote: ... >> What about: >> # mount -o loop,noextent_cache f2fsfile.img mnt >> >> In this case, 1) ctx_clear_opt(), 2) set_opt() in default_options, >> 3) clear_opt since mask is set? > > Not sure what I'm missing, it seems

Re: [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion

2025-05-06 Thread Eric Sandeen via Linux-f2fs-devel
On 5/6/25 8:23 PM, Jaegeuk Kim wrote: > On 05/06, Eric Sandeen wrote: >> On 5/6/25 7:35 PM, Jaegeuk Kim wrote: >>> Hmm, I had to drop the series at the moment, since it seems needing more >>> work to deal with default_options(), which breaks my device setup. >>> For example, set_opt(sbi, READ_EXTEN

Re: [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion

2025-05-06 Thread Jaegeuk Kim via Linux-f2fs-devel
On 05/06, Eric Sandeen wrote: > On 5/6/25 7:35 PM, Jaegeuk Kim wrote: > > Hmm, I had to drop the series at the moment, since it seems needing more > > work to deal with default_options(), which breaks my device setup. > > For example, set_opt(sbi, READ_EXTENT_CACHE) in default_options is not > > p

Re: [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion

2025-05-06 Thread Eric Sandeen via Linux-f2fs-devel
On 5/6/25 7:35 PM, Jaegeuk Kim wrote: > Hmm, I had to drop the series at the moment, since it seems needing more > work to deal with default_options(), which breaks my device setup. > For example, set_opt(sbi, READ_EXTENT_CACHE) in default_options is not > propagating > to the below logics. In thi

Re: [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion

2025-05-06 Thread Jaegeuk Kim via Linux-f2fs-devel
Hmm, I had to drop the series at the moment, since it seems needing more work to deal with default_options(), which breaks my device setup. For example, set_opt(sbi, READ_EXTENT_CACHE) in default_options is not propagating to the below logics. In this case, do we need ctx_set_opt() if user doesn't

Re: [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion

2025-05-06 Thread Ian Kent
On 24/4/25 01:08, Eric Sandeen wrote: V3: - Rebase onto git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev branch - Fix up some 0day robot warnings This is a forward-port of Hongbo's original f2fs mount API conversion, posted last August at https://lore.kernel.org/linux-f2fs-d

Re: [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion

2025-05-06 Thread Eric Sandeen via Linux-f2fs-devel
On 5/6/25 11:02 AM, Jaegeuk Kim wrote: > On 05/05, Eric Sandeen wrote: >> Hi all - it would be nice to get some review or feedback on this; >> seems that these patches tend to go stale fairly quickly as f2fs >> evolves. :) > > Thank you so much for the work! Let me queue this series into dev-test

Re: [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion

2025-05-06 Thread Jaegeuk Kim via Linux-f2fs-devel
On 05/05, Eric Sandeen wrote: > Hi all - it would be nice to get some review or feedback on this; > seems that these patches tend to go stale fairly quickly as f2fs > evolves. :) Thank you so much for the work! Let me queue this series into dev-test for tests. If I find any issue, let me ping to t

Re: [f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion

2025-05-05 Thread Eric Sandeen via Linux-f2fs-devel
Hi all - it would be nice to get some review or feedback on this; seems that these patches tend to go stale fairly quickly as f2fs evolves. :) Thanks, -Eric On 4/23/25 12:08 PM, Eric Sandeen wrote: > V3: > - Rebase onto git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git > dev branch

[f2fs-dev] [PATCH V3 0/7] f2fs: new mount API conversion

2025-04-24 Thread Eric Sandeen via Linux-f2fs-devel
V3: - Rebase onto git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev branch - Fix up some 0day robot warnings This is a forward-port of Hongbo's original f2fs mount API conversion, posted last August at https://lore.kernel.org/linux-f2fs-devel/20240814023912.3959299-1-lihongb...