Re: [f2fs-dev] [PATCH v2] f2fs: fix to read source block before invalidating it

On 2019/7/29 13:54, Jaegeuk Kim wrote: > On 07/23, Chao Yu wrote: >> On 2019/7/23 9:27, Jaegeuk Kim wrote: >>> On 07/18, Chao Yu wrote: On 2019/7/18 12:00, Jaegeuk Kim wrote: > On 07/18, Chao Yu wrote: >> On 2019/7/18 11:12, Jaegeuk Kim wrote: >>> f2fs_allocate_data_block()

Re: [f2fs-dev] [PATCH v2] f2fs: fix to read source block before invalidating it

On 2019/7/23 9:27, Jaegeuk Kim wrote: > On 07/18, Chao Yu wrote: >> On 2019/7/18 12:00, Jaegeuk Kim wrote: >>> On 07/18, Chao Yu wrote: On 2019/7/18 11:12, Jaegeuk Kim wrote: > f2fs_allocate_data_block() invalidates old block address and enable new > block > address. Then, if we

Re: [f2fs-dev] [PATCH v2] f2fs: fix to read source block before invalidating it

On 07/18, Chao Yu wrote: > On 2019/7/18 12:00, Jaegeuk Kim wrote: > > On 07/18, Chao Yu wrote: > >> On 2019/7/18 11:12, Jaegeuk Kim wrote: > >>> f2fs_allocate_data_block() invalidates old block address and enable new > >>> block > >>> address. Then, if we try to read old block by

Re: [f2fs-dev] [PATCH v2] f2fs: fix to read source block before invalidating it

On 2019/7/18 12:00, Jaegeuk Kim wrote: > On 07/18, Chao Yu wrote: >> On 2019/7/18 11:12, Jaegeuk Kim wrote: >>> f2fs_allocate_data_block() invalidates old block address and enable new >>> block >>> address. Then, if we try to read old block by f2fs_submit_page_bio(), it >>> will >>> give WARN

Re: [f2fs-dev] [PATCH v2] f2fs: fix to read source block before invalidating it

On 07/18, Chao Yu wrote: > On 2019/7/18 11:12, Jaegeuk Kim wrote: > > f2fs_allocate_data_block() invalidates old block address and enable new > > block > > address. Then, if we try to read old block by f2fs_submit_page_bio(), it > > will > > give WARN due to reading invalid blocks. > > > >

Re: [f2fs-dev] [PATCH v2] f2fs: fix to read source block before invalidating it

On 2019/7/18 11:30, Chao Yu wrote: > On 2019/7/18 11:12, Jaegeuk Kim wrote: >> f2fs_allocate_data_block() invalidates old block address and enable new block >> address. Then, if we try to read old block by f2fs_submit_page_bio(), it will >> give WARN due to reading invalid blocks. >> >> Let's make

Re: [f2fs-dev] [PATCH v2] f2fs: fix to read source block before invalidating it

On 2019/7/18 11:12, Jaegeuk Kim wrote: > f2fs_allocate_data_block() invalidates old block address and enable new block > address. Then, if we try to read old block by f2fs_submit_page_bio(), it will > give WARN due to reading invalid blocks. > > Let's make the order sanely back. Hmm.. to avoid

Re: [f2fs-dev] [PATCH v2] f2fs: fix to read source block before invalidating it

f2fs_allocate_data_block() invalidates old block address and enable new block address. Then, if we try to read old block by f2fs_submit_page_bio(), it will give WARN due to reading invalid blocks. Let's make the order sanely back. Signed-off-by: Jaegeuk Kim --- v2: I was fixing the comments. :)