Re: [f2fs-dev] [PATCH v3 04/20] fs: check for writeback errors after syncing out buffers in generic_file_fsync

On Mon 24-04-17 09:22:43, Jeff Layton wrote: > ext2 currently does a test+clear of the AS_EIO flag, which is > is problematic for some coming changes. > > What we really need to do instead is call filemap_check_errors > in __generic_file_fsync after syncing out the buffers. That > will be

Re: [f2fs-dev] [PATCH v3 04/20] fs: check for writeback errors after syncing out buffers in generic_file_fsync

> out: > inode_unlock(inode); > - return ret; > + err = filemap_check_errors(inode->i_mapping); > + return ret ? : err; Can you spell out the whole unary operation instead of this weird GCC extension? Otherwise looks fine: Reviewed-by: Christoph Hellwig

[f2fs-dev] [PATCH v3 04/20] fs: check for writeback errors after syncing out buffers in generic_file_fsync

ext2 currently does a test+clear of the AS_EIO flag, which is is problematic for some coming changes. What we really need to do instead is call filemap_check_errors in __generic_file_fsync after syncing out the buffers. That will be sufficient for this case, and help other callers detect these