Re: [f2fs-dev] [PATCH v3 3/4] block: rename IOPRIO_BE_NR

2021-08-09 Thread Christoph Hellwig
On Sat, Aug 07, 2021 at 10:16:39AM -0600, Jens Axboe wrote: > > /* > > - * 8 best effort priority levels are supported > > + * The RT and BE priority classes both support up to 8 priority levels. > > */ > > -#define IOPRIO_BE_NR 8 > > +#define IOPRIO_NR_LEVELS 8 > > That might not be a

Re: [f2fs-dev] [PATCH v3 3/4] block: rename IOPRIO_BE_NR

2021-08-07 Thread Damien Le Moal via Linux-f2fs-devel
On 2021/08/08 1:16, Jens Axboe wrote: > On 8/6/21 5:18 AM, Damien Le Moal wrote: >> diff --git a/include/uapi/linux/ioprio.h b/include/uapi/linux/ioprio.h >> index abc40965aa96..99d37d4807b8 100644 >> --- a/include/uapi/linux/ioprio.h >> +++ b/include/uapi/linux/ioprio.h >> @@ -31,9 +31,9 @@ enum {

Re: [f2fs-dev] [PATCH v3 3/4] block: rename IOPRIO_BE_NR

2021-08-07 Thread Jens Axboe
On 8/6/21 5:18 AM, Damien Le Moal wrote: > diff --git a/include/uapi/linux/ioprio.h b/include/uapi/linux/ioprio.h > index abc40965aa96..99d37d4807b8 100644 > --- a/include/uapi/linux/ioprio.h > +++ b/include/uapi/linux/ioprio.h > @@ -31,9 +31,9 @@ enum { > }; > > /* > - * 8 best effort priority

Re: [f2fs-dev] [PATCH v3 3/4] block: rename IOPRIO_BE_NR

2021-08-06 Thread Hannes Reinecke
On 8/6/21 1:18 PM, Damien Le Moal wrote: > The BFQ scheduler and ioprio_check_cap() both assume that the RT > priority class (IOPRIO_CLASS_RT) can have up to 8 different priority > levels. This is controlled using the macro IOPRIO_BE_NR, which is badly > named as the number of levels also applies t

[f2fs-dev] [PATCH v3 3/4] block: rename IOPRIO_BE_NR

2021-08-06 Thread Damien Le Moal
The BFQ scheduler and ioprio_check_cap() both assume that the RT priority class (IOPRIO_CLASS_RT) can have up to 8 different priority levels. This is controlled using the macro IOPRIO_BE_NR, which is badly named as the number of levels also applies to the RT class. Rename IOPRIO_BE_NR to the class