Re: [f2fs-dev] [PATCH v4] f2fs: fix to enable compress for newly created file if extension matches

2022-11-23 Thread Chao Yu
On 2022/11/24 5:29, Jaegeuk Kim wrote: + if (S_ISDIR(inode->i_mode)) + goto inherit_comp; Documentation/filesystems/f2fs.rst - Priority in between FS_COMPR_FL, FS_NOCOMP_FS, extensions: * compress_extension=so; nocompress_extension=zip; chattr +c dir; touch

Re: [f2fs-dev] [PATCH v4] f2fs: fix to enable compress for newly created file if extension matches

2022-11-23 Thread Jaegeuk Kim
On 11/23, Chao Yu wrote: > On 2022/11/17 9:12, Jaegeuk Kim wrote: > > If compress_extension is set, and a newly created file matches the > > extension, the file could be marked as compression file. However, > > if inline_data is also enabled, there is no chance to check its > > extension since

Re: [f2fs-dev] [PATCH v4] f2fs: fix to enable compress for newly created file if extension matches

2022-11-23 Thread Sheng Yong via Linux-f2fs-devel
On 2022/11/23 22:54, Chao Yu wrote: On 2022/11/17 9:12, Jaegeuk Kim wrote: If compress_extension is set, and a newly created file matches the extension, the file could be marked as compression file. However, if inline_data is also enabled, there is no chance to check its extension since

Re: [f2fs-dev] [PATCH v4] f2fs: fix to enable compress for newly created file if extension matches

2022-11-16 Thread Jaegeuk Kim
On 11/16, Sheng Yong wrote: > > > On 2022/11/16 7:00, Jaegeuk Kim wrote: > > If compress_extension is set, and a newly created file matches the > > extension, the file could be marked as compression file. However, > > if inline_data is also enabled, there is no chance to check its > > extension

Re: [f2fs-dev] [PATCH v4] f2fs: fix to enable compress for newly created file if extension matches

2022-11-16 Thread Jaegeuk Kim
If compress_extension is set, and a newly created file matches the extension, the file could be marked as compression file. However, if inline_data is also enabled, there is no chance to check its extension since f2fs_should_compress() always returns false. This patch moves set_compress_inode(),

Re: [f2fs-dev] [PATCH v4] f2fs: fix to enable compress for newly created file if extension matches

2022-11-15 Thread Sheng Yong via Linux-f2fs-devel
On 2022/11/16 7:00, Jaegeuk Kim wrote: If compress_extension is set, and a newly created file matches the extension, the file could be marked as compression file. However, if inline_data is also enabled, there is no chance to check its extension since f2fs_should_compress() always returns

Re: [f2fs-dev] [PATCH v4] f2fs: fix to enable compress for newly created file if extension matches

2022-11-15 Thread Jaegeuk Kim
If compress_extension is set, and a newly created file matches the extension, the file could be marked as compression file. However, if inline_data is also enabled, there is no chance to check its extension since f2fs_should_compress() always returns false. This patch moves set_compress_inode(),