Re: [f2fs-dev] [PATCH v7] f2fs: unify the error handling of f2fs_is_valid_blkaddr

2024-02-19 Thread Chao Yu
On 2024/2/20 15:45, Zhiguo Niu wrote: On Tue, Feb 20, 2024 at 2:32 PM Chao Yu mailto:c...@kernel.org>> wrote: > > On 2024/2/20 13:34, Zhiguo Niu wrote: > > I think do f2fs_handle_error in __is_bitmap_valid is a good way. > > Like this? > > --- >   fs/f2fs/checkpoint.c | 28

Re: [f2fs-dev] [PATCH v7] f2fs: unify the error handling of f2fs_is_valid_blkaddr

2024-02-19 Thread Chao Yu
On 2024/2/20 13:34, Zhiguo Niu wrote: I think do f2fs_handle_error in __is_bitmap_valid is a good way. Like this? --- fs/f2fs/checkpoint.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index

Re: [f2fs-dev] [PATCH v7] f2fs: unify the error handling of f2fs_is_valid_blkaddr

2024-02-19 Thread Chao Yu
On 2024/2/20 13:34, Zhiguo Niu wrote: On Tue, Feb 20, 2024 at 10:36 AM Chao Yu wrote: On 2024/2/19 22:36, Chao Yu wrote: Please think about how to optimize this, which is really ugly now --- fs/f2fs/checkpoint.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff

Re: [f2fs-dev] [PATCH v7] f2fs: unify the error handling of f2fs_is_valid_blkaddr

2024-02-19 Thread Zhiguo Niu
On Tue, Feb 20, 2024 at 10:36 AM Chao Yu wrote: > > On 2024/2/19 22:36, Chao Yu wrote: > Please think about how to optimize this, which is really ugly now > --- > fs/f2fs/checkpoint.c | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git

Re: [f2fs-dev] [PATCH v7] f2fs: unify the error handling of f2fs_is_valid_blkaddr

2024-02-19 Thread Chao Yu
On 2024/2/19 22:36, Chao Yu wrote: Please think about how to optimize this, which is really ugly now --- fs/f2fs/checkpoint.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index 87b7c988c8ca..089c26b80be3 100644 ---

Re: [f2fs-dev] [PATCH v7] f2fs: unify the error handling of f2fs_is_valid_blkaddr

2024-02-19 Thread Chao Yu
On 2024/2/19 19:19, Zhiguo Niu wrote: Dear Chao On Mon, Feb 19, 2024 at 11:46 AM Chao Yu wrote: On 2024/2/6 11:32, Jaegeuk Kim wrote: On 02/05, Chao Yu wrote: On 2024/2/5 11:30, Zhiguo Niu wrote: There are some cases of f2fs_is_valid_blkaddr not handled as ERROR_INVALID_BLKADDR,so unify

Re: [f2fs-dev] [PATCH v7] f2fs: unify the error handling of f2fs_is_valid_blkaddr

2024-02-19 Thread Zhiguo Niu
Dear Chao On Mon, Feb 19, 2024 at 11:46 AM Chao Yu wrote: > > On 2024/2/6 11:32, Jaegeuk Kim wrote: > > On 02/05, Chao Yu wrote: > >> On 2024/2/5 11:30, Zhiguo Niu wrote: > >>> There are some cases of f2fs_is_valid_blkaddr not handled as > >>> ERROR_INVALID_BLKADDR,so unify the error handling

Re: [f2fs-dev] [PATCH v7] f2fs: unify the error handling of f2fs_is_valid_blkaddr

2024-02-18 Thread Chao Yu
On 2024/2/6 11:32, Jaegeuk Kim wrote: On 02/05, Chao Yu wrote: On 2024/2/5 11:30, Zhiguo Niu wrote: There are some cases of f2fs_is_valid_blkaddr not handled as ERROR_INVALID_BLKADDR,so unify the error handling about all of f2fs_is_valid_blkaddr. Signed-off-by: Zhiguo Niu Signed-off-by: Chao

Re: [f2fs-dev] [PATCH v7] f2fs: unify the error handling of f2fs_is_valid_blkaddr

2024-02-06 Thread Zhiguo Niu
On Tue, Feb 6, 2024 at 11:36 AM Chao Yu wrote: > > On 2024/2/6 11:32, Jaegeuk Kim wrote: > > On 02/05, Chao Yu wrote: > >> On 2024/2/5 11:30, Zhiguo Niu wrote: > >>> There are some cases of f2fs_is_valid_blkaddr not handled as > >>> ERROR_INVALID_BLKADDR,so unify the error handling about all of >

Re: [f2fs-dev] [PATCH v7] f2fs: unify the error handling of f2fs_is_valid_blkaddr

2024-02-05 Thread Chao Yu
On 2024/2/6 11:32, Jaegeuk Kim wrote: On 02/05, Chao Yu wrote: On 2024/2/5 11:30, Zhiguo Niu wrote: There are some cases of f2fs_is_valid_blkaddr not handled as ERROR_INVALID_BLKADDR,so unify the error handling about all of f2fs_is_valid_blkaddr. Signed-off-by: Zhiguo Niu Signed-off-by: Chao

Re: [f2fs-dev] [PATCH v7] f2fs: unify the error handling of f2fs_is_valid_blkaddr

2024-02-05 Thread Jaegeuk Kim
On 02/05, Chao Yu wrote: > On 2024/2/5 11:30, Zhiguo Niu wrote: > > There are some cases of f2fs_is_valid_blkaddr not handled as > > ERROR_INVALID_BLKADDR,so unify the error handling about all of > > f2fs_is_valid_blkaddr. > > > > Signed-off-by: Zhiguo Niu > > Signed-off-by: Chao Yu > > --- > >

Re: [f2fs-dev] [PATCH v7] f2fs: unify the error handling of f2fs_is_valid_blkaddr

2024-02-04 Thread Chao Yu
On 2024/2/5 11:30, Zhiguo Niu wrote: There are some cases of f2fs_is_valid_blkaddr not handled as ERROR_INVALID_BLKADDR,so unify the error handling about all of f2fs_is_valid_blkaddr. Signed-off-by: Zhiguo Niu Signed-off-by: Chao Yu --- changes of v7: update patch according to sync with Chao

[f2fs-dev] [PATCH v7] f2fs: unify the error handling of f2fs_is_valid_blkaddr

2024-02-04 Thread Zhiguo Niu
There are some cases of f2fs_is_valid_blkaddr not handled as ERROR_INVALID_BLKADDR,so unify the error handling about all of f2fs_is_valid_blkaddr. Signed-off-by: Zhiguo Niu Signed-off-by: Chao Yu --- changes of v7: update patch according to sync with Chao -restore some code to original