Re: [f2fs-dev] [RFC] add ovp valid_blocks check for bg gc victim to fg_gc

2017-02-23 Thread Chao Yu
On 2017/2/18 4:17, Jaegeuk Kim wrote: > On 02/17, Hou Pengyang wrote: > > ... > On 2017/2/17 7:48, Jaegeuk Kim wrote: > + ovp_count = SM_I(sbi)->ovp_segments << sbi->log_blocks_per_seg; About the ovp_count calculation, in mkfs.f2fs, we get ovp_segment by

Re: [f2fs-dev] [RFC] add ovp valid_blocks check for bg gc victim to fg_gc

2017-02-17 Thread Jaegeuk Kim
On 02/17, Hou Pengyang wrote: ... > > > On 2017/2/17 7:48, Jaegeuk Kim wrote: > > > > + ovp_count = SM_I(sbi)->ovp_segments << sbi->log_blocks_per_seg; > > > > > > About the ovp_count calculation, > > > > > > in mkfs.f2fs, we get ovp_segment by > > > > > >

Re: [f2fs-dev] [RFC] add ovp valid_blocks check for bg gc victim to fg_gc

2017-02-16 Thread Hou Pengyang
On 2017/2/17 10:54, Jaegeuk Kim wrote: > On 02/17, Hou Pengyang wrote: >> On 2017/2/17 7:48, Jaegeuk Kim wrote: >>> Hi Pengyang, >>> >>> Nice >> Hi Jaegeuk, >> catch! >>> >>> I think fggc_threshold needs to be revised, and we need to consider about >>> general victim selection as well. >>> >>>

Re: [f2fs-dev] [RFC] add ovp valid_blocks check for bg gc victim to fg_gc

2017-02-16 Thread Jaegeuk Kim
On 02/17, Hou Pengyang wrote: > On 2017/2/17 7:48, Jaegeuk Kim wrote: > > Hi Pengyang, > > > > Nice > Hi Jaegeuk, > catch! > > > > I think fggc_threshold needs to be revised, and we need to consider about > > general victim selection as well. > > > > Could you take a look at this? > > > > >

Re: [f2fs-dev] [RFC] add ovp valid_blocks check for bg gc victim to fg_gc

2017-02-16 Thread Hou Pengyang
On 2017/2/17 7:48, Jaegeuk Kim wrote: > Hi Pengyang, > > Nice Hi Jaegeuk, catch! > > I think fggc_threshold needs to be revised, and we need to consider about > general victim selection as well. > > Could you take a look at this? > >>From 23b265f5ca6405032d092e240c94a827f743e42b Mon Sep 17

Re: [f2fs-dev] [RFC] add ovp valid_blocks check for bg gc victim to fg_gc

2017-02-16 Thread Jaegeuk Kim
Hi Pengyang, Nice catch! I think fggc_threshold needs to be revised, and we need to consider about general victim selection as well. Could you take a look at this? >From 23b265f5ca6405032d092e240c94a827f743e42b Mon Sep 17 00:00:00 2001 From: Hou Pengyang Date: Thu, 16

[f2fs-dev] [RFC] add ovp valid_blocks check for bg gc victim to fg_gc

2017-02-16 Thread Hou Pengyang
For foreground gc, greedy algorithm should be adapted, which makes this formula work well: (2 * (100 / config.overprovision + 1) + 6) But currently, we fg_gc have a prior to select bg_gc victim segments to gc first, these victims are selected by cost-benefit algorithm, we can't