Re: [f2fs-dev] Can F2FS roll forward after fdatasync()?

2020-06-04 Thread Hongwei Qin
> It's a bit unclear to me. Do you want to add fsync/fdatasync 1) in SQLite, or > 2) in your test program after transaction? > > 1) You'd better to build SQLite without atomic write. > 2) I think you don't need to do that, since SQLite should guarantee the >durability. > It's (1). I want to us

Re: [f2fs-dev] Can F2FS roll forward after fdatasync()?

2020-06-04 Thread Hongwei Qin
Hi Jaegeuk, On Thu, Jun 4, 2020 at 1:19 AM Jaegeuk Kim wrote: > > Hi Hongwei, > > On 05/29, Hongwei wrote: > > Hi, > > >On 05/28, Hongwei wrote: > > >> Hi F2FS experts, > > >> As written in f2fs_do_sync_file(): > > >> "Both of fdatasync() and fsync() are able to be recovered from > > >> sudden-p

Re: [f2fs-dev] Can F2FS roll forward after fdatasync()?

2020-06-03 Thread Jaegeuk Kim
Hi Hongwei, On 05/29, Hongwei wrote: > Hi, > >On 05/28, Hongwei wrote: > >> Hi F2FS experts, > >> As written in f2fs_do_sync_file(): > >> "Both of fdatasync() and fsync() are able to be recovered from > >> sudden-power-off." > >> > >> Please consider this workflow: > >> 1. Start atomic write > >>

Re: [f2fs-dev] Can F2FS roll forward after fdatasync()?

2020-05-29 Thread Hongwei
Hi, >On 05/28, Hongwei wrote: >> Hi F2FS experts, >> As written in f2fs_do_sync_file(): >> "Both of fdatasync() and fsync() are able to be recovered from >> sudden-power-off." >> >> Please consider this workflow: >> 1. Start atomic write >> 2. Multiple file writes >> 3. Commit atomic write >> 4. f

Re: [f2fs-dev] Can F2FS roll forward after fdatasync()?

2020-05-28 Thread Jaegeuk Kim
On 05/28, Hongwei wrote: > Hi F2FS experts, > As written in f2fs_do_sync_file(): > "Both of fdatasync() and fsync() are able to be recovered from > sudden-power-off." > > Please consider this workflow: > 1. Start atomic write > 2. Multiple file writes > 3. Commit atomic write > 4. fdatasync() > 5

[f2fs-dev] Can F2FS roll forward after fdatasync()?

2020-05-28 Thread Hongwei
Hi F2FS experts, As written in f2fs_do_sync_file(): "Both of fdatasync() and fsync() are able to be recovered from sudden-power-off." Please consider this workflow: 1. Start atomic write 2. Multiple file writes 3. Commit atomic write 4. fdatasync() 5. Powerloss. In the 4th step, the fdatasync()