[f2fs-dev] cleanup AOP_WRITEPAGE_ACTIVATE use in f2fs v2

2025-05-07 Thread Christoph Hellwig
Hi all, this almost entirely cleans up usage of AOP_WRITEPAGE_ACTIVATE in f2fs. Changes since v1: - pick up the bug fix from Chao as patch 1 - release the folio batch on early exit - remove the dead for_reclaim handling - keep the ability of the caller to exit early for the redity case Diffs

Re: [f2fs-dev] cleanup AOP_WRITEPAGE_ACTIVATE use in f2fs

2025-05-07 Thread Chao Yu via Linux-f2fs-devel
On 5/7/25 15:48, Christoph Hellwig wrote: > On Wed, May 07, 2025 at 03:38:20PM +0800, Chao Yu wrote: >> On 5/5/25 17:25, Christoph Hellwig wrote: >>> Hi all, >>> >>> this almost entirely cleans up usage of AOP_WRITEPAGE_ACTIVATE in f2fs. >>> >>> f2fs_sync_node_pages can still return it in a way tha

Re: [f2fs-dev] cleanup AOP_WRITEPAGE_ACTIVATE use in f2fs

2025-05-07 Thread Christoph Hellwig
On Wed, May 07, 2025 at 03:38:20PM +0800, Chao Yu wrote: > On 5/5/25 17:25, Christoph Hellwig wrote: > > Hi all, > > > > this almost entirely cleans up usage of AOP_WRITEPAGE_ACTIVATE in f2fs. > > > > f2fs_sync_node_pages can still return it in a way that is not handled > > by any caller and even

Re: [f2fs-dev] cleanup AOP_WRITEPAGE_ACTIVATE use in f2fs

2025-05-07 Thread Chao Yu via Linux-f2fs-devel
On 5/5/25 17:25, Christoph Hellwig wrote: > Hi all, > > this almost entirely cleans up usage of AOP_WRITEPAGE_ACTIVATE in f2fs. > > f2fs_sync_node_pages can still return it in a way that is not handled > by any caller and eventually is propagated to userspace. This does look > like a bug and nee

[f2fs-dev] cleanup AOP_WRITEPAGE_ACTIVATE use in f2fs

2025-05-05 Thread Christoph Hellwig
Hi all, this almost entirely cleans up usage of AOP_WRITEPAGE_ACTIVATE in f2fs. f2fs_sync_node_pages can still return it in a way that is not handled by any caller and eventually is propagated to userspace. This does look like a bug and needs attention by someone who actually knows the code. Di