Re: [f2fs-dev] [PATCH] f2fs: support FAULT_TIMEOUT

2025-04-29 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Fri, 25 Apr 2025 17:50:55 +0800 you wrote: > Support to inject a timeout fault into function, currently it only > support to inject timeout to commit_atomic_write flow to reproduce > inconsistent bug, like the bug fixed b

Re: [f2fs-dev] [PATCH] f2fs: support to disable linear lookup fallback

2025-04-04 Thread Daniel Lee via Linux-f2fs-devel
On Sun, Mar 30, 2025 at 7:54 PM Chao Yu wrote: > > After commit 91b587ba79e1 ("f2fs: Introduce linear search for > dentries"), f2fs forced to use linear lookup whenever a hash-based > lookup fails on casefolded directory, it may affect performance > for scenarios: a) create a new file w/ filename

Re: [f2fs-dev] [PATCH] f2fs: support to disable linear lookup fallback

2025-03-31 Thread Chao Yu via Linux-f2fs-devel
On 4/1/25 00:31, Daniel Lee wrote: > On Sun, Mar 30, 2025 at 7:54 PM Chao Yu wrote: >> >> After commit 91b587ba79e1 ("f2fs: Introduce linear search for >> dentries"), f2fs forced to use linear lookup whenever a hash-based >> lookup fails on casefolded directory, it may affect performance >> for sc

Re: [f2fs-dev] [PATCH] f2fs: support zero sized file truncate for device aliasing files

2025-03-21 Thread Daeho Jeong
On Mon, Mar 17, 2025 at 8:45 PM Chao Yu wrote: > > On 3/18/25 03:08, Daeho Jeong wrote: > > From: Daeho Jeong > > > > support a file truncation to zero size for device aliasing files. > > > > Signed-off-by: Daeho Jeong > > --- > > fs/f2fs/file.c | 5 - > > 1 file changed, 4 insertions(+), 1

Re: [f2fs-dev] [PATCH] f2fs: support zero sized file truncate for device aliasing files

2025-03-17 Thread Chao Yu via Linux-f2fs-devel
On 3/18/25 03:08, Daeho Jeong wrote: > From: Daeho Jeong > > support a file truncation to zero size for device aliasing files. > > Signed-off-by: Daeho Jeong > --- > fs/f2fs/file.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > i

Re: [f2fs-dev] [PATCH] f2fs: support F2FS_NOLINEAR_LOOKUP_FL

2025-03-05 Thread Christoph Hellwig
On Mon, Mar 03, 2025 at 11:06:44PM +, Eric Biggers wrote: > > +/* used for FS_IOC_GETFLAGS and FS_IOC_SETFLAGS */ > > +enum { > > + F2FS_NOLINEAR_LOOKUP_FLAG = 0x0800, > > +}; > > FS_IOC_GETFLAGS and FS_IOC_SETFLAGS are not filesystem-specific, and the > supported flags are declared in i

Re: [f2fs-dev] [PATCH] f2fs: support F2FS_NOLINEAR_LOOKUP_FL

2025-03-05 Thread Chao Yu via Linux-f2fs-devel
On 3/4/25 07:06, Eric Biggers wrote: > On Mon, Mar 03, 2025 at 11:46:06AM +0800, Chao Yu via Linux-f2fs-devel wrote: >> This patch introduces a new flag F2FS_NOLINEAR_LOOKUP_FL, so that we can >> tag casefolded directory w/ it to disable linear lookup functionality, >> it can be used for QA. >> >>

Re: [f2fs-dev] [PATCH] f2fs: support F2FS_NOLINEAR_LOOKUP_FL

2025-03-03 Thread Eric Biggers via Linux-f2fs-devel
On Mon, Mar 03, 2025 at 11:46:06AM +0800, Chao Yu via Linux-f2fs-devel wrote: > This patch introduces a new flag F2FS_NOLINEAR_LOOKUP_FL, so that we can > tag casefolded directory w/ it to disable linear lookup functionality, > it can be used for QA. > > Signed-off-by: Chao Yu > --- > fs/f2fs/di

Re: [f2fs-dev] [PATCH] f2fs: support dio write for zoned storage

2024-10-10 Thread Daeho Jeong
On Fri, Sep 27, 2024 at 12:25 AM Daejun Park wrote: > > With zoned storage, F2FS avoids direct IO writes and uses buffered writes > with page cache flushes to prevent unaligned writes. However, the > unaligned write can be avoided by allowing only a single thread per zone > to perform direct write

Re: [f2fs-dev] [PATCH] f2fs: support .shutdown in f2fs_sops

2024-04-14 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Thu, 29 Feb 2024 22:38:38 +0800 you wrote: > Support .shutdown callback in f2fs_sops, then, it can be called to > shut down the file system when underlying block device is marked dead. > > Signed-off-by: Chao Yu > --- >

Re: [f2fs-dev] [PATCH] f2fs: support .shutdown in f2fs_sops

2024-03-12 Thread Jaegeuk Kim
Will check this after merge window. On 03/12, Chao Yu wrote: > Ping, > > On 2024/2/29 22:38, Chao Yu wrote: > > Support .shutdown callback in f2fs_sops, then, it can be called to > > shut down the file system when underlying block device is marked dead. > > > > Signed-off-by: Chao Yu > > --- >

Re: [f2fs-dev] [PATCH] f2fs: support .shutdown in f2fs_sops

2024-03-11 Thread Chao Yu
Ping, On 2024/2/29 22:38, Chao Yu wrote: Support .shutdown callback in f2fs_sops, then, it can be called to shut down the file system when underlying block device is marked dead. Signed-off-by: Chao Yu --- fs/f2fs/f2fs.h | 2 ++ fs/f2fs/file.c | 70 ++-

Re: [f2fs-dev] [PATCH] f2fs: support SEEK_DATA and SEEK_HOLE for compression files

2024-02-22 Thread Chao Yu
On 2024/2/16 4:16, Daeho Jeong wrote: From: Daeho Jeong Fix to support SEEK_DATA and SEEK_HOLE for compression files Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.n

Re: [f2fs-dev] [PATCH] f2fs: support SEEK_DATA and SEEK_HOLE for compression files

2024-02-21 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Thu, 15 Feb 2024 12:16:33 -0800 you wrote: > From: Daeho Jeong > > Fix to support SEEK_DATA and SEEK_HOLE for compression files > > Signed-off-by: Daeho Jeong > --- > fs/f2fs/file.c | 21 ++--- > 1 fi

Re: [f2fs-dev] [PATCH] f2fs: support compress extension update via sysfs interface

2024-02-20 Thread Jaegeuk Kim
On 02/21, Chao Yu wrote: > On 2024/2/21 3:28, Jaegeuk Kim wrote: > > On 02/19, Chao Yu wrote: > > > On 2024/2/8 8:07, Jaegeuk Kim wrote: > > > > On 02/07, Chao Yu wrote: > > > > > Introduce /sys/fs/f2fs//compress_extension to support > > > > > adding/deleting compress extension via sysfs interface,

Re: [f2fs-dev] [PATCH] f2fs: support compress extension update via sysfs interface

2024-02-20 Thread Chao Yu
On 2024/2/21 3:28, Jaegeuk Kim wrote: On 02/19, Chao Yu wrote: On 2024/2/8 8:07, Jaegeuk Kim wrote: On 02/07, Chao Yu wrote: Introduce /sys/fs/f2fs//compress_extension to support adding/deleting compress extension via sysfs interface, in comparison to mount option, it's more easy to use and le

Re: [f2fs-dev] [PATCH] f2fs: support compress extension update via sysfs interface

2024-02-20 Thread Jaegeuk Kim
On 02/19, Chao Yu wrote: > On 2024/2/8 8:07, Jaegeuk Kim wrote: > > On 02/07, Chao Yu wrote: > > > Introduce /sys/fs/f2fs//compress_extension to support > > > adding/deleting compress extension via sysfs interface, in > > > comparison to mount option, it's more easy to use and less > > > authority

Re: [f2fs-dev] [PATCH] f2fs: support compress extension update via sysfs interface

2024-02-18 Thread Chao Yu
On 2024/2/8 8:07, Jaegeuk Kim wrote: On 02/07, Chao Yu wrote: Introduce /sys/fs/f2fs//compress_extension to support adding/deleting compress extension via sysfs interface, in comparison to mount option, it's more easy to use and less authority issue for applications. Usage: - Query: cat /sys/fs

Re: [f2fs-dev] [PATCH] f2fs: support compress extension update via sysfs interface

2024-02-07 Thread Jaegeuk Kim
On 02/07, Chao Yu wrote: > Introduce /sys/fs/f2fs//compress_extension to support > adding/deleting compress extension via sysfs interface, in > comparison to mount option, it's more easy to use and less > authority issue for applications. > > Usage: > - Query: cat /sys/fs/f2fs//compress_extension

Re: [f2fs-dev] [PATCH] f2fs: Support enhanced hot/cold data separation for f2fs

2024-01-26 Thread Eric Biggers
On Fri, Jan 26, 2024 at 01:32:05PM -0800, Luis Chamberlain wrote: > On Fri, Jan 26, 2024 at 09:01:06PM +, Matthew Wilcox wrote: > > On Thu, Jan 25, 2024 at 12:54:47PM -0800, Luis Chamberlain wrote: > > > On Thu, Jan 25, 2024 at 08:47:39PM +, Matthew Wilcox wrote: > > > > On Wed, Dec 07, 202

Re: [f2fs-dev] [PATCH] f2fs: Support enhanced hot/cold data separation for f2fs

2024-01-26 Thread Luis Chamberlain
On Fri, Jan 26, 2024 at 09:01:06PM +, Matthew Wilcox wrote: > On Thu, Jan 25, 2024 at 12:54:47PM -0800, Luis Chamberlain wrote: > > On Thu, Jan 25, 2024 at 08:47:39PM +, Matthew Wilcox wrote: > > > On Wed, Dec 07, 2022 at 12:51:13PM -0800, Luis Chamberlain wrote: > > > > Me and Pankaj are v

Re: [f2fs-dev] [PATCH] f2fs: Support enhanced hot/cold data separation for f2fs

2024-01-26 Thread Matthew Wilcox
On Thu, Jan 25, 2024 at 12:54:47PM -0800, Luis Chamberlain wrote: > On Thu, Jan 25, 2024 at 08:47:39PM +, Matthew Wilcox wrote: > > On Wed, Dec 07, 2022 at 12:51:13PM -0800, Luis Chamberlain wrote: > > > Me and Pankaj are very interested in helping on this front. And so we'll > > > start to org

Re: [f2fs-dev] [PATCH] f2fs: Support enhanced hot/cold data separation for f2fs

2024-01-25 Thread Luis Chamberlain
On Thu, Jan 25, 2024 at 08:47:39PM +, Matthew Wilcox wrote: > On Wed, Dec 07, 2022 at 12:51:13PM -0800, Luis Chamberlain wrote: > > On Wed, Nov 30, 2022 at 03:18:41PM +, Matthew Wilcox wrote: > > > From a filesystem point of view, you need to ensure that you handle folios > > > larger than

Re: [f2fs-dev] [PATCH] f2fs: Support enhanced hot/cold data separation for f2fs

2024-01-25 Thread Matthew Wilcox
On Wed, Dec 07, 2022 at 12:51:13PM -0800, Luis Chamberlain wrote: > On Wed, Nov 30, 2022 at 03:18:41PM +, Matthew Wilcox wrote: > > From a filesystem point of view, you need to ensure that you handle folios > > larger than PAGE_SIZE correctly. The easiest way is to spread the use > > of folios

Re: [f2fs-dev] [PATCH] f2fs: support to show noage_extent_cache mount option

2023-04-03 Thread Chao Yu
On 2023/4/4 1:40, Jaegeuk Kim wrote: On 03/31, Yangtao Li wrote: This patch support noage_extent_cache mount option. Signed-off-by: Yangtao Li --- Documentation/filesystems/f2fs.rst | 2 ++ fs/f2fs/super.c| 7 +++ 2 files changed, 9 insertions(+) diff --git a/Docum

Re: [f2fs-dev] [PATCH] f2fs: support to show noage_extent_cache mount option

2023-04-03 Thread Jaegeuk Kim
On 03/31, Yangtao Li wrote: > This patch support noage_extent_cache mount option. > > Signed-off-by: Yangtao Li > --- > Documentation/filesystems/f2fs.rst | 2 ++ > fs/f2fs/super.c| 7 +++ > 2 files changed, 9 insertions(+) > > diff --git a/Documentation/filesystems/f2fs

Re: [f2fs-dev] [PATCH] f2fs: Support enhanced hot/cold data separation for f2fs

2022-12-07 Thread Luis Chamberlain
On Wed, Nov 30, 2022 at 03:18:41PM +, Matthew Wilcox wrote: > On Wed, Nov 30, 2022 at 08:48:04PM +0800, Yangtao Li wrote: > > Hi, > > > > > Thanks for reviewing this. I think the real solution to this is > > > that f2fs should be using large folios. That way, the page cache > > > will keep t

Re: [f2fs-dev] [PATCH] f2fs: Support enhanced hot/cold data separation for f2fs

2022-11-30 Thread Matthew Wilcox
On Wed, Nov 30, 2022 at 08:48:04PM +0800, Yangtao Li wrote: > Hi, > > > Thanks for reviewing this. I think the real solution to this is > > that f2fs should be using large folios. That way, the page cache > > will keep track of dirtiness on a per-folio basis, and if your folios > > are at least

Re: [f2fs-dev] [PATCH] f2fs: Support enhanced hot/cold data separation for f2fs

2022-11-30 Thread Yangtao Li via Linux-f2fs-devel
Hi, > Thanks for reviewing this. I think the real solution to this is > that f2fs should be using large folios. That way, the page cache > will keep track of dirtiness on a per-folio basis, and if your folios > are at least as large as your cluster size, you won't need to do the > f2fs_prepare_c

Re: [f2fs-dev] [PATCH] f2fs: Support enhanced hot/cold data separation for f2fs

2022-11-28 Thread Yangtao Li via Linux-f2fs-devel
Hi qixiaoyu1, Thanks for your patchset. Does this patchset have data related to memory and performance impact? Can you provide scripts or commands for related tests? Thx, Yangtao ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.ne

Re: [f2fs-dev] [PATCH] f2fs: support fault injection for flush submission error

2022-11-09 Thread Matthew Wilcox
On Thu, Nov 10, 2022 at 02:35:49AM +0800, Yangtao Li wrote: > +++ b/fs/f2fs/segment.c > @@ -486,7 +486,17 @@ void f2fs_balance_fs_bg(struct f2fs_sb_info *sbi, bool > from_bg) > static int __submit_flush_wait(struct f2fs_sb_info *sbi, > struct block_device *bdev) > {

Re: [f2fs-dev] [PATCH] f2fs: support plain user/group quota

2017-07-08 Thread Chao Yu
Hi Jaegeuk, On 2017/7/8 3:12, Jaegeuk Kim wrote: > Hi Chao, > > I've updated your patch like this. > > - modify description > - use filemap_write_and_wait() directly aligned to the below v2 patch. > > f2fs: avoid deadlock caused by lock order of page and Looks good to me. I've updated doc

Re: [f2fs-dev] [PATCH] f2fs: support plain user/group quota

2017-07-07 Thread Jaegeuk Kim
Hi Chao, I've updated your patch like this. - modify description - use filemap_write_and_wait() directly aligned to the below v2 patch. f2fs: avoid deadlock caused by lock order of page and Thanks, >From 4aa1d70e8e7767712733dc79147030aa682ee9ef Mon Sep 17 00:00:00 2001 From: Chao Yu Date:

Re: [f2fs-dev] [PATCH] F2FS support

2017-05-04 Thread Adam Borowski
On Thu, May 04, 2017 at 11:12:40AM -0700, Jaegeuk Kim wrote: > "F2FS (Flash-Friendly File System) is flash-friendly file system which was > merged > into Linux kernel v3.8 in 2013. > > The motive for F2FS was to build a file system that from the start, takes into > account the characteristics of

Re: [f2fs-dev] [PATCH] f2fs: support multiple devices

2016-11-10 Thread Anand Jain
(this is deviating from the subject, sorry about that) > Pretty much, if you're using just raid1 mode, without > compression, on reasonable storage devices, things are rock-solid > relative to the rest of BTRFS. IMO, BTRFS volume manger feature is incomplete and there is RAID1 critical bug whi

Re: [f2fs-dev] [PATCH] f2fs: support multiple devices

2016-11-10 Thread Austin S. Hemmelgarn
On 2016-11-09 21:29, Qu Wenruo wrote: > > > At 11/10/2016 06:57 AM, Andreas Dilger wrote: >> On Nov 9, 2016, at 1:56 PM, Jaegeuk Kim wrote: >>> >>> This patch implements multiple devices support for f2fs. >>> Given multiple devices by mkfs.f2fs, f2fs shows them entirely as one big >>> volume under

Re: [f2fs-dev] [PATCH] f2fs: support multiple devices

2016-11-09 Thread Qu Wenruo
At 11/10/2016 06:57 AM, Andreas Dilger wrote: > On Nov 9, 2016, at 1:56 PM, Jaegeuk Kim wrote: >> >> This patch implements multiple devices support for f2fs. >> Given multiple devices by mkfs.f2fs, f2fs shows them entirely as one big >> volume under one f2fs instance. >> >> Internal block manage

Re: [f2fs-dev] [PATCH] f2fs: support multiple devices

2016-11-09 Thread Jaegeuk Kim
On Wed, Nov 09, 2016 at 03:57:53PM -0700, Andreas Dilger wrote: > On Nov 9, 2016, at 1:56 PM, Jaegeuk Kim wrote: > > > > This patch implements multiple devices support for f2fs. > > Given multiple devices by mkfs.f2fs, f2fs shows them entirely as one big > > volume under one f2fs instance. > > >

Re: [f2fs-dev] [PATCH] f2fs: support multiple devices

2016-11-09 Thread Darrick J. Wong
On Wed, Nov 09, 2016 at 03:57:53PM -0700, Andreas Dilger wrote: > On Nov 9, 2016, at 1:56 PM, Jaegeuk Kim wrote: > > > > This patch implements multiple devices support for f2fs. > > Given multiple devices by mkfs.f2fs, f2fs shows them entirely as one big > > volume under one f2fs instance. > > >

Re: [f2fs-dev] [PATCH] f2fs: support access control via key management

2016-03-21 Thread Christoph Hellwig
On Tue, Mar 15, 2016 at 09:37:25AM -0700, Jaegeuk Kim wrote: > I agree that I must follow FS convention here. > But, in order to make this clear out, could you please elaborate why this is > not > allowed? > > I wrote this patch totally based on per-file encryption in which users cannot > access

Re: [f2fs-dev] [PATCH] f2fs: support access control via key management

2016-03-15 Thread Jaegeuk Kim
Hello, On Tue, Mar 15, 2016 at 12:24:22AM -0700, Christoph Hellwig wrote: > On Wed, Mar 09, 2016 at 04:52:48PM -0800, Jaegeuk Kim wrote: > > Through this patch, user can assign its key into a specific normal files. > > Then, other users who do not have that key cannot open the files. > > Later, ow

Re: [f2fs-dev] [PATCH] f2fs: support access control via key management

2016-03-15 Thread Christoph Hellwig
On Wed, Mar 09, 2016 at 04:52:48PM -0800, Jaegeuk Kim wrote: > Through this patch, user can assign its key into a specific normal files. > Then, other users who do not have that key cannot open the files. > Later, owner can drop its key from the files for other users to access > the files again. N

Re: [f2fs-dev] [PATCH] f2fs: support file defragment

2015-10-26 Thread Jaegeuk Kim
Hi, On Fri, Oct 23, 2015 at 02:57:03PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > > Sent: Friday, October 23, 2015 2:12 AM > > To: Chao Yu > > Cc: linux-f2fs-devel@lists.sourceforge.net; linux-ker...@vger.kernel.org > >

Re: [f2fs-dev] [PATCH] f2fs: support file defragment

2015-10-22 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Friday, October 23, 2015 2:12 AM > To: Chao Yu > Cc: linux-f2fs-devel@lists.sourceforge.net; linux-ker...@vger.kernel.org > Subject: Re: [PATCH] f2fs: support file defragment > > Hi, > > On Thu, Oct

Re: [f2fs-dev] [PATCH] f2fs: support file defragment

2015-10-22 Thread Jaegeuk Kim
Hi, On Thu, Oct 22, 2015 at 07:59:14PM +0800, Chao Yu wrote: > This patch introduces a new ioctl F2FS_IOC_DEFRAGMENT to support file > defragment in a specified range of regular file. > > This ioctl can be used in very limited workload: if user expects high > sequential read performance in random

Re: [f2fs-dev] [PATCH] F2FS support

2015-04-03 Thread Jaegeuk Kim
Hi Andrei, On Sat, Mar 28, 2015 at 10:31:55AM +0300, Andrei Borzenkov wrote: > В Tue, 24 Mar 2015 01:19:00 -0700 > Jaegeuk Kim пишет: > ... > > +/* byte-size offset */ > > +#define F2FS_SUPER_OFFSET 1024 > > + > > +/* 12 bits for 4096 bytes */ > > +#define F2FS_MAX_LOG_SECTOR_SIZE 1

Re: [f2fs-dev] [PATCH] F2FS support

2015-03-28 Thread Andrei Borzenkov
В Sat, 28 Mar 2015 13:43:18 -0700 Jaegeuk Kim пишет: > Hi Andrei, > > On Sat, Mar 28, 2015 at 10:31:55AM +0300, Andrei Borzenkov wrote: > > В Tue, 24 Mar 2015 01:19:00 -0700 > > Jaegeuk Kim пишет: > > > > > * Makefile.util.def: Add f2fs.c. > > > * doc/grub.texi: Add f2fs description. > > >

Re: [f2fs-dev] [PATCH] F2FS support

2015-03-28 Thread Jaegeuk Kim
Hi Andrei, On Sat, Mar 28, 2015 at 10:31:55AM +0300, Andrei Borzenkov wrote: > В Tue, 24 Mar 2015 01:19:00 -0700 > Jaegeuk Kim пишет: > > > * Makefile.util.def: Add f2fs.c. > > * doc/grub.texi: Add f2fs description. > > * grub-core/Makefile.core.def: Add f2fs module. > > * grub-core/fs/f2fs.

Re: [f2fs-dev] [PATCH] F2FS support

2015-03-28 Thread Andrei Borzenkov
В Tue, 24 Mar 2015 01:19:00 -0700 Jaegeuk Kim пишет: > * Makefile.util.def: Add f2fs.c. > * doc/grub.texi: Add f2fs description. > * grub-core/Makefile.core.def: Add f2fs module. > * grub-core/fs/f2fs.c: New file. > * tests/f2fs_test.in: New file. > * tests/util/grub-fs-tester.in: Add f2fs