Re: [f2fs-dev] [PATCH] f2fs: Add check for deleted inode

2024-11-28 Thread Chao Yu via Linux-f2fs-devel
On 2024/11/26 1:56, Leo Stone wrote: On Mon, Nov 25, 2024 at 07:16:41PM +0800, Chao Yu wrote: I'm fine w/ this change, but I didn't get it, how did above commit introduce this bug? Hello Chao, The commit from the bisect didn't exactly introduce this bug, since it would still be possible to m

Re: [f2fs-dev] [PATCH] f2fs: Add check for deleted inode

2024-11-25 Thread Leo Stone
On Mon, Nov 25, 2024 at 07:16:41PM +0800, Chao Yu wrote: > > I'm fine w/ this change, but I didn't get it, how did above commit introduce > this bug? Hello Chao, The commit from the bisect didn't exactly introduce this bug, since it would still be possible to make a different image that does the

Re: [f2fs-dev] [PATCH] f2fs: Add check for deleted inode

2024-11-25 Thread Chao Yu via Linux-f2fs-devel
On 2024/11/24 9:04, Leo Stone wrote: The syzbot reproducer mounts a f2fs image, then tries to unlink an existing file. However, the unlinked file already has a link count of 0 when it is read for the first time in do_read_inode(). Add a check to sanity_check_inode() for i_nlink == 0. #syz test