Re: [f2fs-dev] [PATCH] f2fs: fix to handle looped node chain during recovery

2018-02-04 Thread Chao Yu
Well, that's classic algorithm for checking loop in a list, as well as other one we know, in order to decrease time complexity of these algorithms, their implementations are a little more complex. But IMO, the issue we are trying to fix is really a corner case, and the performance in that path is

Re: [f2fs-dev] [PATCH] f2fs: fix to handle looped node chain during recovery

2018-02-03 Thread Gao Xiang via Linux-f2fs-devel
Sorry, I saw the related code entirely, please ignore these replies. On 2018/2/3 18:45, Gao Xiang wrote: On 2018/2/3 18:35, Gao Xiang wrote: Hi Chao and YunLei, On 2018/2/3 17:44, Chao Yu wrote: There is no checksum in node block now, so bit-transition from hardware can make

Re: [f2fs-dev] [PATCH] f2fs: fix to handle looped node chain during recovery

2018-02-03 Thread Gao Xiang via Linux-f2fs-devel
On 2018/2/3 18:35, Gao Xiang wrote: Hi Chao and YunLei, On 2018/2/3 17:44, Chao Yu wrote: There is no checksum in node block now, so bit-transition from hardware can make node_footer.next_blkaddr being corrupted w/o any detection, result in node chain becoming looped one. For this

Re: [f2fs-dev] [PATCH] f2fs: fix to handle looped node chain during recovery

2018-02-03 Thread Gao Xiang via Linux-f2fs-devel
Hi Chao and YunLei, On 2018/2/3 17:44, Chao Yu wrote: There is no checksum in node block now, so bit-transition from hardware can make node_footer.next_blkaddr being corrupted w/o any detection, result in node chain becoming looped one. For this condition, during recovery, in order to avoid