Re: [f2fs-dev] [PATCH] f2fs: fix to map blocks correctly for direct read

2024-11-01 Thread Chao Yu via Linux-f2fs-devel
On 2024/11/2 5:06, Jaegeuk Kim wrote: On 11/01, Chao Yu wrote: On 2024/11/1 9:22, Jaegeuk Kim wrote: On 10/31, Chao Yu wrote: f2fs_map_blocks() supports to map continuous holes or preallocated address, we should avoid setting F2FS_MAP_MAPPED for these cases only, otherwise, it may fail f2fs_io

Re: [f2fs-dev] [PATCH] f2fs: fix to map blocks correctly for direct read

2024-11-01 Thread Jaegeuk Kim via Linux-f2fs-devel
On 11/01, Chao Yu wrote: > On 2024/11/1 9:22, Jaegeuk Kim wrote: > > On 10/31, Chao Yu wrote: > > > f2fs_map_blocks() supports to map continuous holes or preallocated > > > address, we should avoid setting F2FS_MAP_MAPPED for these cases > > > only, otherwise, it may fail f2fs_iomap_begin(), and ma

Re: [f2fs-dev] [PATCH] f2fs: fix to map blocks correctly for direct read

2024-10-31 Thread Chao Yu via Linux-f2fs-devel
On 2024/11/1 9:22, Jaegeuk Kim wrote: On 10/31, Chao Yu wrote: f2fs_map_blocks() supports to map continuous holes or preallocated address, we should avoid setting F2FS_MAP_MAPPED for these cases only, otherwise, it may fail f2fs_iomap_begin(), and make direct write fallbacking to use buffered IO

Re: [f2fs-dev] [PATCH] f2fs: fix to map blocks correctly for direct read

2024-10-31 Thread Jaegeuk Kim via Linux-f2fs-devel
On 10/31, Chao Yu wrote: > f2fs_map_blocks() supports to map continuous holes or preallocated > address, we should avoid setting F2FS_MAP_MAPPED for these cases > only, otherwise, it may fail f2fs_iomap_begin(), and make direct > write fallbacking to use buffered IO and flush, result in performance