Re: [f2fs-dev] [PATCH 1/1] f2fs: correctly check empty xattr key

2015-03-22 Thread Taesoo Kim
Hi Jaegeuk, Thank you for letting us know. We have another question: @f2fs_sync_file() if (unlikely(f2fs_readonly(inode-i_sb))) return 0; Isn't it better to report '-EROFS' as ext3/4? I suspect that f2fs returns 0 as fsync() man page doesn't specify such error condition. We are

Re: [f2fs-dev] [PATCH 1/1] f2fs: correctly check empty xattr key

2015-03-20 Thread Jaegeuk Kim
Hi Taesoo, On Fri, Mar 20, 2015 at 12:19:07AM -0400, Taesoo Kim wrote: When xattr name (key) is empty (), correctly return -EINVAL error. xattr_advise_set/get() seem to make the same mistake. The intention here is to disallow any xattr name, since this is used to get or set the i_advise value