2013-12-02 (월), 14:14 +0800, Chao Yu:
> Hi Kim,
>
> > -Original Message-
> > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
> > Sent: Saturday, November 30, 2013 9:48 AM
> > Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
> > linux-f2fs-devel@lists.sourceforge.net
> >
Hi,
2013-12-02 (월), 12:47 +0800, Chao Yu:
> Hi,
>
> Some comments as following.
>
> > -Original Message-
> > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
> > Sent: Saturday, November 30, 2013 2:26 PM
> > Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
> > linux-f2
Change log from v1:
o remove redundant codes
>From a480dfc915490f4bca7275f6fbb44fa34aa00eaa Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim
Date: Sat, 30 Nov 2013 12:51:14 +0900
Subject: [PATCH] f2fs: refactor bio-related operations
Cc: linux-fsde...@vger.kernel.org, linux-ker...@vger.kernel.org,
li
Hi Kim,
> -Original Message-
> From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
> Sent: Monday, December 02, 2013 4:15 PM
> To: Chao Yu
> Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
> linux-f2fs-devel@lists.sourceforge.net; 谭姝
> Subject: RE: [f2fs-dev] [PATCH] f2fs:
> -Original Message-
> From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
> Sent: Monday, December 02, 2013 4:27 PM
> To: linux-fsde...@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net
> Subject: Re: [f2fs-dev] [PATCH v2] f2fs: refactor bio-related
From: Younger Liu
When debugfs_create_file() failed in f2fs_create_root_stats(),
debugfs_root should be removed.
Signed-off-by: Younger Liu
Cc: Younger Liu
Cc: Jaegeuk Kim
---
fs/f2fs/debug.c | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/
From: Younger Liu
This minor change for the naming conventions of debugfs_root
to avoid any possible conflicts to the other filesystem.
This patch is based on the first patch
"[PATCH 0/2] f2fs: remove debufs dir if debugfs_create_file() failed".
Signed-off-by: Younger Liu
Cc: Younger Liu
Cc:
Signed-off-by: Christoph Hellwig
---
fs/reiserfs/xattr_acl.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/fs/reiserfs/xattr_acl.c b/fs/reiserfs/xattr_acl.c
index 06c04f7..6f721ea 100644
--- a/fs/reiserfs/xattr_acl.c
+++ b/fs/reiserfs/xattr_acl.c
@@
Signed-off-by: Christoph Hellwig
---
fs/jffs2/acl.c | 134 +---
fs/jffs2/acl.h |7 +--
fs/jffs2/dir.c |1 +
fs/jffs2/file.c|1 +
fs/jffs2/fs.c |2 +-
fs/jffs2/symlink.c |1 +
fs/jffs2/xattr.c |9 ++--
On Sun 01-12-13 03:59:04, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig
Looks good. You can add:
Reviewed-by: Jan Kara
Honza
> ---
> fs/reiserfs/xattr_acl.c | 20 ++--
> 1 file changed, 10 inserti
On Sun 01-12-13 03:59:07, Christoph Hellwig wrote:
> With the ->set_acl inode operation we can implement the Posix ACL
> xattr handlers in generic code instead of duplicating them all
> over the tree.
Looks good. You can add:
Reviewed-by: Jan Kara
Rename the current posix_acl_created to __posix_acl_create and add
a fully featured helper to set up the ACLs on file creation that
uses get_acl().
Signed-off-by: Christoph Hellwig
---
fs/9p/acl.c |2 +-
fs/btrfs/acl.c|2 +-
fs/ext2/acl.c |2 +-
Signed-off-by: Christoph Hellwig
---
fs/reiserfs/acl.h |4 +-
fs/reiserfs/file.c |1 +
fs/reiserfs/namei.c |3 +
fs/reiserfs/xattr.c |5 +-
fs/reiserfs/xattr_acl.c | 175 ---
5 files changed, 36 insertions(+), 152 del
Signed-off-by: Christoph Hellwig
---
fs/hfsplus/acl.h |9 +--
fs/hfsplus/dir.c |1 +
fs/hfsplus/inode.c |3 +-
fs/hfsplus/posix_acl.c | 161 +---
fs/hfsplus/xattr.c |5 +-
fs/hfsplus/xattr.h |2 -
6 files cha
This series consolidates the various cut'n'pasted Posix ACL implementations
into a single common one based on the ->get_acl method Linus added a while
ago and a new ->set_acl counterpart.
This 1600 lines of code and provides a single place to implement various
nasty little gems of the semantics.
This contains some major refactoring for the create path so that
inodes are created with the right mode to start with instead of
fixing it up later.
Signed-off-by: Christoph Hellwig
---
fs/gfs2/acl.c | 229 +++
fs/gfs2/acl.h |4 +-
fs/
With the ->set_acl inode operation we can implement the Posix ACL
xattr handlers in generic code instead of duplicating them all
over the tree.
Signed-off-by: Christoph Hellwig
---
fs/xattr_acl.c | 95 +++
include/linux/posix_acl_xattr.h |
Signed-off-by: Christoph Hellwig
---
fs/nfs/inode.c |4 -
fs/nfs/nfs3acl.c | 287 ++--
fs/nfs/nfs3proc.c | 26 +++--
fs/nfs/nfs3super.c |3 +
include/linux/nfs_fs.h | 10 +-
5 files changed, 79 insertions(+), 251 dele
On Dec 1, 2013, at 2:59 PM, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig
> ---
> fs/hfsplus/acl.h |9 +--
> fs/hfsplus/dir.c |1 +
> fs/hfsplus/inode.c |3 +-
> fs/hfsplus/posix_acl.c | 161 +---
> fs/hfsplus/xat
Also create inodes with the proper mode instead of fixing it up later.
Signed-off-by: Christoph Hellwig
---
fs/xfs/xfs_acl.c | 138 +++-
fs/xfs/xfs_acl.h |9 +---
fs/xfs/xfs_iops.c | 39 ---
fs/xfs/xfs_iops.h |2 +-
fs/
f2fs has some weird mode bit handling, so still using the old
chmod code for now.
Signed-off-by: Christoph Hellwig
---
fs/f2fs/acl.c | 140 +--
fs/f2fs/acl.h |1 +
fs/f2fs/file.c |1 +
fs/f2fs/namei.c |2 +
fs/f2fs/xattr.c |
On Sun 01-12-13 03:59:08, Christoph Hellwig wrote:
> Rename the current posix_acl_chmod to __posix_acl_chmod and add
> a fully featured ACL chmod helper that uses the ->set_acl inode
> operation.
Looks good. You can add:
Reviewed-by: Jan Kara
And instead convert tmpfs to use the new generic ACL code, with two stub
methods provided for in-memory filesystems.
Signed-off-by: Christoph Hellwig
---
fs/Kconfig |6 +-
fs/Makefile |1 -
fs/generic_acl.c| 184 --
On Sun 01-12-13 03:59:16, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig
Looks good. You can add:
Reviewed-by: Jan Kara
Honza
> ---
> fs/reiserfs/acl.h |4 +-
> fs/reiserfs/file.c |1 +
> fs/reise
Factor out the code to get an ACL either from the inode or disk from
check_acl, so that it can be used elsewhere later on.
Signed-off-by: Christoph Hellwig
---
fs/namei.c| 24 +++-
fs/posix_acl.c| 23 +++
include/linux/posix
On Sun 01-12-13 03:59:09, Christoph Hellwig wrote:
> Rename the current posix_acl_created to __posix_acl_create and add
> a fully featured helper to set up the ACLs on file creation that
> uses get_acl().
Looks good, you can add:
Reviewed-by: Jan Kara
On 12/01/2013 05:59 AM, Christoph Hellwig wrote:
> Copy the scheme I introduced to btrfs many years ago to only use the
> xattr handler for ACLs, but pass plain attrs straight through.
Looks good.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Dave Kleikamp
> ---
> fs/jfs/acl.c | 1
Signed-off-by: Christoph Hellwig
---
fs/btrfs/acl.c | 135 --
fs/btrfs/ctree.h |7 +--
fs/btrfs/inode.c |7 ++-
fs/btrfs/xattr.c |5 +-
fs/btrfs/xattr.h |2 -
5 files changed, 29 insertions(+), 127 deletions(-)
diff --git a/f
Rename the current posix_acl_chmod to __posix_acl_chmod and add
a fully featured ACL chmod helper that uses the ->set_acl inode
operation.
Signed-off-by: Christoph Hellwig
---
fs/9p/acl.c |2 +-
fs/btrfs/acl.c|2 +-
fs/ext2/acl.c |2 +-
fs/ext3/a
This contains some major refactoring for the create path so that
inodes are created with the right mode to start with instead of
fixing it up later.
Signed-off-by: Christoph Hellwig
---
fs/ocfs2/acl.c | 234 ++-
fs/ocfs2/acl.h | 13
Signed-off-by: Christoph Hellwig
---
fs/ext2/acl.c | 176 -
fs/ext2/acl.h |8 +--
fs/ext2/file.c |1 +
fs/ext2/inode.c |2 +-
fs/ext2/namei.c |2 +
fs/ext2/xattr.c |8 +--
fs/ext2/xattr.h |2 -
fs/ext3/acl.c | 213 ++
On Sun 01-12-13 03:59:06, Christoph Hellwig wrote:
> This will allow moving all the Posix ACL handling into the VFS and clean
> up tons of cruft in the filesystems.
Looks good. Btw I'd merge this with the following patch... Anyway:
Reviewed-by: Jan Kara
On Sun 01-12-13 03:59:05, Christoph Hellwig wrote:
> Factor out the code to get an ACL either from the inode or disk from
> check_acl, so that it can be used elsewhere later on.
>
> Signed-off-by: Christoph Hellwig
Looks good. You can add:
Reviewed-by: Jan Kara
On Sun 01-12-13 03:59:11, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig
Looks good. You can add:
Reviewed-by: Jan Kara
Honza
> ---
> fs/ext2/acl.c | 176 -
> fs/ext2/acl.h |
This will allow moving all the Posix ACL handling into the VFS and clean
up tons of cruft in the filesystems.
Signed-off-by: Christoph Hellwig
---
include/linux/fs.h |1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 121f11f..09f553c 100644
--- a
On Sun 01-12-13 03:59:15, Christoph Hellwig wrote:
> This contains some major refactoring for the create path so that
> inodes are created with the right mode to start with instead of
> fixing it up later.
>
> Signed-off-by: Christoph Hellwig
...
> -int ocfs2_acl_chmod(struct inode *inode)
> -{
>
Hi Liu,
You're right, we should release it instead of holding the resource
with no use. And here are some comments as following.
BTW, your patch is out of format. You'd better not let remote
terminal or editor to instead tab with blanks in the patch.
Thanks,
Yu
> -Original Message-
> Fr
37 matches
Mail list logo
