-Original Message-
From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
Sent: Friday, December 06, 2013 2:15 PM
Cc: Jaegeuk Kim; linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;
linux-f2fs-devel@lists.sourceforge.net; Chao Yu
Subject: [PATCH] f2fs: add unlikely() macro for
This patch introduces f2fs_cache_node_page(), in this function, page which is
readed ahead will be copy to node_inode's mapping cache.
It will avoid rereading these node pages.
change log:
o check validity of grabbed page suggested by Jaegeuk Kim.
Suggested-by: Jaegeuk Kim
Jaegeuk Kim jaegeuk@samsung.com writes:
struct page *page;
repeat:
page = grab_cache_page(mapping, index);
- if (!page) {
+ if (unlikely(!page)) {
This is completely pointless, gcc already considers any test for NULL
unlikely.
In general i would advise against
