Re: [f2fs-dev] [PATCH 3/3 V3] f2fs: introduce f2fs_cache_node_page() to add page into node_inode cache

2013-12-09 Thread Jaegeuk Kim
Hi, Sorry for the noise. Once I tested this patch, I recognized that I made a mistake: f2fs_fill_super() 1. build_segment_manager() -> restore_node_summary() -> NULL pointer exception, due to no NAT cache. 2. build_node_manager() So, we should not call get_node_info() prior to build

[f2fs-dev] [PATCH]f2fs: merge pages with the same sync_mode flag

2013-12-09 Thread Fan Li
Previously f2fs submits most of write requests using WRITE_SYNC, but f2fs_write_data_pages submits last write requests by sync_mode flags callers pass. This causes a performance problem since continuous pages with different sync flags can't be merged in cfq IO scheduler(thanks yu chao for pointi

Re: [f2fs-dev] [PATCH 3/3 V3] f2fs: introduce f2fs_cache_node_page() to add page into node_inode cache

2013-12-09 Thread Chao Yu
Hi, > -Original Message- > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > Sent: Monday, December 09, 2013 4:01 PM > To: Chao Yu > Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH 3/3 V3] f2fs:

Re: [f2fs-dev] [PATCH 3/3 V3] f2fs: introduce f2fs_cache_node_page() to add page into node_inode cache

2013-12-09 Thread Chao Yu
Hi, > -Original Message- > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > Sent: Monday, December 09, 2013 4:01 PM > To: Chao Yu > Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH 3/3 V3] f2fs:

[f2fs-dev] [PATCH] f2fs: unify rw and sync parameter into rw

2013-12-09 Thread Changman Lee
When we submit io, we can know whether the io is read or write and sync mode or not. So we can remove redundant sync parameter. Signed-off-by: Changman Lee --- fs/f2fs/checkpoint.c | 12 ++-- fs/f2fs/data.c | 19 --- fs/f2fs/f2fs.h |2 +- fs/f2fs/gc.c