Re: [f2fs-dev] [PATCH RESEND] f2fs: maintain extent cache in separated file

2015-07-14 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Chao Yu [mailto:yuchaoch...@hotmail.com] > Sent: Thursday, July 09, 2015 12:16 AM > To: 'Jaegeuk Kim' > Cc: linux-ker...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH RESEND] f2fs: maintain extent cache in

Re: [f2fs-dev] [f2fs:dev-test 24/27] fs/f2fs/data.c:1136:5: sparse: symbol 'f2fs_write_cache_pages' was not declared. Should it be static?

2015-07-14 Thread Chao Yu
Hi Fengguang, Thanks for your reminder. Issue was fixed. Regards, > -Original Message- > From: kbuild test robot [mailto:fengguang...@intel.com] > Sent: Tuesday, July 14, 2015 8:24 AM > To: Chao Yu > Cc: kbuild-...@01.org; Jaegeuk Kim; Changman Lee; > linux-f2fs-devel@lists.sourceforge.

Re: [f2fs-dev] [PATCH] f2fs: fix to release inode page in get_new_data_page

2015-07-14 Thread Chao Yu
> -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Tuesday, July 14, 2015 7:26 AM > To: Chao Yu > Cc: linux-ker...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to release inode page in > get_new_data_page [sn

[f2fs-dev] [PATCH v2] f2fs: fix to release inode page in get_new_data_page

2015-07-14 Thread Chao Yu
In following call path, we will pass a locked and referenced ipage pointer to get_new_data_page: - init_inode_metadata - make_empty_dir - get_new_data_page There are two exit paths in get_new_data_page when error occurs: 1) grab_cache_page fails, ipage will not be released; 2) f2fs_reserve_b

[f2fs-dev] [PATCH 1/4 v2] f2fs: expose f2fs_write_cache_pages

2015-07-14 Thread Chao Yu
If there are gced dirty pages and normal dirty pages in the mapping of one inode, we might writeback them alternately with discontinuous block address, resulting in low performance. This patch introduces f2fs_write_cache_pages with codes copied from write_cache_pages in mm/page-writeback.c. In th

[f2fs-dev] [PATCH 1/4 v2 RESEND] f2fs: expose f2fs_write_cache_pages

2015-07-14 Thread Chao Yu
If there are gced dirty pages and normal dirty pages in the mapping of one inode, we might writeback them alternately with discontinuous block address, resulting in low performance. This patch introduces f2fs_write_cache_pages with codes copied from write_cache_pages in mm/page-writeback.c. In th

[f2fs-dev] [PATCH 2/2] f2fs: use a page temporarily for encrypted gced page

2015-07-14 Thread Jaegeuk Kim
That encrypted page is used temporarily, so we don't need to mark it accessed. Signed-off-by: Jaegeuk Kim --- fs/f2fs/gc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index db11861..ca562df 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -5

[f2fs-dev] [PATCH 1/2] f2fs: handle error cases in move_encrypted_block

2015-07-14 Thread Jaegeuk Kim
This patch fixes some missing error handlers. Signed-off-by: Jaegeuk Kim --- fs/f2fs/gc.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 11046db..db11861 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -556,27 +556

Re: [f2fs-dev] [PATCH RESEND] f2fs: maintain extent cache in separated file

2015-07-14 Thread Jaegeuk Kim
On Tue, Jul 14, 2015 at 06:10:50PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -Original Message- > > From: Chao Yu [mailto:yuchaoch...@hotmail.com] > > Sent: Thursday, July 09, 2015 12:16 AM > > To: 'Jaegeuk Kim' > > Cc: linux-ker...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net >

Re: [f2fs-dev] [PATCH 1/2] f2fs: handle error cases in move_encrypted_block

2015-07-14 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Wednesday, July 15, 2015 3:18 AM > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 1/2] f2fs: ha

Re: [f2fs-dev] [PATCH 2/2] f2fs: use a page temporarily for encrypted gced page

2015-07-14 Thread Chao Yu
> -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Wednesday, July 15, 2015 3:18 AM > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 2/2] f2fs: use a page temp