Re: [f2fs-dev] [PATCH 1/2] f2fs: handle failed bio allocation

Hi Chao, [snip] - /* No failure on bio allocation */ - bio = bio_alloc(GFP_NOIO, npages); How about using __GFP_NOFAIL flag to avoid failing in bio_alloc instead of adding opencode endless loop in code? We can see the reason in this commit 647757197cd3

Re: [f2fs-dev] [PATCH] fs/f2fs: replace open coded nofail allocation in __add_ino_entry

Hi Zhang, On Mon, Aug 24, 2015 at 11:39:55AM +0800, Zhang Zhen wrote: __add_ino_entry is looping around the allocation request and minics __GFP_NOFAIL behavior without any allocation fallback strategy. Here remove the open coded loop and replace it with __GFP_NOFAIL. Signed-off-by: Zhang

[f2fs-dev] [PATCH] fs/f2fs: atomically set inode-i_flags

According to commit 5f16f3225b06 (ext4: atomically set inode-i_flags in ext4_set_inode_flags()). Signed-off-by: Zhang Zhen zhenzhang.zh...@huawei.com --- fs/f2fs/inode.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index

[f2fs-dev] [PATCH] fs/f2fs: replace open coded nofail allocation in __add_ino_entry

__add_ino_entry is looping around the allocation request and minics __GFP_NOFAIL behavior without any allocation fallback strategy. Here remove the open coded loop and replace it with __GFP_NOFAIL. Signed-off-by: Zhang Zhen zhenzhang.zh...@huawei.com --- fs/f2fs/checkpoint.c | 7 +-- 1 file