Re: [f2fs-dev] [PATCH v3] f2fs crypto: allocate buffer for decrypting filename

2015-09-16 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Wednesday, September 16, 2015 12:52 AM > To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: sta...@vger.kernel.org > Subject: Re: [f2fs-dev]

Re: [f2fs-dev] [PATCH 5/7] f2fs: enhance multithread dio write performance

2015-09-16 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Wednesday, September 16, 2015 5:21 AM > To: Chao Yu > Cc: linux-f2fs-devel@lists.sourceforge.net; linux-ker...@vger.kernel.org > Subject: Re: [PATCH 5/7] f2fs: enhance multithread dio write performance

Re: [f2fs-dev] [PATCH 37/39] f2fs crypto: drop null test before destroy functions

2015-09-16 Thread Chao Yu
> -Original Message- > From: Julia Lawall [mailto:julia.law...@lip6.fr] > Sent: Sunday, September 13, 2015 8:16 PM > To: Jaegeuk Kim > Cc: sergey.senozhat...@gmail.com; kernel-janit...@vger.kernel.org; Changman > Lee; Chao Yu; > linux-f2fs-devel@lists.sourceforge.net; linux-ker...@vger.ker

[f2fs-dev] [PATCH 00/39] drop null test before destroy functions

2015-09-16 Thread Julia Lawall
Recent commits to kernel/git/torvalds/linux.git have made the following functions able to tolerate NULL arguments: kmem_cache_destroy (commit 3942d29918522) mempool_destroy (commit 4e3ca3e033d1) dma_pool_destroy (commit 44d7175da6ea) These patches remove the associated NULL tests for the files th

Re: [f2fs-dev] [PATCH 00/39] drop null test before destroy functions

2015-09-16 Thread SF Markus Elfring
> Recent commits to kernel/git/torvalds/linux.git have made the following > functions able to tolerate NULL arguments: > > kmem_cache_destroy (commit 3942d29918522) > mempool_destroy (commit 4e3ca3e033d1) > dma_pool_destroy (commit 44d7175da6ea) How do you think about to extend an other SmPL scrip

Re: [f2fs-dev] [PATCH v4] f2fs crypto: allocate buffer for decrypting filename

2015-09-16 Thread Jaegeuk Kim
Thanks Chao, Change log from v3: o enhance the code with proper error handling Change log from v1: o fix wrong pointer assignment Chang log from v2: o add one more missing call path: f2fs_encrypted_follow_link >From efd4c9bb6519e3c10ec5081a2dcdbaca81d2 Mon Sep 17 00:00:00 2001 From:

Re: [f2fs-dev] [PATCH 2/7] f2fs: do in batches truncation in truncate_hole

2015-09-16 Thread Jaegeuk Kim
Hi Chao, How about changing the original patch slightly like below? o don't have to use index variable o should not skip the entire dnode indices, when one of them is -ENOENT --- fs/f2fs/file.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/fs/f2fs/file.c b/

Re: [f2fs-dev] [PATCH v2] f2fs: optimize code of f2fs_update_extent_tree_range

2015-09-16 Thread Jaegeuk Kim
Hi Fan, It seems that it'd good to write the first patch like this. --- fs/f2fs/extent_cache.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c index 63068b7..9911717 100644 --- a/fs/f2fs/extent_cache.c +++ b/fs/f2fs/ext

Re: [f2fs-dev] [PATCH 5/7] f2fs: enhance multithread dio write performance

2015-09-16 Thread Jaegeuk Kim
Hi Chao, On Wed, Sep 16, 2015 at 06:15:55PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > > Sent: Wednesday, September 16, 2015 5:21 AM > > To: Chao Yu > > Cc: linux-f2fs-devel@lists.sourceforge.net; linux-ker...@vger.kern

[f2fs-dev] [PATCH] f2fs:Fix concurrent access issue in the function recover_dentry

2015-09-16 Thread Nicholas Krause
This fixes a concurrent access in the function recover_dentry by locking the superblock representation in memory with f2fs_lock_op before calling the function __f2fs_add_link and unlocking the superblock afterwards with f2fs_unlock_op in order to avoid concurrent access here as neither recover_dent

Re: [f2fs-dev] [PATCH 5/7] f2fs: enhance multithread dio write performance

2015-09-16 Thread He YunLei
On 2015/9/16 18:15, Chao Yu wrote: > Hi Jaegeuk, > >> -Original Message- >> From: Jaegeuk Kim [mailto:jaeg...@kernel.org] >> Sent: Wednesday, September 16, 2015 5:21 AM >> To: Chao Yu >> Cc: linux-f2fs-devel@lists.sourceforge.net; linux-ker...@vger.kernel.org >> Subject: Re: [PATCH 5/7] f2f

Re: [f2fs-dev] [PATCH v2] f2fs: optimize code of f2fs_update_extent_tree_range

2015-09-16 Thread Fan Li
> -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Wednesday, September 16, 2015 2:37 AM > To: Fan Li > Cc: linux-f2fs-devel@lists.sourceforge.net > Subject: Re: [f2fs-dev] [PATCH v2] f2fs: optimize code of > f2fs_update_extent_tree_range > > Hi Fan, > > On Th