Re: [f2fs-dev] sync/umount hang on 3.18.21, 1.4TB gone after crash

2015-09-26 Thread Jaegeuk Kim
On Sat, Sep 26, 2015 at 05:08:33AM +0200, Marc Lehmann wrote: > On Fri, Sep 25, 2015 at 11:42:02AM -0700, Jaegeuk Kim > wrote: > > AFAIK, there-in *commit* means syncing metadata, not userdata. Doesn't it? > > In general, no, they commit userdata, even if not necessarily at the same > time. ext*

Re: [f2fs-dev] SMR drive test 2; 128GB partition; no obvious corruption, much more sane behaviour, weird overprovisioning

2015-09-26 Thread Jaegeuk Kim
On Sat, Sep 26, 2015 at 05:32:53AM +0200, Marc Lehmann wrote: > On Fri, Sep 25, 2015 at 10:45:46AM -0700, Jaegeuk Kim > wrote: > > > He :) It's a nothing-special number between 64 and 128, that's all. > > > > Oh, then, I don't think that is a good magic number. > > Care to share why? :) Mostly

Re: [f2fs-dev] write performance difference 3.18.21/4.2.1

2015-09-26 Thread Jaegeuk Kim
On Sat, Sep 26, 2015 at 05:22:18AM +0200, Marc Lehmann wrote: > On Fri, Sep 25, 2015 at 05:47:12PM +0800, Chao Yu > wrote: > > Please revert the commit 7c5e466755ff ("f2fs: readahead cp payload > > pages when mount") since in this commit we try to access invalid > > SIT_I(sbi)->sit_base_addr whic

Re: [f2fs-dev] write performance difference 3.18.21/git f2fs

2015-09-26 Thread Jaegeuk Kim
On Sat, Sep 26, 2015 at 07:25:51AM +0200, Marc Lehmann wrote: > Ok, before I tried the f2fs git I made another short test with the > original 3.18.21 f2fs, and it was as fast as before. Then I used the > faulty f2fs module,. which forced a reboot. > > Now I started to redo the 3.18.21 test + git f

[f2fs-dev] [PATCH RESEND #2] f2fs:Fix incorrect return statement in the function f2fs_ioc_release_volatile_write

2015-09-26 Thread Nicholas Krause
This fixes the incorrect return statement at the end of the function f2fs_ioc_release_volatile_write's body for returning zero as this is incorrect due to the function call before this return statement to the function punch_hole being able to fail and we should return this function's return fail di

Re: [f2fs-dev] SMR drive test 2; 128GB partition; no obvious corruption, much more sane behaviour, weird overprovisioning

2015-09-26 Thread Marc Lehmann
On Sat, Sep 26, 2015 at 12:36:55AM -0700, Jaegeuk Kim wrote: > > Care to share why? :) > > Mostly, in the flash storages, it is multiple 2MB normally. :) Well, any value of -s gives me a multiple of 2MB, no? :) > > Is there anysthing specially good for numbers of two? Or do you just want > >

Re: [f2fs-dev] write performance difference 3.18.21/git f2fs

2015-09-26 Thread Marc Lehmann
On Sat, Sep 26, 2015 at 12:52:53AM -0700, Jaegeuk Kim wrote: > > Just for fun I'll start doing a -s64 run. (which had the same result). > Okay, so before finding bad commits, if possible, can you get block traces? If you can teach me how to, sure! In the meantime, maybe what happened is that