Re: [f2fs-dev] [PATCH] fscrypto: make XTS tweak initialization endian-independent

2016-10-06 Thread Dave Chinner
On Wed, Oct 05, 2016 at 11:14:55PM +0200, Richard Weinberger wrote: > Michael, > > On 05.10.2016 20:44, Richard Weinberger wrote: > > Well, let's focus first on file contents. > > We have already the fscrypo framework. > > > > What you suggest is completely different from what we have now. > > T

Re: [f2fs-dev] [PATCH] fscrypto: make XTS tweak initialization endian-independent

2016-10-06 Thread Richard Weinberger
Michael, On 05.10.2016 20:23, Michael Halcrow wrote: >> Eric, >> >>> On 04.10.2016, at 18:38, Eric Biggers wrote: >>> >>> On Tue, Oct 04, 2016 at 10:46:54AM +0200, Richard Weinberger wrote: > Also, currently this code *is* only supposed to be used for XTS. > There's a bug where a speciall

Re: [f2fs-dev] [PATCH] fscrypto: make XTS tweak initialization endian-independent

2016-10-06 Thread Richard Weinberger
Michael, On 05.10.2016 20:44, Richard Weinberger wrote: > Well, let's focus first on file contents. > We have already the fscrypo framework. > > What you suggest is completely different from what we have now. To clarify that, I'm not saying that meta-data or block level authentication is a bad i

Re: [f2fs-dev] [PATCH] fscrypto: make XTS tweak initialization endian-independent

2016-10-06 Thread Theodore Ts'o
On Thu, Oct 06, 2016 at 12:17:15PM +1100, Dave Chinner wrote: > This is the sanest approach, because encrypting filesystem internal > metadata may have some unintended consequences. e.g being unable to > perform forensic analysis of corruption or data loss events, or an > inability for tools like f

Re: [f2fs-dev] [PATCH] fscrypto: make XTS tweak initialization endian-independent

2016-10-06 Thread Richard Weinberger
Michael, On 05.10.2016 23:11, Michael Halcrow wrote: >>> In the meantime, to address the CBC thing, I'd want to understand what >>> the hardware is doing exactly. I wouldn't want the existence of code >>> that supports CBC in fs/crypto to be interpreted as some sort of >>> endorsement for using i

Re: [f2fs-dev] [PATCH] fscrypto: make XTS tweak initialization endian-independent

2016-10-06 Thread Michael Halcrow
> Eric, > > > On 04.10.2016, at 18:38, Eric Biggers wrote: > > > > On Tue, Oct 04, 2016 at 10:46:54AM +0200, Richard Weinberger wrote: > >>> Also, currently this code *is* only supposed to be used for XTS. > >>> There's a bug where a specially crafted filesystem can cause > >>> this code path to

Re: [f2fs-dev] [PATCH] fscrypto: make XTS tweak initialization endian-independent

2016-10-06 Thread Michael Halcrow
On Wed, Oct 05, 2016 at 08:44:09PM +0200, Richard Weinberger wrote: > Michael, > > On 05.10.2016 20:23, Michael Halcrow wrote: > >> Eric, > >> > >>> On 04.10.2016, at 18:38, Eric Biggers wrote: > >>> > >>> On Tue, Oct 04, 2016 at 10:46:54AM +0200, Richard Weinberger wrote: > > Also, currently

[f2fs-dev] [GIT PULL] f2fs update for 4.9

2016-10-06 Thread Jaegeuk Kim
Hi Linus, Could you please consider this pull request? Thanks, The following changes since commit cad9d20784e9b31f0fa8eb82b4ae5dad633b560d: Merge tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost (2016-08-24 07:43:27 -0400) are available in the git repository at: