Re: [f2fs-dev] [PATCH] resize.f2fs: fix an error in migrate_ssa

2016-11-29 Thread Junling Zheng
Ping ... On 2016/11/25 11:53, Junling Zheng wrote: > Sorry, I forget to get the return value of dev_write_block :( > Please review the following patch :) > > --- > fsck/resize.c | 25 ++--- > 1 file changed, 14 insertions(+), 11 deletions(-) > > diff --git a/fsck/resize.c b/

Re: [f2fs-dev] [PATCH] resize.f2fs: fix an error in migrate_ssa

2016-11-29 Thread Jaegeuk Kim
Could you please resubmit a complete patch? On Tue, Nov 29, 2016 at 04:43:10PM +0800, Junling Zheng wrote: > Ping ... > > On 2016/11/25 11:53, Junling Zheng wrote: > > Sorry, I forget to get the return value of dev_write_block :( > > Please review the following patch :) > > > > --- > > fsck/res

Re: [f2fs-dev] [RFD] Common userspace tool for fscypto

2016-11-29 Thread Richard Weinberger
Michael, On 19.10.2016 19:36, Michael Halcrow wrote: >> That said, what about implementing such a tool as part of util-linux to >> control >> fscrypto? We (David and I) would volunteer. > > While discussing several changes we have staged for release (we're > trying to minimize churn by batching

Re: [f2fs-dev] [RFD] Common userspace tool for fscypto

2016-11-29 Thread Richard Weinberger
Joe, On 29.11.2016 22:42, Joe Richey wrote: > Hi Richard, > > I'm Joe Richey, and I work on Mike's team. We've been playing around > with a few design > ideas regarding a tool for managing filesystem encryption. After going > though some iterations > with Ted, we have a fairly good idea about whe

[f2fs-dev] [PATCH v2] resize.f2fs: fix the number of moved ssa blocks in migrate_ssa

2016-11-29 Thread Junling Zheng
If the offset passed in migrate_ssa is not zero, it means that there're offset segments of old main will disappear after migrating, then there're offset blocks of old ssa should be invalidated and removed accordingly. So, the number of moved ssa blocks should be: TOTAL_SEGS(sbi) - offset, and the e