>-Original Message-
>From: Yuchao (T)
>Sent: Wednesday, March 28, 2018 9:28 AM
>To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net
>Cc: Wangbintian
>Subject: Re: [f2fs-dev][PATCH v4] f2fs: introduce a method to make nat journal
>more fresh
>
>On 2018/3/16 18:24, Yun
On 2018/4/9 11:34, Yunlei He wrote:
> Now, nat bits feature is enabled by default, we will
> meet with the following scenarios:
>
> i. disabled, without CP_NAT_BITS_FLAG, if fsck find some
> fs errors, fix or write new checkpoint will then enable it.
> ii. enabled, with CP_NAT_BITS_FLAG, i
On 2018/4/9 11:40, Yunlei He wrote:
> nat bits feature is recover default by fsck, no need to
> set SBI_NEED_FSCK flag.
>
> Signed-off-by: Yunlei He
Reviewed-by: Chao Yu
Thanks,
--
Check out the vibrant tech communit
On 2018/4/9 11:54, Yunlei He wrote:
> This patch stop discard thread to issue discard io if
> something wrong with f2fs, which is similar to fstrim.
>
> v1->v2: add fs error check in not only discard thread but also umount process
>
> Signed-off-by: Yunlei He
> ---
> fs/f2fs/segment.c | 7 +
On 2018/3/16 18:24, Yunlei He wrote:
> This patch introduce a method to make nat journal more fresh:
> i. sort set list using dirty entry number and cp version
> average value.
> ii. if meet with cache hit, update average version valus with
> current cp version.
>
> With this patch, newly
On Mon, Apr 09, 2018 at 12:09:30PM +0900, Minchan Kim wrote:
> On Sun, Apr 08, 2018 at 07:49:25PM -0700, Matthew Wilcox wrote:
> > On Mon, Apr 09, 2018 at 10:58:15AM +0900, Minchan Kim wrote:
> > > It assumes shadow entry of radix tree relies on the init state
> > > that node->private_list allocate
>-Original Message-
>From: Yuchao (T)
>Sent: Monday, April 09, 2018 7:05 PM
>To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net
>Cc: Wangbintian; Zhangdianfang (Euler)
>Subject: Re: [f2fs-dev][PATCH v2] f2fs: stop issue discard if something wrong
>with f2fs
>
>On 20
On Mon, Apr 09, 2018 at 04:14:03AM -0700, Matthew Wilcox wrote:
> On Mon, Apr 09, 2018 at 12:09:30PM +0900, Minchan Kim wrote:
> > On Sun, Apr 08, 2018 at 07:49:25PM -0700, Matthew Wilcox wrote:
> > > On Mon, Apr 09, 2018 at 10:58:15AM +0900, Minchan Kim wrote:
> > > > It assumes shadow entry of ra
This patch stop async thread and umount process to issue discard
if something wrong with f2fs, which is similar to fstrim.
v1->v2: add fs error check in not only discard thread but also umount process
v2->v3: remove redundant error message
Signed-off-by: Yunlei He
---
fs/f2fs/segment.c | 3 +++
This patch use cur_map instead of ckpt_map for easy to
understand, no functional change.
Signed-off-by: Yunlei He
---
fs/f2fs/segment.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 5854cc4..f5d0499 100644
--- a/fs/f2fs/segment.c
On 2018/4/9 19:25, Minchan Kim wrote:
> On Mon, Apr 09, 2018 at 04:14:03AM -0700, Matthew Wilcox wrote:
>> On Mon, Apr 09, 2018 at 12:09:30PM +0900, Minchan Kim wrote:
>>> On Sun, Apr 08, 2018 at 07:49:25PM -0700, Matthew Wilcox wrote:
On Mon, Apr 09, 2018 at 10:58:15AM +0900, Minchan Kim wrot
On Mon 09-04-18 20:25:06, Chao Yu wrote:
[...]
> diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> index c852e800..cc63f8c448f0 100644
> --- a/fs/f2fs/inode.c
> +++ b/fs/f2fs/inode.c
> @@ -339,10 +339,10 @@ struct inode *f2fs_iget(struct super_block *sb,
> unsigned long ino)
> make_now:
>
On Mon, Apr 09, 2018 at 02:48:52PM +0200, Michal Hocko wrote:
> On Mon 09-04-18 20:25:06, Chao Yu wrote:
> [...]
> > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> > index c852e800..cc63f8c448f0 100644
> > --- a/fs/f2fs/inode.c
> > +++ b/fs/f2fs/inode.c
> > @@ -339,10 +339,10 @@ struct inode
On Mon, Apr 09, 2018 at 06:41:14AM -0700, Matthew Wilcox wrote:
> It's worth noting that this is endemic in filesystems.
For the rationale in XFS take a look at commit
ad22c7a043c2cc6792820e6c5da699935933e87d
--
Check ou
On Mon 09-04-18 06:41:14, Matthew Wilcox wrote:
> On Mon, Apr 09, 2018 at 02:48:52PM +0200, Michal Hocko wrote:
> > On Mon 09-04-18 20:25:06, Chao Yu wrote:
> > [...]
> > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> > > index c852e800..cc63f8c448f0 100644
> > > --- a/fs/f2fs/inode.c
> > >
On Mon, Apr 09, 2018 at 08:25:06PM +0800, Chao Yu wrote:
> On 2018/4/9 19:25, Minchan Kim wrote:
> > On Mon, Apr 09, 2018 at 04:14:03AM -0700, Matthew Wilcox wrote:
> >> On Mon, Apr 09, 2018 at 12:09:30PM +0900, Minchan Kim wrote:
> >>> On Sun, Apr 08, 2018 at 07:49:25PM -0700, Matthew Wilcox wrote
On Mon, Apr 09, 2018 at 11:49:58PM +0900, Minchan Kim wrote:
> On Mon, Apr 09, 2018 at 08:25:06PM +0800, Chao Yu wrote:
> > On 2018/4/9 19:25, Minchan Kim wrote:
> > > On Mon, Apr 09, 2018 at 04:14:03AM -0700, Matthew Wilcox wrote:
> > >> On Mon, Apr 09, 2018 at 12:09:30PM +0900, Minchan Kim wrote:
On Mon, Apr 09, 2018 at 03:52:15PM +0200, Michal Hocko wrote:
> On Mon 09-04-18 06:41:14, Matthew Wilcox wrote:
> > On Mon, Apr 09, 2018 at 02:48:52PM +0200, Michal Hocko wrote:
> > > On Mon 09-04-18 20:25:06, Chao Yu wrote:
> > > [...]
> > > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> > > >
On 04/08, Chao Yu wrote:
> On 2018/4/8 10:15, Sheng Yong wrote:
> > This patch introduces a new option -V to show the version of mkfs.f2fs
> > and exit after that.
>
> BTW, should we add -V for other misc tools?
Yes, could you please add this for others?
>
> >
> > Signed-off-by: Sheng Yong
>
On 04/08, Chao Yu wrote:
> On 2018/4/5 11:51, Jaegeuk Kim wrote:
> > On 04/04, Chao Yu wrote:
> >> This patch enlarges block plug coverage in __issue_discard_cmd, in
> >> order to collect more pending bios before issuing them, to avoid
> >> being disturbed by previous discard I/O in IO aware discar
On 04/09, Minchan Kim wrote:
> On Mon, Apr 09, 2018 at 04:14:03AM -0700, Matthew Wilcox wrote:
> > On Mon, Apr 09, 2018 at 12:09:30PM +0900, Minchan Kim wrote:
> > > On Sun, Apr 08, 2018 at 07:49:25PM -0700, Matthew Wilcox wrote:
> > > > On Mon, Apr 09, 2018 at 10:58:15AM +0900, Minchan Kim wrote:
Pass the -f option to mkfs.f2fs when it appears to support it. This is
required by f2fs-tools v1.9 and later in order to format the filesystem
even when an existing filesystem is detected. But earlier versions did
not accept this option.
mkfs.f2fs doesn't yet have an option to print its version
From: Chao Yu
Related to https://lkml.org/lkml/2018/4/8/661
Sometimes, we need to write meta data to new allocated block address,
then we will allocate a zeroed page in inner inode's address space, and
fill partial data in it, and leave other place with zero value which means
some fields are ini
On Fri, Apr 06, 2018 at 09:30:36AM -0400, Theodore Y. Ts'o wrote:
> On Thu, Apr 05, 2018 at 03:21:41PM -0700, Eric Biggers wrote:
> > Pass the -f option to mkfs.f2fs when it appears to support it. This is
> > required by f2fs-tools v1.9 and later in order to format the filesystem
> > even when an
Chao,
I have to test this for a while. Meanwhile, could you take a look at this?
On 04/09, Jaegeuk Kim wrote:
> From: Chao Yu
>
> Related to https://lkml.org/lkml/2018/4/8/661
>
> Sometimes, we need to write meta data to new allocated block address,
> then we will allocate a zeroed page in inn
On Mon, Apr 09, 2018 at 11:38:27AM -0700, Jaegeuk Kim wrote:
> On 04/09, Minchan Kim wrote:
> > On Mon, Apr 09, 2018 at 04:14:03AM -0700, Matthew Wilcox wrote:
> > > On Mon, Apr 09, 2018 at 12:09:30PM +0900, Minchan Kim wrote:
> > > > On Sun, Apr 08, 2018 at 07:49:25PM -0700, Matthew Wilcox wrote:
Change log from v1:
- don't memset for recovered page
Related to https://lkml.org/lkml/2018/4/8/661
Sometimes, we need to write meta data to new allocated block address,
then we will allocate a zeroed page in inner inode's address space, and
fill partial data in it, and leave other place with ze
Hi Matthew,
On 03/29/2018 10:41 PM, Matthew Wilcox wrote:
> From: Matthew Wilcox
>
> I'd like to thank Andrew for taking the first eight XArray patches
> into -next. He's understandably nervous about taking the rest of the
> patches into -next given how few of the remaining patches have review
On Mon, Apr 09, 2018 at 08:20:32AM -0700, Matthew Wilcox wrote:
> On Mon, Apr 09, 2018 at 11:49:58PM +0900, Minchan Kim wrote:
> > On Mon, Apr 09, 2018 at 08:25:06PM +0800, Chao Yu wrote:
> > > On 2018/4/9 19:25, Minchan Kim wrote:
> > > > On Mon, Apr 09, 2018 at 04:14:03AM -0700, Matthew Wilcox wr
On Tue, Apr 10, 2018 at 08:04:09AM +0900, Minchan Kim wrote:
> On Mon, Apr 09, 2018 at 08:20:32AM -0700, Matthew Wilcox wrote:
> > I don't think this is something the radix tree should know about.
>
> Because shadow entry implementation is hidden by radix tree implemetation.
> IOW, radix tree user
On 04/09, Jaegeuk Kim wrote:
> Change log from v1:
> - don't memset for recovered page
>
> Related to https://lkml.org/lkml/2018/4/8/661
>
> Sometimes, we need to write meta data to new allocated block address,
> then we will allocate a zeroed page in inner inode's address space, and
> fill part
On 2018/4/10 1:55, Jaegeuk Kim wrote:
On 04/08, Chao Yu wrote:
On 2018/4/8 10:15, Sheng Yong wrote:
This patch introduces a new option -V to show the version of mkfs.f2fs
and exit after that.
BTW, should we add -V for other misc tools?
Yes, could you please add this for others?
OK. I'll
On 2018/4/10 9:35, Jaegeuk Kim wrote:
> On 04/09, Jaegeuk Kim wrote:
>> Change log from v1:
>> - don't memset for recovered page
>>
>> Related to https://lkml.org/lkml/2018/4/8/661
>>
>> Sometimes, we need to write meta data to new allocated block address,
>> then we will allocate a zeroed page in
On Mon, Apr 09, 2018 at 06:12:11PM -0700, Matthew Wilcox wrote:
> On Tue, Apr 10, 2018 at 08:04:09AM +0900, Minchan Kim wrote:
> > On Mon, Apr 09, 2018 at 08:20:32AM -0700, Matthew Wilcox wrote:
> > > I don't think this is something the radix tree should know about.
> >
> > Because shadow entry im
On 2018/4/10 2:02, Jaegeuk Kim wrote:
> On 04/08, Chao Yu wrote:
>> On 2018/4/5 11:51, Jaegeuk Kim wrote:
>>> On 04/04, Chao Yu wrote:
This patch enlarges block plug coverage in __issue_discard_cmd, in
order to collect more pending bios before issuing them, to avoid
being disturbed b
On 2018/4/9 19:27, Yunlei He wrote:
> This patch stop async thread and umount process to issue discard
> if something wrong with f2fs, which is similar to fstrim.
>
> v1->v2: add fs error check in not only discard thread but also umount process
> v2->v3: remove redundant error message
>
> Signed-
On Tue, Apr 10, 2018 at 11:33:39AM +0900, Minchan Kim wrote:
> On Mon, Apr 09, 2018 at 06:12:11PM -0700, Matthew Wilcox wrote:
> > On Tue, Apr 10, 2018 at 08:04:09AM +0900, Minchan Kim wrote:
> > > On Mon, Apr 09, 2018 at 08:20:32AM -0700, Matthew Wilcox wrote:
> > > > I don't think this is somethi
On Tue, Apr 10, 2018 at 11:33:39AM +0900, Minchan Kim wrote:
> @@ -522,7 +532,7 @@ EXPORT_SYMBOL(radix_tree_preload);
> */
> int radix_tree_maybe_preload(gfp_t gfp_mask)
> {
> - if (gfpflags_allow_blocking(gfp_mask))
> + if (gfpflags_allow_blocking(gfp_mask) && !(gfp_mask & __GFP_ZERO))
On 2018/4/9 19:36, Yunlei He wrote:
> This patch use cur_map instead of ckpt_map for easy to
> understand, no functional change.
Actually, it does change the logic, but I think it can fix a issue..
In flush_sit_entries::add_discard_addrs path, cur_map and ckpt_map are
the same, but in exist_trim_
>-Original Message-
>From: Yuchao (T)
>Sent: Tuesday, April 10, 2018 10:36 AM
>To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net
>Cc: Wangbintian; Zhangdianfang (Euler)
>Subject: Re: [f2fs-dev][PATCH v3] f2fs: stop issue discard if something wrong
>with f2fs
>
>On
On Mon, Apr 09, 2018 at 07:41:52PM -0700, Matthew Wilcox wrote:
> On Tue, Apr 10, 2018 at 11:33:39AM +0900, Minchan Kim wrote:
> > @@ -522,7 +532,7 @@ EXPORT_SYMBOL(radix_tree_preload);
> > */
> > int radix_tree_maybe_preload(gfp_t gfp_mask)
> > {
> > - if (gfpflags_allow_blocking(gfp_mask))
>-Original Message-
>From: Yuchao (T)
>Sent: Tuesday, April 10, 2018 10:45 AM
>To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net
>Cc: Wangbintian; Zhangdianfang (Euler)
>Subject: Re: [f2fs-dev][PATCH] f2fs: use cur_map instead of ckpt_map
>
>On 2018/4/9 19:36, Yunle
In flush_sit_entries::add_discard_addrs path, cur_map and ckpt_map
are the same, but in exist_trim_candidates::add_discard_addrs,
cur_map is updated one, and newer than ckpt_map, so we need to use
cur_map to check whether there are discard candidates.
v1->v2: one problem of check discard candidate
On 2018/4/10 10:46, heyunlei wrote:
>
>
>> -Original Message-
>> From: Yuchao (T)
>> Sent: Tuesday, April 10, 2018 10:36 AM
>> To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net
>> Cc: Wangbintian; Zhangdianfang (Euler)
>> Subject: Re: [f2fs-dev][PATCH v3] f2fs: stop
This patch introduces a new option -V to show the version of f2fs tools
and exit after that.
Signed-off-by: Sheng Yong
---
v2->v1: add -V for all f2fs tools
fsck/main.c | 30 +-
include/f2fs_fs.h | 6 ++
mkfs/f2fs_format_main.c | 6 +-
3 f
The variable `c' is declared twice in f2fs_fs.h. This patch removes
the second declaration.
Signed-off-by: Sheng Yong
---
include/f2fs_fs.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/f2fs_fs.h b/include/f2fs_fs.h
index 2b0be2d..cbfdab5 100644
--- a/include/f2fs_fs.h
+++ b/inclu
Change log from v2:
- consider IO error case when dealing with metapage
- memset by fill_node_footer
Change log from v1:
- don't memset for recovered page
Related to https://lkml.org/lkml/2018/4/8/661
Sometimes, we need to write meta data to new allocated block address,
then we will allocate
On 2018/4/10 3:00, Jaegeuk Kim wrote:
> From: Chao Yu
>
> Related to https://lkml.org/lkml/2018/4/8/661
>
> Sometimes, we need to write meta data to new allocated block address,
> then we will allocate a zeroed page in inner inode's address space, and
> fill partial data in it, and leave other p
On 04/10, Chao Yu wrote:
> On 2018/4/10 3:00, Jaegeuk Kim wrote:
> > From: Chao Yu
> >
> > Related to https://lkml.org/lkml/2018/4/8/661
> >
> > Sometimes, we need to write meta data to new allocated block address,
> > then we will allocate a zeroed page in inner inode's address space, and
> > f
On 04/09, Yunlei He wrote:
> Now, nat bits feature is enabled by default, we will
> meet with the following scenarios:
>
> i. disabled, without CP_NAT_BITS_FLAG, if fsck find some
> fs errors, fix or write new checkpoint will then enable it.
> ii. enabled, with CP_NAT_BITS_FLAG, in the cas
On 04/09, Yunlei He wrote:
> nat bits feature is recover default by fsck, no need to
> set SBI_NEED_FSCK flag.
>
> Signed-off-by: Yunlei He
> ---
> fs/f2fs/f2fs.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 1df7f10..0ffaefc2 100644
> --- a/f
On 04/10, Chao Yu wrote:
> On 2018/4/10 2:02, Jaegeuk Kim wrote:
> > On 04/08, Chao Yu wrote:
> >> On 2018/4/5 11:51, Jaegeuk Kim wrote:
> >>> On 04/04, Chao Yu wrote:
> This patch enlarges block plug coverage in __issue_discard_cmd, in
> order to collect more pending bios before issuing
Yunlei,
Could you please post all the related patches including Chao's diff?
On 03/16, Yunlei He wrote:
> This patch introduce a method to make nat journal more fresh:
> i. sort set list using dirty entry number and cp version
> average value.
> ii. if meet with cache hit, update average ver
This patch stop async thread and umount process to issue discard
if something wrong with f2fs, which is similar to fstrim.
Signed-off-by: Yunlei He
---
fs/f2fs/segment.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 5854cc4..1659985 100644
-
>-Original Message-
>From: Jaegeuk Kim [mailto:jaeg...@kernel.org]
>Sent: Tuesday, April 10, 2018 12:01 PM
>To: heyunlei
>Cc: Yuchao (T); linux-f2fs-devel@lists.sourceforge.net; Wangbintian;
>Zhangdianfang (Euler)
>Subject: Re: [f2fs-dev][PATCH] fsck.f2fs: recover nat bits feature defaul
>-Original Message-
>From: Jaegeuk Kim [mailto:jaeg...@kernel.org]
>Sent: Tuesday, April 10, 2018 12:14 PM
>To: heyunlei
>Cc: Yuchao (T); linux-f2fs-devel@lists.sourceforge.net; Wangbintian
>Subject: Re: [f2fs-dev][PATCH v4] f2fs: introduce a method to make nat journal
>more fresh
>
>Yun
On 2018/4/10 11:29, Jaegeuk Kim wrote:
> Change log from v2:
> - consider IO error case when dealing with metapage
> - memset by fill_node_footer
>
> Change log from v1:
> - don't memset for recovered page
>
> Related to https://lkml.org/lkml/2018/4/8/661
>
> Sometimes, we need to write meta
On 2018/4/10 11:28, Sheng Yong wrote:
> This patch introduces a new option -V to show the version of f2fs tools
> and exit after that.
>
> Signed-off-by: Sheng Yong
Reviewed-by: Chao Yu
Thanks,
--
Check out the vibra
On 2018/4/10 11:28, Sheng Yong wrote:
> The variable `c' is declared twice in f2fs_fs.h. This patch removes
> the second declaration.
>
> Signed-off-by: Sheng Yong
Reviewed-by: Chao Yu
Thanks,
--
Check out the vibran
On 2018/4/10 11:50, Jaegeuk Kim wrote:
> Actually, we don't need to do this, since fill_node_footer(true) will reset
> the
> page.
Yes, confirmed.
Thanks,
--
Check out the vibrant tech community on one of the world's m
On 2018/4/10 10:50, Yunlei He wrote:
> In flush_sit_entries::add_discard_addrs path, cur_map and ckpt_map
> are the same, but in exist_trim_candidates::add_discard_addrs,
> cur_map is updated one, and newer than ckpt_map, so we need to use
> cur_map to check whether there are discard candidates.
>
On 2018/4/10 12:01, Yunlei He wrote:
> This patch stop async thread and umount process to issue discard
> if something wrong with f2fs, which is similar to fstrim.
>
> Signed-off-by: Yunlei He
Reviewed-by: Chao Yu
Thanks,
--
On 04/10, Chao Yu wrote:
> On 2018/4/10 11:29, Jaegeuk Kim wrote:
> > Change log from v2:
> > - consider IO error case when dealing with metapage
> > - memset by fill_node_footer
> >
> > Change log from v1:
> > - don't memset for recovered page
> >
> > Related to https://lkml.org/lkml/2018/4/
63 matches
Mail list logo
