Re: [f2fs-dev] [PATCH 5/5] f2fs: fix to avoid race during access gc_thread pointer

2018-04-20 Thread Chao Yu
On 2018/4/20 11:54, Jaegeuk Kim wrote: > On 04/20, Chao Yu wrote: >> On 2018/4/20 11:19, Jaegeuk Kim wrote: >>> On 04/18, Chao Yu wrote: Thread A Thread BThread C - f2fs_remount - stop_gc_thread - f2fs_sbi_store

Re: [f2fs-dev] [PATCH v2] f2fs: use cur_map instead of ckpt_map

2018-04-20 Thread Chao Yu
On 2018/4/20 11:40, Jaegeuk Kim wrote: > On 04/20, Chao Yu wrote: >> On 2018/4/20 11:26, Jaegeuk Kim wrote: >>> On 04/20, heyunlei wrote: > -Original Message- > From: Yuchao (T) > Sent: Friday, April 13, 2018 9:12 AM > To: Jaegeuk Kim; heyunlei > Cc: linux-f2fs

Re: [f2fs-dev] [PATCH] f2fs: sepearte hot/cold in free nid

2018-04-20 Thread Chao Yu
On 2018/4/20 12:04, Chao Yu wrote: > On 2018/4/20 11:37, Jaegeuk Kim wrote: >> On 04/20, Chao Yu wrote: >>> As most indirect node, dindirect node, and xattr node won't be updated >>> after they are created, but inode node and other direct node will change >>> more frequently, so store their nat ent

[f2fs-dev] [PATCH v11 19/63] page cache: Convert page deletion to XArray

2018-04-20 Thread Goldwyn Rodrigues
On 04/14/2018 09:12 AM, Matthew Wilcox wrote: > From: Matthew Wilcox > > The code is slightly shorter and simpler. > > Signed-off-by: Matthew Wilcox > --- > mm/filemap.c | 30 ++ > 1 file changed, 14 insertions(+), 16 deletions(-) > > diff --git a/mm/filemap.c b/

Re: [f2fs-dev] [PATCH v11 10/63] xarray: Add xa_for_each

2018-04-20 Thread Goldwyn Rodrigues
On 04/14/2018 09:12 AM, Matthew Wilcox wrote: > From: Matthew Wilcox > > This iterator allows the user to efficiently walk a range of the array, > executing the loop body once for each entry in that range that matches > the filter. This commit also includes xa_find() and xa_find_above() > whic

[f2fs-dev] KASAN: use-after-free Read in build_segment_manager

2018-04-20 Thread syzbot
Hello, syzbot hit the following crash on upstream commit 87ef12027b9b1dd0e0b12cf311fbcb19f9d92539 (Wed Apr 18 19:48:17 2018 +) Merge tag 'ceph-for-4.17-rc2' of git://github.com/ceph/ceph-client syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=7d6d31d3bc702f566ce3 C reproduce

[f2fs-dev] KASAN: slab-out-of-bounds Read in build_segment_manager

2018-04-20 Thread syzbot
Hello, syzbot hit the following crash on upstream commit 87ef12027b9b1dd0e0b12cf311fbcb19f9d92539 (Wed Apr 18 19:48:17 2018 +) Merge tag 'ceph-for-4.17-rc2' of git://github.com/ceph/ceph-client syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=0a725420475916460f12 C reproduce

[f2fs-dev] BUG: unable to handle kernel paging request in build_segment_manager

2018-04-20 Thread syzbot
Hello, syzbot hit the following crash on upstream commit 87ef12027b9b1dd0e0b12cf311fbcb19f9d92539 (Wed Apr 18 19:48:17 2018 +) Merge tag 'ceph-for-4.17-rc2' of git://github.com/ceph/ceph-client syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=83699adeb2d13579c31e C reproduce

Re: [f2fs-dev] [PATCH v11 10/63] xarray: Add xa_for_each

2018-04-20 Thread Matthew Wilcox
On Fri, Apr 20, 2018 at 07:00:47AM -0500, Goldwyn Rodrigues wrote: > > +/** > > + * xas_for_each_tag() - Iterate over a range of an XArray > > + * @xas: XArray operation state. > > + * @entry: Entry retrieved from array. > > + * @max: Maximum index to retrieve from array. > > + * @tag: Tag to searc

[f2fs-dev] [PATCH] fsck.f2fs: fix stack overflow when reading out nat block

2018-04-20 Thread Jaegeuk Kim
The size of nat_block is less then 4KB, resulting in stack overflow by dev_read. Signed-off-by: Jaegeuk Kim --- fsck/mount.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/fsck/mount.c b/fsck/mount.c index b374b46..7e936dc 100644 --- a/fsck/mount.c +++ b/fsck/m

[f2fs-dev] [PATCH] Revert "f2fs: introduce f2fs_set_page_dirty_nobuffer"

2018-04-20 Thread Jaegeuk Kim
This patch reverts copied f2fs_set_page_dirty_nobuffer to use generic function for stability. This reverts commit fe76b796fc5194cc3d57265002e3a748566d073f. Signed-off-by: Jaegeuk Kim --- fs/f2fs/checkpoint.c | 2 +- fs/f2fs/data.c | 33 + fs/f2fs/f2fs.h

[f2fs-dev] [PATCH] f2fs: remove duplicated dquot_initialize and fix error handling

2018-04-20 Thread Sheng Yong
This patch removes duplicated dquot_initialize in recover_orphan_inode(), and fix the error handling if dquot_initialize fails. Signed-off-by: Sheng Yong --- fs/f2fs/checkpoint.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c

[f2fs-dev] [PATCH] f2fs: check cap_resource only for data blocks

2018-04-20 Thread Jaegeuk Kim
This patch changes the rule to check cap_resource for data blocks, not inode or node blocks in order to avoid selinux denial. Signed-off-by: Jaegeuk Kim --- fs/f2fs/f2fs.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 9f2bc78a9f