[f2fs-dev] [PATCH 2/6] f2fs: fix to recover inode's i_flags during POR

Testcase to reproduce this bug: 1. mkfs.f2fs /dev/sdd 2. mount -t f2fs /dev/sdd /mnt/f2fs 3. touch /mnt/f2fs/file 4. sync 5. chattr +A /mnt/f2fs/file 6. xfs_io -f /mnt/f2fs/file -c "fsync" 7. godown /mnt/f2fs 8. umount /mnt/f2fs 9. mount -t f2fs /dev/sdd /mnt/f2fs 10. lsattr /mnt/f2fs/file ---

[f2fs-dev] [PATCH 1/6] f2fs: fix to recover inode's project id during POR

Testcase to reproduce this bug: 1. mkfs.f2fs -O extra_attr -O project_quota /dev/sdd 2. mount -t f2fs /dev/sdd /mnt/f2fs 3. touch /mnt/f2fs/file 4. sync 5. chattr -p 1 /mnt/f2fs/file 6. xfs_io -f /mnt/f2fs/file -c "fsync" 7. godown /mnt/f2fs 8. umount /mnt/f2fs 9. mount -t f2fs /dev/sdd /mnt/f2fs 1

[f2fs-dev] [PATCH 4/6] f2fs: fix to recover inode's crtime during POR

Testcase to reproduce this bug: 1. mkfs.f2fs -O extra_attr -O inode_crtime /dev/sdd 2. mount -t f2fs /dev/sdd /mnt/f2fs 3. touch /mnt/f2fs/file 4. xfs_io -f /mnt/f2fs/file -c "fsync" 5. godown /mnt/f2fs 6. umount /mnt/f2fs 7. mount -t f2fs /dev/sdd /mnt/f2fs 8. xfs_io -f /mnt/f2fs/file -c "statx -r

[f2fs-dev] [PATCH 5/6] f2fs: fix to keep project quota consistent

This patch does below changes to keep consistence of project quota data in sudden power-cut case: - update inode.i_projid and project quota atomically under lock_op() in f2fs_ioc_setproject() - recover inode.i_projid and project quota in recover_inode() Signed-off-by: Chao Yu --- fs/f2fs/f2fs.h

[f2fs-dev] [PATCH 6/6] f2fs: mark inode dirty explicitly in recover_inode()

Mark inode dirty explicitly in the end of recover_inode() to make sure that all recoverable fields can be persisted later. Signed-off-by: Chao Yu --- fs/f2fs/recovery.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c index 5e68e31989c8..409be551ba03

[f2fs-dev] [PATCH 3/6] f2fs: fix to recover inode's i_gc_failures during POR

inode.i_gc_failures is used to indicate that skip count of migrating on blocks of inode, we should guarantee it can be recovered in sudden power-off case. Signed-off-by: Chao Yu --- fs/f2fs/recovery.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c i

Re: [f2fs-dev] [PATCH] f2fs: remove default option setting in remount

On 2018/9/22 22:40, cgxu519 wrote: > On 09/20/2018 02:29 PM, Chao Yu wrote: >> On 2018/9/20 7:54, cgxu519 wrote: >>> On 9/19/18 10:02 PM, Chao Yu wrote: On 2018/9/18 21:47, cgxu519 wrote: > On 09/18/2018 09:20 PM, Chao Yu wrote: >> On 2018/9/18 14:23, Chengguang Xu wrote: >>> Curre

Re: [f2fs-dev] [PATCH] f2fs: fix remount problem of option io_bits

On 2018/9/22 22:43, Chengguang Xu wrote: > Currently we show mount option "io_bits=%u" as "io_size=%uKB", > it will cause option parsing problem(unrecognized mount option) > in remount. > > Signed-off-by: Chengguang Xu Reviewed-by: Chao Yu Thanks, ___

[f2fs-dev] [PATCH] generic: add a testcase to test uid/gid recovery

After fsync, filesystem should guarantee inode metadata including uid/gid being persisted, so even after sudden power-cut, durign mount, we should recover uid/gid fields correctly, in order to not loss those meta info. So adding this testcase to check whether generic filesystem can guarantee that.

Re: [f2fs-dev] [PATCH] generic: add a testcase to test uid/gid recovery

Hi Eryu, There are several fields in inode rather than uid/gid didn't recover in f2fs, I'm not sure we need to cover all of them with one generic testcase, or with several testcases. Any suggestion? On 2018/9/25 16:45, Chao Yu wrote: > After fsync, filesystem should guarantee inode metadata inclu

Re: [f2fs-dev] [PATCH 2/2 v2] f2fs: avoid f2fs_bug_on if f2fs_get_meta_page_nofail got EIO

On 09/21, Chao Yu wrote: > On 2018/9/21 5:46, Jaegeuk Kim wrote: > > On 09/20, Chao Yu wrote: > >> On 2018/9/19 1:56, Jaegeuk Kim wrote: > >>> This patch avoids BUG_ON when f2fs_get_meta_page_nofail got EIO during > >>> xfstests/generic/475. > >>> > >>> Signed-off-by: Jaegeuk Kim > >>> --- > >>> C

Re: [f2fs-dev] [PATCH v3] f2fs: submit cached bio to avoid endless PageWriteback

On 09/21, Chao Yu wrote: > On 2018/9/18 10:14, Chao Yu wrote: > > On 2018/9/18 10:02, Jaegeuk Kim wrote: > >> On 09/18, Chao Yu wrote: > >>> On 2018/9/18 9:37, Jaegeuk Kim wrote: > On 09/18, Chao Yu wrote: > > On 2018/9/18 9:04, Jaegeuk Kim wrote: > >> On 09/13, Chao Yu wrote: > >>

Re: [f2fs-dev] [PATCH] f2fs: fix quota info to adjust recovered data

On 09/21, Chao Yu wrote: > On 2018/9/21 5:42, Jaegeuk Kim wrote: > > On 09/20, Chao Yu wrote: > >> On 2018/9/20 6:38, Jaegeuk Kim wrote: > >>> On 09/19, Chao Yu wrote: > On 2018/9/19 0:45, Jaegeuk Kim wrote: > > On 09/18, Chao Yu wrote: > >> On 2018/9/18 10:05, Jaegeuk Kim wrote: > >>>

Re: [f2fs-dev] [PATCH 2/2 v2] f2fs: avoid f2fs_bug_on if f2fs_get_meta_page_nofail got EIO

On 2018/9/26 8:18, Jaegeuk Kim wrote: > On 09/21, Chao Yu wrote: >> On 2018/9/21 5:46, Jaegeuk Kim wrote: >>> On 09/20, Chao Yu wrote: On 2018/9/19 1:56, Jaegeuk Kim wrote: > This patch avoids BUG_ON when f2fs_get_meta_page_nofail got EIO during > xfstests/generic/475. > > Sign

Re: [f2fs-dev] [PATCH v3] f2fs: submit cached bio to avoid endless PageWriteback

On 2018/9/26 8:20, Jaegeuk Kim wrote: > On 09/21, Chao Yu wrote: >> On 2018/9/18 10:14, Chao Yu wrote: >>> On 2018/9/18 10:02, Jaegeuk Kim wrote: On 09/18, Chao Yu wrote: > On 2018/9/18 9:37, Jaegeuk Kim wrote: >> On 09/18, Chao Yu wrote: >>> On 2018/9/18 9:04, Jaegeuk Kim wrote: >

Re: [f2fs-dev] [PATCH] f2fs: fix quota info to adjust recovered data

On 2018/9/26 8:29, Jaegeuk Kim wrote: > On 09/21, Chao Yu wrote: >> On 2018/9/21 5:42, Jaegeuk Kim wrote: >>> On 09/20, Chao Yu wrote: On 2018/9/20 6:38, Jaegeuk Kim wrote: > On 09/19, Chao Yu wrote: >> On 2018/9/19 0:45, Jaegeuk Kim wrote: >>> On 09/18, Chao Yu wrote: On

Re: [f2fs-dev] [PATCH v3] f2fs: submit cached bio to avoid endless PageWriteback

On 09/26, Chao Yu wrote: > On 2018/9/26 8:20, Jaegeuk Kim wrote: > > On 09/21, Chao Yu wrote: > >> On 2018/9/18 10:14, Chao Yu wrote: > >>> On 2018/9/18 10:02, Jaegeuk Kim wrote: > On 09/18, Chao Yu wrote: > > On 2018/9/18 9:37, Jaegeuk Kim wrote: > >> On 09/18, Chao Yu wrote: > >>

Re: [f2fs-dev] [PATCH] f2fs: fix quota info to adjust recovered data

On 09/26, Chao Yu wrote: > On 2018/9/26 8:29, Jaegeuk Kim wrote: > > On 09/21, Chao Yu wrote: > >> On 2018/9/21 5:42, Jaegeuk Kim wrote: > >>> On 09/20, Chao Yu wrote: > On 2018/9/20 6:38, Jaegeuk Kim wrote: > > On 09/19, Chao Yu wrote: > >> On 2018/9/19 0:45, Jaegeuk Kim wrote: >

[f2fs-dev] [PATCH 2/2] f2fs: return correct errno in f2fs_gc

This fixes overriding error number in f2fs_gc. Signed-off-by: Jaegeuk Kim --- fs/f2fs/gc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 77ffa8045a3b..c051dc4ddf1a 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -1241,7 +1241,7 @@ int f2fs_

[f2fs-dev] [PATCH 1/2] f2fs: clear PageError on the read path

When running fault injection test, I hit somewhat wrong behavior in f2fs_gc -> gc_data_segment(): 0. fault injection generated some PageError'ed pages 1. gc_data_segment -> f2fs_get_read_data_page(REQ_RAHEAD) 2. move_data_page -> f2fs_get_lock_data_page() -> f2f_get_read_data_page() -> f2

Re: [f2fs-dev] [PATCH 4/5] f2fs-tools: introduce sb checksum

On 09/21, Junling Zheng wrote: > On 2018/9/21 5:38, Jaegeuk Kim wrote: > > On 09/20, Junling Zheng wrote: > >> Hi, Jaegeuk > >> > >> On 2018/9/20 7:35, Jaegeuk Kim wrote: > >>> On 09/19, Junling Zheng wrote: > This patch introduced crc for superblock. > > Signed-off-by: Junling Zheng

Re: [f2fs-dev] [PATCH v3] f2fs: submit cached bio to avoid endless PageWriteback

On 2018/9/26 9:42, Jaegeuk Kim wrote: > On 09/26, Chao Yu wrote: >> On 2018/9/26 8:20, Jaegeuk Kim wrote: >>> On 09/21, Chao Yu wrote: On 2018/9/18 10:14, Chao Yu wrote: > On 2018/9/18 10:02, Jaegeuk Kim wrote: >> On 09/18, Chao Yu wrote: >>> On 2018/9/18 9:37, Jaegeuk Kim wrote: >

Re: [f2fs-dev] [PATCH] f2fs: fix quota info to adjust recovered data

On 2018/9/26 9:44, Jaegeuk Kim wrote: > On 09/26, Chao Yu wrote: >> On 2018/9/26 8:29, Jaegeuk Kim wrote: >>> On 09/21, Chao Yu wrote: On 2018/9/21 5:42, Jaegeuk Kim wrote: > On 09/20, Chao Yu wrote: >> On 2018/9/20 6:38, Jaegeuk Kim wrote: >>> On 09/19, Chao Yu wrote: On

Re: [f2fs-dev] [PATCH] f2fs: fix quota info to adjust recovered data

On 09/26, Chao Yu wrote: > On 2018/9/26 9:44, Jaegeuk Kim wrote: > > On 09/26, Chao Yu wrote: > >> On 2018/9/26 8:29, Jaegeuk Kim wrote: > >>> On 09/21, Chao Yu wrote: > On 2018/9/21 5:42, Jaegeuk Kim wrote: > > On 09/20, Chao Yu wrote: > >> On 2018/9/20 6:38, Jaegeuk Kim wrote: >

Re: [f2fs-dev] [PATCH] f2fs: fix quota info to adjust recovered data

On 2018/9/26 10:09, Jaegeuk Kim wrote: > On 09/26, Chao Yu wrote: >> On 2018/9/26 9:44, Jaegeuk Kim wrote: >>> On 09/26, Chao Yu wrote: On 2018/9/26 8:29, Jaegeuk Kim wrote: > On 09/21, Chao Yu wrote: >> On 2018/9/21 5:42, Jaegeuk Kim wrote: >>> On 09/20, Chao Yu wrote: On

Re: [f2fs-dev] [PATCH v3] f2fs: submit cached bio to avoid endless PageWriteback

On 09/26, Chao Yu wrote: > On 2018/9/26 9:42, Jaegeuk Kim wrote: > > On 09/26, Chao Yu wrote: > >> On 2018/9/26 8:20, Jaegeuk Kim wrote: > >>> On 09/21, Chao Yu wrote: > On 2018/9/18 10:14, Chao Yu wrote: > > On 2018/9/18 10:02, Jaegeuk Kim wrote: > >> On 09/18, Chao Yu wrote: > >>

Re: [f2fs-dev] [PATCH 4/5] f2fs-tools: introduce sb checksum

Hi, Jaegeuk On 2018/9/26 9:57, Jaegeuk Kim wrote: > On 09/21, Junling Zheng wrote: >> On 2018/9/21 5:38, Jaegeuk Kim wrote: >>> On 09/20, Junling Zheng wrote: Hi, Jaegeuk On 2018/9/20 7:35, Jaegeuk Kim wrote: > On 09/19, Junling Zheng wrote: >> This patch introduced crc for

Re: [f2fs-dev] [PATCH v3] f2fs: submit cached bio to avoid endless PageWriteback

On 2018/9/26 11:32, Jaegeuk Kim wrote: > On 09/26, Chao Yu wrote: >> On 2018/9/26 9:42, Jaegeuk Kim wrote: >>> On 09/26, Chao Yu wrote: On 2018/9/26 8:20, Jaegeuk Kim wrote: > On 09/21, Chao Yu wrote: >> On 2018/9/18 10:14, Chao Yu wrote: >>> On 2018/9/18 10:02, Jaegeuk Kim wrote:

Re: [f2fs-dev] [PATCH] f2fs: update i_size after DIO completion

On 2018/9/21 5:51, Jaegeuk Kim wrote: > This is related to > ee70daaba82d ("xfs: update i_size after unwritten conversion in dio > completion") > > If we update i_size during dio_write, dio_read can read out stale data, which > breaks xfstests/465. > > Signed-off-by: Jaegeuk Kim Reviewed-by: C