Re: [f2fs-dev] WARNING: ODEBUG bug in f2fs_fill_super

2019-02-21 Thread Dmitry Vyukov via Linux-f2fs-devel
On Thu, Feb 21, 2019 at 3:46 AM Sheng Yong wrote: > > Hi, Dmitry, > > On 2019/2/20 23:12, Dmitry Vyukov wrote: > > On Mon, Aug 27, 2018 at 11:04 PM syzbot > > wrote: > >> > >> Hello, > >> > >> syzbot found the following crash on: > >> > >> HEAD commit:e27bc174c9c6 Add linux-next specific file

Re: [f2fs-dev] [RFC PATCH v3 07/18] fscrypt: add FS_IOC_ADD_ENCRYPTION_KEY ioctl

2019-02-21 Thread Richard Weinberger
Eric, Am Donnerstag, 21. Februar 2019, 06:49:39 CET schrieb Eric Biggers: > Hi Richard, > > On Thu, Feb 21, 2019 at 12:52:38AM +0100, Richard Weinberger wrote: > > On Wed, Feb 20, 2019 at 7:55 AM Eric Biggers wrote: > > > +#define FSCRYPT_FS_KEYRING_DESCRIPTION_SIZE\ > > > + (CONST_STR

[f2fs-dev] [PATCH] f2fs: fix encrypted page memory leak

2019-02-21 Thread Chao Yu
For IPU path of f2fs_do_write_data_page(), in its error path, we need to release encrypted page and fscrypt context, otherwise it will cause memory leak. Signed-off-by: Chao Yu --- fs/f2fs/data.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2f

[f2fs-dev] [PATCH] f2fs: fix to update iostat correctly in IPU path

2019-02-21 Thread Chao Yu
In error path of IPU, we didn't account iostat correctly, fix it. Signed-off-by: Chao Yu --- fs/f2fs/segment.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 3602acee4985..86a6fcbe8484 100644 --- a/fs/f2fs/segment.c +++ b/fs/

Re: [f2fs-dev] [RFC PATCH 00/10] Consolidate Post read processing code

2019-02-21 Thread Chandan Rajendra
On Wednesday, February 20, 2019 2:47:16 AM IST Eric Biggers wrote: > Hi Chandan, > > On Mon, Feb 18, 2019 at 03:34:23PM +0530, Chandan Rajendra wrote: > > This patchset moves the "post read processing" code into a file of its > > own and gets the generic do_mpage_readpge() to make use of the > > f

Re: [f2fs-dev] [RFC PATCH 08/10] fsverity: Add call back to verify file holes

2019-02-21 Thread Chandan Rajendra
On Wednesday, February 20, 2019 6:05:07 AM IST Eric Biggers wrote: > On Mon, Feb 18, 2019 at 03:34:31PM +0530, Chandan Rajendra wrote: > > readpage() implmentations zero out part of the page-cache page mapping a > > file hole. This commit adds a call back to "struct fsverity_operations" > > which r

Re: [f2fs-dev] [RFC PATCH 06/10] Introduce REQ_POST_READ_PROC bio flag

2019-02-21 Thread Chandan Rajendra
On Wednesday, February 20, 2019 5:51:00 AM IST Eric Biggers wrote: > Hi Chandan, > > On Mon, Feb 18, 2019 at 03:34:29PM +0530, Chandan Rajendra wrote: > > Ext4 and F2FS currently use a non-NULL value stored at bio->bi_private > > to determine if the contents of the bio need to be "post processed"

Re: [f2fs-dev] [RFC PATCH 05/10] fsverity: Add call back to decide if verity check has to be performed

2019-02-21 Thread Chandan Rajendra
On Wednesday, February 20, 2019 4:56:49 AM IST Eric Biggers wrote: > Hi Chandan, > > On Mon, Feb 18, 2019 at 03:34:28PM +0530, Chandan Rajendra wrote: > > Ext4 and F2FS store verity metadata in data extents (beyond > > inode->i_size) associated with a file. But other filesystems might > > choose a

Re: [f2fs-dev] [RFC PATCH 04/10] Consolidate "post read processing" into a new file

2019-02-21 Thread Chandan Rajendra
On Wednesday, February 20, 2019 4:52:44 AM IST Eric Biggers wrote: > Hi Chandan, > > On Mon, Feb 18, 2019 at 03:34:27PM +0530, Chandan Rajendra wrote: > > The post read processing code is used by both Ext4 and F2FS. Hence to > > remove duplicity, this commit moves the code into > > include/linux/p

Re: [f2fs-dev] [RFC PATCH 00/10] Consolidate Post read processing code

2019-02-21 Thread Chandan Rajendra
On Wednesday, February 20, 2019 6:11:07 AM IST Eric Biggers wrote: > On Mon, Feb 18, 2019 at 03:34:23PM +0530, Chandan Rajendra wrote: > > Based on the reviews provided for this patchset, I > > will change F2FS to use mpage_readpage[s] and post the next version of > > this patchset to linux-fsdevel

Re: [f2fs-dev] [RFC PATCH 00/10] Consolidate Post read processing code

2019-02-21 Thread Eric Biggers
On Thu, Feb 21, 2019 at 07:02:03PM +0530, Chandan Rajendra wrote: > On Wednesday, February 20, 2019 6:11:07 AM IST Eric Biggers wrote: > > On Mon, Feb 18, 2019 at 03:34:23PM +0530, Chandan Rajendra wrote: > > > Based on the reviews provided for this patchset, I > > > will change F2FS to use mpage_r

Re: [f2fs-dev] [RFC PATCH v3 07/18] fscrypt: add FS_IOC_ADD_ENCRYPTION_KEY ioctl

2019-02-21 Thread Eric Biggers
On Thu, Feb 21, 2019 at 10:33:12AM +0100, Richard Weinberger wrote: > Eric, > > Am Donnerstag, 21. Februar 2019, 06:49:39 CET schrieb Eric Biggers: > > Hi Richard, > > > > On Thu, Feb 21, 2019 at 12:52:38AM +0100, Richard Weinberger wrote: > > > On Wed, Feb 20, 2019 at 7:55 AM Eric Biggers wrote

Re: [f2fs-dev] [PATCH] f2fs: don't clear CP_QUOTA_NEED_FSCK_FLAG

2019-02-21 Thread Jaegeuk Kim
On 02/20, Chao Yu wrote: > On 2019/2/20 15:25, Chao Yu wrote: > > On 2019/2/20 15:08, Jaegeuk Kim wrote: > >> On 02/18, Chao Yu wrote: > >>> On 2019/2/16 12:55, Jaegeuk Kim wrote: > On 02/13, Chao Yu wrote: > > On 2019/2/12 10:33, Jaegeuk Kim wrote: > >> If we met this once, let fsck.f

Re: [f2fs-dev] [PATCH] f2fs: don't clear CP_QUOTA_NEED_FSCK_FLAG

2019-02-21 Thread Chao Yu
On 2019/2/22 10:40, Jaegeuk Kim wrote: > On 02/20, Chao Yu wrote: >> On 2019/2/20 15:25, Chao Yu wrote: >>> On 2019/2/20 15:08, Jaegeuk Kim wrote: On 02/18, Chao Yu wrote: > On 2019/2/16 12:55, Jaegeuk Kim wrote: >> On 02/13, Chao Yu wrote: >>> On 2019/2/12 10:33, Jaegeuk Kim wrote

Re: [f2fs-dev] [RFC PATCH 00/10] Consolidate Post read processing code

2019-02-21 Thread Chandan Rajendra
On Friday, February 22, 2019 12:08:28 AM IST Eric Biggers wrote: > On Thu, Feb 21, 2019 at 07:02:03PM +0530, Chandan Rajendra wrote: > > On Wednesday, February 20, 2019 6:11:07 AM IST Eric Biggers wrote: > > > On Mon, Feb 18, 2019 at 03:34:23PM +0530, Chandan Rajendra wrote: > > > > Based on the re