Re: [PATCH] f2fs: allocate memory in batch in build_sit_info()

2019-07-08 Thread Jaegeuk Kim
On 07/04, Chao Yu wrote: > build_sit_info() allocate all bitmaps for each segment one by one, > it's quite low efficiency, this pach changes to allocate large > continuous memory at a time, and divide it and assign for each bitmaps It may give more failure rate? > of segment. For large size

Re: [PATCH] f2fs: improve print log in f2fs_sanity_check_ckpt()

2019-07-08 Thread Jaegeuk Kim
On 07/08, Chao Yu wrote: > As Park Ju Hyung suggested: > > "I'd like to suggest to write down an actual version of f2fs-tools > here as we've seen older versions of fsck doing even more damage > and the users might not have the latest f2fs-tools installed." > > This patch give a more detailed

Re: [PATCH] f2fs: improve print log in f2fs_sanity_check_ckpt()

2019-07-08 Thread Chao Yu
On 2019-7-9 7:47, Jaegeuk Kim wrote: > On 07/08, Chao Yu wrote: >> As Park Ju Hyung suggested: >> >> "I'd like to suggest to write down an actual version of f2fs-tools >> here as we've seen older versions of fsck doing even more damage >> and the users might not have the latest f2fs-tools

Re: [f2fs-dev] [PATCH] fsck: Fix data loss issue observed during SPO

2019-07-08 Thread Jaegeuk Kim
On 07/07, Chao Yu wrote: > On 2019-7-6 12:50, Jaegeuk Kim wrote: > > On 07/06, Chao Yu wrote: > >> On 2019-7-6 10:10, Chao Yu wrote: > >>> Hi Sahitya, > >>> > >>> On 2019-7-6 9:37, Sahitya Tummala wrote: > Hi Chao, > > I just realized that there is a patch from you to fix this

Re: [PATCH] f2fs: allocate memory in batch in build_sit_info()

2019-07-08 Thread Chao Yu
On 2019-7-9 7:46, Jaegeuk Kim wrote: > On 07/04, Chao Yu wrote: >> build_sit_info() allocate all bitmaps for each segment one by one, >> it's quite low efficiency, this pach changes to allocate large >> continuous memory at a time, and divide it and assign for each bitmaps > > It may give more

Re: [PATCH v4] f2fs: avoid out-of-range memory access

2019-07-08 Thread Chao Yu
On 2019/7/8 12:34, Ocean Chen wrote: > blkoff_off might over 512 due to fs corrupt or security > vulnerability. That should be checked before being using. > > Use ENTRIES_IN_SUM to protect invalid value in cur_data_blkoff. > > Signed-off-by: Ocean Chen Reviewed-by: Chao Yu Thanks,

[f2fs-dev] [Bug 204043] F2fs kernel BUG at fs/f2fs/data.c:317!

2019-07-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204043 --- Comment #2 from midwinter1...@gmail.com --- (In reply to Chao Yu from comment #1) > Could you help to add below diff to check debug info? > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index bc5cea27b512..333285cb14c5 100644 > ---

[f2fs-dev] [PATCH] f2fs: improve print log in f2fs_sanity_check_ckpt()

2019-07-08 Thread Chao Yu
As Park Ju Hyung suggested: "I'd like to suggest to write down an actual version of f2fs-tools here as we've seen older versions of fsck doing even more damage and the users might not have the latest f2fs-tools installed." This patch give a more detailed info of how we fix such corruption to

[f2fs-dev] [Bug 203223] hangs on running program after mounting a crafted image

2019-07-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203223 Jungyeon (jungy...@gatech.edu) changed: What|Removed |Added Status|NEW |RESOLVED

[f2fs-dev] [Bug 203233] kernel BUG at fs/f2fs/segment.c:2102!

2019-07-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203233 Jungyeon (jungy...@gatech.edu) changed: What|Removed |Added Status|ASSIGNED|RESOLVED

[f2fs-dev] [Bug 203345] page fault and hang on mounting crafted image and running program

2019-07-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203345 Jungyeon (jungy...@gatech.edu) changed: What|Removed |Added Status|NEW |RESOLVED

[f2fs-dev] [Bug 203163] RIP: 0010:update_sit_entry+0x50/0x420 when mounting crafted image

2019-07-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203163 Jungyeon (jungy...@gatech.edu) changed: What|Removed |Added Status|NEW |RESOLVED

[f2fs-dev] [Bug 203165] Kernel panic - not syncing: corrupted stack end detected inside scheduler

2019-07-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203165 Jungyeon (jungy...@gatech.edu) changed: What|Removed |Added Status|NEW |RESOLVED

[f2fs-dev] [Bug 203343] page fault and hang on umounting

2019-07-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203343 Jungyeon (jungy...@gatech.edu) changed: What|Removed |Added Status|ASSIGNED|RESOLVED

[f2fs-dev] [Bug 203235] kernel BUG at fs/f2fs/segment.c:2131! and hangs on sync

2019-07-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203235 Jungyeon (jungy...@gatech.edu) changed: What|Removed |Added Status|NEW |RESOLVED

[f2fs-dev] [Bug 203231] kernel BUG at fs/f2fs/segment.c:2079! and hangs on sync

2019-07-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203231 Jungyeon (jungy...@gatech.edu) changed: What|Removed |Added Status|NEW |RESOLVED

[f2fs-dev] [Bug 203215] failure at fs/f2fs/f2fs.h:2809/verify_blkaddr()!

2019-07-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203215 Jungyeon (jungy...@gatech.edu) changed: What|Removed |Added Status|ASSIGNED|RESOLVED

[f2fs-dev] [Bug 203171] PF error: at __remove_dirty_segment+0x61/0xd0

2019-07-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203171 Jungyeon (jungy...@gatech.edu) changed: What|Removed |Added Status|NEW |RESOLVED

[f2fs-dev] [Bug 203341] Kernel read fault when mounting a crafted image and running program

2019-07-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203341 Jungyeon (jungy...@gatech.edu) changed: What|Removed |Added Status|NEW |RESOLVED

[f2fs-dev] [Bug 203167] Kernel page fault with update_sit_entry+0x113/0x420

2019-07-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203167 Jungyeon (jungy...@gatech.edu) changed: What|Removed |Added Status|ASSIGNED|RESOLVED

[f2fs-dev] [Bug 203241] kernel BUG at fs/f2fs/segment.c:3222! and hangs on sync

2019-07-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203241 Jungyeon (jungy...@gatech.edu) changed: What|Removed |Added Status|NEW |RESOLVED