[f2fs-dev] [Bug 206551] New: Failed to initialize F2FS segment manager (-117)

2020-02-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206551 Bug ID: 206551 Summary: Failed to initialize F2FS segment manager (-117) Product: File System Version: 2.5 Kernel Version: 5.5.3-gentoo Hardware: x86-64 OS: Linux

[f2fs-dev] [Bug 206551] Failed to initialize F2FS segment manager (-117)

2020-02-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206551 --- Comment #1 from Stefan de Konink (ste...@konink.de) --- Created attachment 287425 --> https://bugzilla.kernel.org/attachment.cgi?id=287425&action=edit fsck.f2fs result specifically showing SIT bitmap is 0x0. -- You are receiving this mail

Re: [f2fs-dev] [PATCH 3/4] f2fs: clean up lfs/adaptive mount option

2020-02-16 Thread Chao Yu
On 2020/2/15 2:41, Jaegeuk Kim wrote: >> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h >> index 5152e9bf432b..d2d50827772c 100644 >> --- a/fs/f2fs/f2fs.h >> +++ b/fs/f2fs/f2fs.h >> @@ -91,8 +91,6 @@ extern const char *f2fs_fault_name[FAULT_MAX]; >> #define F2FS_MOUNT_FORCE_FG_GC 0x

Re: [f2fs-dev] [PATCH 1/3] f2fs: skip GC when section is full

2020-02-16 Thread Chao Yu
On 2020/2/15 2:58, Jaegeuk Kim wrote: > This fixes skipping GC when segment is full in large section. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/gc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index 53312d7bc78b..65c0687ee2bb 1

Re: [f2fs-dev] [PATCH 2/3] f2fs: add migration count iff migration happens

2020-02-16 Thread Chao Yu
On 2020/2/15 2:58, Jaegeuk Kim wrote: > If first segment is empty and migration_granularity is 1, we can't move this > at all. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sour

Re: [f2fs-dev] [PATCH 2/3] f2fs: add migration count iff migration happens

2020-02-16 Thread Chao Yu
BTW f2fs: add migration count iff migration happens typo: iff On 2020/2/15 2:58, Jaegeuk Kim wrote: > If first segment is empty and migration_granularity is 1, we can't move this > at all. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/gc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [f2fs-dev] [PATCH 3/3] f2fs: skip migration only when BG_GC is called

2020-02-16 Thread Chao Yu
On 2020/2/15 2:58, Jaegeuk Kim wrote: > FG_GC needs to move entire section more quickly. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/gc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index bbf4db3f6bb4..1676eebc8c8b 100644 > --- a/fs/

[f2fs-dev] [PATCH V2] f2fs: fix the panic in do_checkpoint()

2020-02-16 Thread Sahitya Tummala
There could be a scenario where f2fs_sync_meta_pages() will not ensure that all F2FS_DIRTY_META pages are submitted for IO. Thus, resulting in the below panic in do_checkpoint() - f2fs_bug_on(sbi, get_pages(sbi, F2FS_DIRTY_META) && !f2fs_cp_error(sbi)); This can ha

Re: [f2fs-dev] F2fs panic | update_sit_entry() | no free segment | se invalid

2020-02-16 Thread Chao Yu
Hi 王矛, On 2020/2/16 19:39, 王矛 wrote: > *So the problem is:* > > 1. in new_curseg(), if the segno allocated is invalid(no free segment, max > segno > is returned). > > F2fs should do something to indicate this exception. > > 2. otherwise, we may hit the f2fs panic(se invalid). > > Maybe we sho

Re: [f2fs-dev] [PATCH] f2fs: fix inconsistent comments

2020-02-16 Thread Chao Yu
Hi Jaegeuk, I can still see many inconsistent comments in f2fs code, would you consider to merge this patch to fix them? Thanks, On 2019/9/27 18:23, Chao Yu wrote: > Lack of maintenance on comments may mislead developers, fix them. > > Signed-off-by: Chao Yu > --- > fs/f2fs/checkpoint.c | 18

Re: [f2fs-dev] [PATCH V2] f2fs: fix the panic in do_checkpoint()

2020-02-16 Thread Chao Yu
On 2020/2/17 11:43, Sahitya Tummala wrote: > There could be a scenario where f2fs_sync_meta_pages() will not > ensure that all F2FS_DIRTY_META pages are submitted for IO. Thus, > resulting in the below panic in do_checkpoint() - > > f2fs_bug_on(sbi, get_pages(sbi, F2FS_DIRTY_META) && >

Re: [f2fs-dev] F2fs panic | update_sit_entry() | no free segment | se invalid

2020-02-16 Thread Chao Yu
On 2020/2/17 13:08, 王矛 wrote: > > Hi Chao, > > Thanks for your prompt reply. > 1. Is it possible that when the issue occurred, there is indeed all free > segment > used up? No, f2fs reserved some sections for foreground GC, no one should use up those reserved sections, though foreground GC may

[f2fs-dev] [Bug 206551] Failed to initialize F2FS segment manager (-117)

2020-02-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206551 Chao Yu (c...@kernel.org) changed: What|Removed |Added Status|NEW |ASSIGNED CC|