Re: [f2fs-dev] [PATCH v8 10/11] f2fs: add inline encryption support

2020-03-15 Thread Eric Biggers
On Thu, Mar 12, 2020 at 01:02:52AM -0700, Satya Tangirala wrote: > diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h > index 5355be6b6755..75817f0dc6f8 100644 > --- a/fs/f2fs/f2fs.h > +++ b/fs/f2fs/f2fs.h > @@ -139,6 +139,9 @@ struct f2fs_mount_info { > int alloc_mode; /* segment a

Re: [f2fs-dev] [PATCH v8 09/11] fscrypt: add inline encryption support

2020-03-15 Thread Eric Biggers
On Thu, Mar 12, 2020 at 01:02:51AM -0700, Satya Tangirala wrote: > +int fscrypt_prepare_inline_crypt_key(struct fscrypt_prepared_key *prep_key, > + const u8 *raw_key, > + const struct fscrypt_info *ci) > +{ > + const struct inode

Re: [f2fs-dev] [PATCH v8 06/11] scsi: ufs: UFS crypto API

2020-03-15 Thread Eric Biggers
On Thu, Mar 12, 2020 at 01:02:48AM -0700, Satya Tangirala wrote: > Introduce functions to manipulate UFS inline encryption hardware > in line with the JEDEC UFSHCI v2.1 specification and to work with the > block keyslot manager. > > The UFS crypto API will assume by default that a vendor driver do

Re: [f2fs-dev] [PATCH v8 07/11] scsi: ufs: Add inline encryption support to UFS

2020-03-15 Thread Eric Biggers
On Thu, Mar 12, 2020 at 01:02:49AM -0700, Satya Tangirala wrote: > Wire up ufshcd.c with the UFS Crypto API, the block layer inline > encryption additions and the keyslot manager. > > Signed-off-by: Satya Tangirala > --- > drivers/scsi/ufs/ufshcd-crypto.c | 27 +++ > drivers/scsi/ufs

Re: [f2fs-dev] [PATCH v8 07/11] scsi: ufs: Add inline encryption support to UFS

2020-03-15 Thread Eric Biggers
On Thu, Mar 12, 2020 at 01:02:49AM -0700, Satya Tangirala wrote: > @@ -2470,6 +2504,9 @@ static int ufshcd_compose_dev_cmd(struct ufs_hba *hba, > lrbp->task_tag = tag; > lrbp->lun = 0; /* device management cmd is not specific to any LUN */ > lrbp->intr_cmd = true; /* No interrupt

Re: [f2fs-dev] [PATCH v8 08/11] fs: introduce SB_INLINECRYPT

2020-03-15 Thread Eric Biggers
On Thu, Mar 12, 2020 at 01:02:50AM -0700, Satya Tangirala wrote: > Introduce SB_INLINECRYPT, which is set by filesystems that wish to use > blk-crypto for file content en/decryption. > > Signed-off-by: Satya Tangirala > --- > fs/proc_namespace.c | 1 + > include/linux/fs.h | 1 + > 2 files chan

Re: [f2fs-dev] [PATCH v8 01/11] block: Keyslot Manager for Inline Encryption

2020-03-15 Thread Eric Biggers
On Thu, Mar 12, 2020 at 01:02:43AM -0700, Satya Tangirala wrote: > +/** > + * blk_ksm_init() - Initialize a keyslot manager > + * @ksm: The keyslot_manager to initialize. > + * @dev: Device for runtime power management (NULL if none) > + * @num_slots: The number of key slots to manage. > + * > + *

Re: [f2fs-dev] [PATCH v8 03/11] block: Make blk-integrity preclude hardware inline encryption

2020-03-15 Thread Eric Biggers
On Thu, Mar 12, 2020 at 01:02:45AM -0700, Satya Tangirala wrote: > diff --git a/block/blk-integrity.c b/block/blk-integrity.c > index ff1070edbb40..793ba23e8688 100644 > --- a/block/blk-integrity.c > +++ b/block/blk-integrity.c > @@ -409,6 +409,13 @@ void blk_integrity_register(struct gendisk *disk

Re: [f2fs-dev] [PATCH] f2fs: fix long latency due to discard during umount

2020-03-15 Thread Chao Yu
On 2020/3/13 19:08, Sahitya Tummala wrote: > On Fri, Mar 13, 2020 at 02:30:55PM +0800, Chao Yu wrote: >> On 2020/3/13 11:39, Sahitya Tummala wrote: >>> On Fri, Mar 13, 2020 at 10:20:04AM +0800, Chao Yu wrote: On 2020/3/12 19:14, Sahitya Tummala wrote: > F2FS already has a default timeout o

Re: [f2fs-dev] fstrim does not recognize FSVER=1.13 of F2FS partitions

2020-03-15 Thread Chao Yu
Hello, On 2020/3/15 2:09, John wrote: > Running `fstrim -a -v` is not detecting my f2fs partition that I > created just a few days ago but it does detect an older f2fs partition > and trims it as expected. Both partitions are on the same SSD. The > older partition is FSVER=1.12 whereas the newer

Re: [f2fs-dev] [PATCH] Include private/fs_config.h directly when needed

2020-03-15 Thread Chao Yu
On 2020/3/6 11:37, Jaegeuk Kim wrote: > From: Tom Cherry > > This is no longer a transitive include of android_filesystem_config.h > > Signed-off-by: Tom Cherry > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel maili

[f2fs-dev] [PATCH] dump.f2fs: fix to print all blkaddr in .i_addr

2020-03-15 Thread Chao Yu
There are totally ADDRS_PER_INODE() blkaddrs in .i_addr, fix to print all of them. In addition, use get_extra_isize() rather than __get_extra_isize() Signed-off-by: Chao Yu --- fsck/mount.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fsck/mount.c b/fsck/mount.c i

Re: [f2fs-dev] [PATCH V2] fsck.f2fs: allow fsck to fix issues with online resize due to SPO

2020-03-15 Thread Chao Yu
On 2020/3/6 11:52, Sahitya Tummala wrote: > Add support for new CP flag CP_RESIZEFS_FLAG set during online > resize FS. If SPO happens after SB is updated but CP isn't, then > allow fsck to fix it. > > fsck errors without this fix - > Info: CKPT version = 6ed7bccb > Wrong user_bloc

Re: [f2fs-dev] [PATCH] f2fs: fix long latency due to discard during umount

2020-03-15 Thread Sahitya Tummala
Hi Chao, On Mon, Mar 16, 2020 at 08:52:25AM +0800, Chao Yu wrote: > On 2020/3/13 19:08, Sahitya Tummala wrote: > > On Fri, Mar 13, 2020 at 02:30:55PM +0800, Chao Yu wrote: > >> On 2020/3/13 11:39, Sahitya Tummala wrote: > >>> On Fri, Mar 13, 2020 at 10:20:04AM +0800, Chao Yu wrote: > On 2020/

Re: [f2fs-dev] [PATCH] fsck.f2fs: report real wall time

2020-03-15 Thread Chao Yu
On 2020/3/10 5:19, Jaegeuk Kim wrote: > From: Wei Wang > > clock_t time is per-process time, which is not wall time. For example, > if the CPU is shared by other processes, clock_t time may advance slower > than wall clock. On the other hand, if the current process is > multithreaded and more tha