Re: [f2fs-dev] possible circular locking dependency detected

2020-06-28 Thread Chao Yu
Hi, Could you please check that whether below commit has been merged? dd973007bfef ("f2fs: set GFP_NOFS when moving inline dentries") On 2020/6/26 21:56, Ilya Averyanov wrote: > I can reproduce this WARNING if I run rsync -rtS -@2 --no-compress > --no-i-r --info=progress > 2 /mnt/f2fs/ /mnt/sd/

[f2fs-dev] [PATCH v4] f2fs: add f2fs_gc exception handle in f2fs_ioc_gc_range

2020-06-28 Thread Qilong Zhang
When f2fs_ioc_gc_range performs multiple segments gc ops, the return value of f2fs_ioc_gc_range is determined by the last segment gc ops. If its ops failed, the f2fs_ioc_gc_range will be considered to be failed despite some of previous segments gc ops succeeded. Therefore, so we fix: Redefine the

[f2fs-dev] [PATCH 3/3] f2fs: support to trace f2fs_fiemap()

2020-06-28 Thread Chao Yu
to show f2fs_fiemap()'s result as below: f2fs_fiemap: dev = (251,0), ino = 7, lblock:0, pblock:1625292800, len:2097152, flags:0, ret:0 Signed-off-by: Chao Yu --- fs/f2fs/data.c | 6 +- fs/f2fs/inline.c| 2 ++ include/trace/events/f2fs.h | 38

[f2fs-dev] [Bug 208325] f2fs inconsistent node block

2020-06-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208325 Chao Yu (c...@kernel.org) changed: What|Removed |Added Status|NEW |NEEDINFO CC|

[f2fs-dev] [PATCH] f2fs: remove useless parameter of __insert_free_nid()

2020-06-28 Thread Liu Song via Linux-f2fs-devel
From: Liu Song In current version, @state will only be FREE_NID. This parameter has no real effect so remove it to keep clean. Signed-off-by: Liu Song --- fs/f2fs/node.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index

Re: [f2fs-dev] [PATCH] f2fs: remove unnecessary judgments in __insert_free_nid()

2020-06-28 Thread fishland via Linux-f2fs-devel
>On 2020/6/26 22:39, Liu Song via Linux-f2fs-devel wrote: >> From: Liu Song >> >> The value of state must be equal to FREE_NID, so the if >> condition judgment can be removed. >> >> Signed-off-by: Liu Song >> --- >> fs/f2fs/node.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >>

[f2fs-dev] [PATCH 1/3] f2fs: fix wrong return value of f2fs_bmap_compress()

2020-06-28 Thread Chao Yu
If compression is disable, we should return zero rather than -EOPNOTSUPP to indicate f2fs_bmap() is not supported. Signed-off-by: Chao Yu --- fs/f2fs/data.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index dfd322515357..91dc7b598961

Re: [f2fs-dev] [PATCH v4] f2fs: add f2fs_gc exception handle in f2fs_ioc_gc_range

2020-06-28 Thread Chao Yu
On 2020/6/28 16:06, yuchangchun (C) wrote: > 在 2020/6/28 14:39, Qilong Zhang 写道: >> When f2fs_ioc_gc_range performs multiple segments gc ops, the return >> value of f2fs_ioc_gc_range is determined by the last segment gc ops. >> If its ops failed, the f2fs_ioc_gc_range will be considered to be

Re: [f2fs-dev] [PATCH v4] f2fs: add f2fs_gc exception handle in f2fs_ioc_gc_range

2020-06-28 Thread yuchangchun (C)
在 2020/6/28 14:39, Qilong Zhang 写道: When f2fs_ioc_gc_range performs multiple segments gc ops, the return value of f2fs_ioc_gc_range is determined by the last segment gc ops. If its ops failed, the f2fs_ioc_gc_range will be considered to be failed despite some of previous segments gc ops

[f2fs-dev] [PATCH v5] f2fs: add f2fs_gc exception handle in f2fs_ioc_gc_range

2020-06-28 Thread Qilong Zhang
When f2fs_ioc_gc_range performs multiple segments gc ops, the return value of f2fs_ioc_gc_range is determined by the last segment gc ops. If its ops failed, the f2fs_ioc_gc_range will be considered to be failed despite some of previous segments gc ops succeeded. Therefore, so we fix: Redefine the