Re: [f2fs-dev] [PATCH v11 2/4] fs: Add standard casefolding support

2020-07-08 Thread Daniel Rosenberg via Linux-f2fs-devel
On Tue, Jul 7, 2020 at 9:12 PM Eric Biggers wrote: > > On Tue, Jul 07, 2020 at 08:05:50PM -0700, Daniel Rosenberg wrote: > > +/** > > + * generic_ci_d_compare - generic d_compare implementation for casefolding > > filesystems > > + * @dentry: dentry whose name we are checking against > > + * @le

[f2fs-dev] Will Hot data and Warm data and Cold data in same segment?

2020-07-08 Thread lampahome
One segment will contain many blocks, node and data will not be the same segment. Take data block for example, Will Hot data and Warm data and Cold data in same segment? ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://l

[f2fs-dev] [PATCH v12 1/4] unicode: Add utf8_casefold_hash

2020-07-08 Thread Daniel Rosenberg via Linux-f2fs-devel
This adds a case insensitive hash function to allow taking the hash without needing to allocate a casefolded copy of the string. The existing d_hash implementations for casefolding allocate memory within rcu-walk, by avoiding it we can be more efficient and avoid worrying about a failed allocation

[f2fs-dev] [PATCH v12 0/4] Prepare for upcoming Casefolding/Encryption patches

2020-07-08 Thread Daniel Rosenberg via Linux-f2fs-devel
This lays the ground work for enabling casefolding and encryption at the same time for ext4 and f2fs. A future set of patches will enable that functionality. These unify the highly similar dentry_operations that ext4 and f2fs both use for casefolding. In addition, they improve d_hash by not requir

[f2fs-dev] [PATCH v12 2/4] fs: Add standard casefolding support

2020-07-08 Thread Daniel Rosenberg via Linux-f2fs-devel
This adds general supporting functions for filesystems that use utf8 casefolding. It provides standard dentry_operations and adds the necessary structures in struct super_block to allow this standardization. The new dentry operations are functionally equivalent to the existing operations in ext4 a

[f2fs-dev] [PATCH v12 4/4] ext4: Use generic casefolding support

2020-07-08 Thread Daniel Rosenberg via Linux-f2fs-devel
This switches ext4 over to the generic support provided in the previous patch. Since casefolded dentries behave the same in ext4 and f2fs, we decrease the maintenance burden by unifying them, and any optimizations will immediately apply to both. Signed-off-by: Daniel Rosenberg Reviewed-by: Eric

[f2fs-dev] [PATCH v12 3/4] f2fs: Use generic casefolding support

2020-07-08 Thread Daniel Rosenberg via Linux-f2fs-devel
This switches f2fs over to the generic support provided in the previous patch. Since casefolded dentries behave the same in ext4 and f2fs, we decrease the maintenance burden by unifying them, and any optimizations will immediately apply to both. Signed-off-by: Daniel Rosenberg Reviewed-by: Eric

Re: [f2fs-dev] [PATCH v3] f2fs: add symbolic link to kobject in sysfs

2020-07-08 Thread Greg KH
On Mon, Jul 06, 2020 at 08:47:07AM +0900, Daeho Jeong wrote: > > No Documentation/ABI/ entry for your new sysfs file/link? > > This is for adding a symbolic link to a pre-existed > /sys/fs/f2fs/ directory and it means /sys/fs/f2fs/ points > to /sys/fs/f2fs/. I already added the description of this

Re: [f2fs-dev] [PATCH 1/2] f2fs: support zone capacity less than zone size

2020-07-08 Thread Aravind Ramesh
Please find my response inline. Thanks, Aravind > -Original Message- > From: Chao Yu > Sent: Wednesday, July 8, 2020 8:04 AM > To: Aravind Ramesh ; jaeg...@kernel.org; linux- > fsde...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net; h...@lst.de > Cc: Damien Le Moal ; Niklas Cass

Re: [f2fs-dev] [PATCH v12 2/4] fs: Add standard casefolding support

2020-07-08 Thread Eric Biggers
On Wed, Jul 08, 2020 at 02:12:35AM -0700, Daniel Rosenberg wrote: > This adds general supporting functions for filesystems that use > utf8 casefolding. It provides standard dentry_operations and adds the > necessary structures in struct super_block to allow this standardization. > > The new dentry

Re: [f2fs-dev] [PATCH v4 1/4] fs: introduce SB_INLINECRYPT

2020-07-08 Thread tytso
On Thu, Jul 02, 2020 at 01:56:04AM +, Satya Tangirala wrote: > Introduce SB_INLINECRYPT, which is set by filesystems that wish to use > blk-crypto for file content en/decryption. This flag maps to the > '-o inlinecrypt' mount option which multiple filesystems will implement, > and code in fs/cr

Re: [f2fs-dev] [PATCH v12 3/4] f2fs: Use generic casefolding support

2020-07-08 Thread Jaegeuk Kim
On 07/08, Daniel Rosenberg wrote: > This switches f2fs over to the generic support provided in > the previous patch. > > Since casefolded dentries behave the same in ext4 and f2fs, we decrease > the maintenance burden by unifying them, and any optimizations will > immediately apply to both. > > S

Re: [f2fs-dev] [PATCH v4 2/4] fscrypt: add inline encryption support

2020-07-08 Thread tytso
On Thu, Jul 02, 2020 at 01:56:05AM +, Satya Tangirala wrote: > Add support for inline encryption to fs/crypto/. With "inline > encryption", the block layer handles the decryption/encryption as part > of the bio, instead of the filesystem doing the crypto itself via > Linux's crypto API. This m

Re: [f2fs-dev] [PATCH v4 4/4] ext4: add inline encryption support

2020-07-08 Thread tytso
On Thu, Jul 02, 2020 at 01:56:07AM +, Satya Tangirala wrote: > From: Eric Biggers > > Wire up ext4 to support inline encryption via the helper functions which > fs/crypto/ now provides. This includes: > > - Adding a mount option 'inlinecrypt' which enables inline encryption > on encrypted

Re: [f2fs-dev] [PATCH v4 4/4] ext4: add inline encryption support

2020-07-08 Thread Eric Biggers
On Wed, Jul 08, 2020 at 01:18:12PM -0400, ty...@mit.edu wrote: > On Thu, Jul 02, 2020 at 01:56:07AM +, Satya Tangirala wrote: > > From: Eric Biggers > > > > Wire up ext4 to support inline encryption via the helper functions which > > fs/crypto/ now provides. This includes: > > > > - Adding

Re: [f2fs-dev] [PATCH v3] f2fs: add symbolic link to kobject in sysfs

2020-07-08 Thread Daeho Jeong
I thought it's working for our system. But as you said, it might be not true for others. I got your point. Partition label would be a great idea for us. Thank you for your comment! 2020년 7월 8일 (수) 오후 7:05, Greg KH 님이 작성: > > On Mon, Jul 06, 2020 at 08:47:07AM +0900, Daeho Jeong wrote: > > > No Do

[f2fs-dev] [PATCH] f2fs: ignore when len of range in f2fs_sec_trim_file is zero

2020-07-08 Thread Daeho Jeong
From: Daeho Jeong When end_addr comes to zero, it'll trigger different behaviour. To prevent this, we need to ignore the case of that range.len is zero in the function. Signed-off-by: Daeho Jeong --- fs/f2fs/file.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/f

Re: [f2fs-dev] [PATCH 1/2] f2fs: support zone capacity less than zone size

2020-07-08 Thread Chao Yu
On 2020/7/8 21:04, Aravind Ramesh wrote: > Please find my response inline. > > Thanks, > Aravind > >> -Original Message- >> From: Chao Yu >> Sent: Wednesday, July 8, 2020 8:04 AM >> To: Aravind Ramesh ; jaeg...@kernel.org; linux- >> fsde...@vger.kernel.org; linux-f2fs-devel@lists.sourcef

Re: [f2fs-dev] [PATCH] f2fs: ignore when len of range in f2fs_sec_trim_file is zero

2020-07-08 Thread Chao Yu
On 2020/7/9 9:57, Daeho Jeong wrote: > From: Daeho Jeong > > When end_addr comes to zero, it'll trigger different behaviour. > To prevent this, we need to ignore the case of that range.len is > zero in the function. > > Signed-off-by: Daeho Jeong > --- > fs/f2fs/file.c | 7 +++ > 1 file ch

Re: [f2fs-dev] [PATCH] f2fs: ignore when len of range in f2fs_sec_trim_file is zero

2020-07-08 Thread Daeho Jeong
I thought it's better to treat this as the error case, since the range already passed out of the i_size range. If we allow that, the user needs to send the range parameter being aligned like start:0 and len: roundup(i_size, PAGE_SIZE), even if he or she wants to erase the whole file. 2020년 7월 9일 (

[f2fs-dev] [PATCH] f2fs: don't skip writeback of quota data

2020-07-08 Thread Jaegeuk Kim
It doesn't need to bypass flushing quota data in background. Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 44645f4f914b6..72e8b50e588c1 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -3

Re: [f2fs-dev] [PATCH 1/2] f2fs: support zone capacity less than zone size

2020-07-08 Thread Aravind Ramesh
Please find my response inline. Thanks, Aravind > -Original Message- > From: Chao Yu > Sent: Thursday, July 9, 2020 8:26 AM > To: Aravind Ramesh ; jaeg...@kernel.org; linux- > fsde...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net; h...@lst.de > Cc: Damien Le Moal ; Niklas Casse

Re: [f2fs-dev] [PATCH] f2fs: ignore when len of range in f2fs_sec_trim_file is zero

2020-07-08 Thread Jaegeuk Kim
On 07/09, Chao Yu wrote: > On 2020/7/9 9:57, Daeho Jeong wrote: > > From: Daeho Jeong > > > > When end_addr comes to zero, it'll trigger different behaviour. > > To prevent this, we need to ignore the case of that range.len is > > zero in the function. > > > > Signed-off-by: Daeho Jeong > > ---

Re: [f2fs-dev] [PATCH] f2fs: ignore when len of range in f2fs_sec_trim_file is zero

2020-07-08 Thread Daeho Jeong
I can add it~ 2020년 7월 9일 (목) 오후 2:39, Jaegeuk Kim 님이 작성: > > On 07/09, Chao Yu wrote: > > On 2020/7/9 9:57, Daeho Jeong wrote: > > > From: Daeho Jeong > > > > > > When end_addr comes to zero, it'll trigger different behaviour. > > > To prevent this, we need to ignore the case of that range.len i