[f2fs-dev] [PATCH 1/2] f2fs: replace F2FS_I(inode) by the local variable

2022-05-25 Thread Yufen Yu via Linux-f2fs-devel
We have define 'fi' at the begin of function do_read_inode(), just use it, rather than use F2FS_I(inode) again. Signed-off-by: Yufen Yu --- fs/f2fs/inode.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index 83639238a1fe..9bad349be9

[f2fs-dev] [PATCH 2/2] f2fs: add f2fs_init_write_merge_io function

2022-05-25 Thread Yufen Yu via Linux-f2fs-devel
Almost all other initialization of variables in f2fs_fill_super are extraced to a single function. Also do it for write_io[], which can make code more clean. This patch just refactors the code, theres no functional change. Signed-off-by: Yufen Yu --- fs/f2fs/data.c | 30 +++

Re: [f2fs-dev] [PATCH 1/2] f2fs: replace F2FS_I(inode) by the local variable

2022-05-25 Thread Chao Yu
On 2022/5/25 17:43, Yufen Yu via Linux-f2fs-devel wrote: We have define 'fi' at the begin of function do_read_inode(), just use it, rather than use F2FS_I(inode) again. How about cleaning up F2FS_I() in other functions, if 'fi' existed? Thanks, ___

Re: [f2fs-dev] [PATCH 2/2] f2fs: add f2fs_init_write_merge_io function

2022-05-25 Thread Chao Yu
On 2022/5/25 17:43, Yufen Yu via Linux-f2fs-devel wrote: Almost all other initialization of variables in f2fs_fill_super are extraced to a single function. Also do it for write_io[], which can make code more clean. This patch just refactors the code, theres no functional change. Signed-off-by:

[f2fs-dev] [PATCH] Support zoned device if libc exists

2022-05-25 Thread Jaegeuk Kim
Signed-off-by: Jaegeuk Kim --- include/android_config.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/include/android_config.h b/include/android_config.h index 5f5c693cbbb3..07440874188c 100644 --- a/include/android_config.h +++ b/include/android_config.h @@ -4,8 +4,

[f2fs-dev] [PATCH 1/4] libzone: remove duplicate header

2022-05-25 Thread Jaegeuk Kim
Signed-off-by: Jaegeuk Kim --- lib/libf2fs_zoned.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/libf2fs_zoned.c b/lib/libf2fs_zoned.c index c5c6ddee7cdd..f383ce275342 100644 --- a/lib/libf2fs_zoned.c +++ b/lib/libf2fs_zoned.c @@ -27,8 +27,6 @@ #endif #include -#include - #ifdef

[f2fs-dev] [PATCH 4/4] avoid unnecessary function

2022-05-25 Thread Jaegeuk Kim
libf2fs.c:883:12: warning: unused function 'is_power_of_2' [-Wunused-function] Signed-off-by: Jaegeuk Kim --- lib/libf2fs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/libf2fs.c b/lib/libf2fs.c index ad8d1bd03509..36b8c25980ab 100644 --- a/lib/libf2fs.c +++ b/lib/libf2fs.c @@ -880,

[f2fs-dev] [PATCH 2/4] Remove unnecessary config.h

2022-05-25 Thread Jaegeuk Kim
Instead, we should use generated by configure. Signed-off-by: Jaegeuk Kim --- fsck/dict.c | 1 - fsck/mkquota.c | 2 +- fsck/quotaio.c | 1 - fsck/quotaio_tree.c | 1 - fsck/quotaio_v2.c | 1 - lib/nls_utf8.c | 3 +-- mkfs/f2fs_format.c | 2

[f2fs-dev] [PATCH 3/4] Fix dependencies on linux/blkzoned.h when using Bionic.

2022-05-25 Thread Jaegeuk Kim
From: Martin Stjernholm This reverts commit adcec10b4dee ("Support zoned device if libc exists). Signed-off-by: Martin Stjernholm Signed-off-by: Jaegeuk Kim --- include/android_config.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/android_config.h b/include/an

[f2fs-dev] [PATCH] Check fallthrough in mount.h for Mac

2022-05-25 Thread Jaegeuk Kim
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/include/os/base.h:128:23: error: missing ')' after 'do' ^~~ external/f2fs-tools/include/f2fs_fs.h:81:24: note: expanded from macro 'fallthrough'

[f2fs-dev] [PATCH v2] f2fs: replace F2FS_I(inode) by the local variable

2022-05-25 Thread Yufen Yu via Linux-f2fs-devel
We have define 'fi' at the begin of the functions, just use it, rather than use F2FS_I(inode) again. Signed-off-by: Yufen Yu --- fs/f2fs/f2fs.h | 2 +- fs/f2fs/file.c | 14 +++--- fs/f2fs/inode.c | 12 ++-- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/fs/f2