Re: [f2fs-dev] [PATCH Vx 1/1] f2fs: fix some error handling case in gc

On 2022/9/15 14:18, zhiguo.niu wrote: During GC, if segment type stored in SSA and SIT is inconsistent, we set SBI_NEED_FSCK first and then stop checkpoint, this will cause the following issues: 1. SBI_NEED_FSCK can not be set to flash truly because of checkpoint has been stopped. 2. Will cause m

Re: [f2fs-dev] [PATCH -next] f2fs: code clean and fix a type error

On 2022/9/14 9:33, Zhang Qilong wrote: ERROR: code indent should use tabs where possible ERROR: spaces required around that ':' ERROR: incorrect tab Found serveral code type errors when review the code and fix it. There is no function change. Signed-off-by: Zhang Qilong Reviewed-by: Chao Yu

Re: [f2fs-dev] [PATCH -next] f2fs: add a trace interface for f2fs_update_extent_tree_range_compressed

On 2022/9/15 21:44, Zhang Qilong wrote: For f2fs_update_extent_tree_range_compressed, keeping the trace and function name consistent to distinguish from trace of f2fs_update_extent_tree_range. And we add "c_len" into the trace, result like: [003] . 228.568157: f2fs_update_extent_tree_ra

[f2fs-dev] [PATCH] f2fs: fix typo

Fix typo in f2fs.h Detected by Jaeyoon Choi Signed-off-by: Yonggil Song --- fs/f2fs/f2fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index eddfd35eadb6..661096be59d1 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -274,7 +274,7 @@

[f2fs-dev] [PATCH V2] f2fs: fix some error handling case in gc

During GC, if segment type stored in SSA and SIT is inconsistent, we set SBI_NEED_FSCK first and then stop checkpoint, this will cause the following issues: 1. SBI_NEED_FSCK can not be set to flash truly because of checkpoint has been stopped. 2. Will cause more EIO error if user use f2fs because o