Re: [f2fs-dev] [PATCH 01/11] kset: fix documentation for kset_register()

2022-10-21 Thread Luben Tuikov via Linux-f2fs-devel
On 2022-10-20 22:20, Yang Yingliang wrote: > kset_register() is currently used in some places without calling > kset_put() in error path, because the callers think it should be > kset internal thing to do, but the driver core can not know what > caller doing with that memory at times. The memory co

Re: [f2fs-dev] [PATCH 00/11] fix memory leak while kset_register() fails

2022-10-21 Thread Yang Yingliang via Linux-f2fs-devel
Hi, On 2022/10/21 13:29, Luben Tuikov wrote: On 2022-10-20 22:20, Yang Yingliang wrote: The previous discussion link: https://lore.kernel.org/lkml/0db486eb-6927-927e-3629-958f8f211...@huawei.com/T/ The very first discussion on this was here: https://www.spinics.net/lists/dri-devel/msg368077.h

Re: [f2fs-dev] [PATCH 01/11] kset: fix documentation for kset_register()

2022-10-21 Thread Yang Yingliang via Linux-f2fs-devel
On 2022/10/21 13:34, Luben Tuikov wrote: On 2022-10-20 22:20, Yang Yingliang wrote: kset_register() is currently used in some places without calling kset_put() in error path, because the callers think it should be kset internal thing to do, but the driver core can not know what caller doing wi

Re: [f2fs-dev] [PATCH 01/11] kset: fix documentation for kset_register()

2022-10-21 Thread Greg KH
On Fri, Oct 21, 2022 at 04:05:18PM +0800, Yang Yingliang wrote: > > On 2022/10/21 13:34, Luben Tuikov wrote: > > On 2022-10-20 22:20, Yang Yingliang wrote: > > > kset_register() is currently used in some places without calling > > > kset_put() in error path, because the callers think it should be

Re: [f2fs-dev] [PATCH 00/11] fix memory leak while kset_register() fails

2022-10-21 Thread Greg KH
On Fri, Oct 21, 2022 at 03:55:18AM -0400, Luben Tuikov wrote: > On 2022-10-21 01:37, Greg KH wrote: > > On Fri, Oct 21, 2022 at 01:29:31AM -0400, Luben Tuikov wrote: > >> On 2022-10-20 22:20, Yang Yingliang wrote: > >>> The previous discussion link: > >>> https://nam11.safelinks.protection.outlook.

Re: [f2fs-dev] [PATCH 01/11] kset: fix documentation for kset_register()

2022-10-21 Thread Luben Tuikov via Linux-f2fs-devel
On 2022-10-21 04:05, Yang Yingliang wrote: > > On 2022/10/21 13:34, Luben Tuikov wrote: >> On 2022-10-20 22:20, Yang Yingliang wrote: >>> kset_register() is currently used in some places without calling >>> kset_put() in error path, because the callers think it should be >>> kset internal thing to

Re: [f2fs-dev] [PATCH 00/11] fix memory leak while kset_register() fails

2022-10-21 Thread Yang Yingliang via Linux-f2fs-devel
On 2022/10/21 13:37, Greg KH wrote: On Fri, Oct 21, 2022 at 01:29:31AM -0400, Luben Tuikov wrote: On 2022-10-20 22:20, Yang Yingliang wrote: The previous discussion link: https://lore.kernel.org/lkml/0db486eb-6927-927e-3629-958f8f211...@huawei.com/T/ The very first discussion on this was here

Re: [f2fs-dev] [PATCH 00/11] fix memory leak while kset_register() fails

2022-10-21 Thread Greg KH
On Fri, Oct 21, 2022 at 04:24:23PM +0800, Yang Yingliang wrote: > > On 2022/10/21 13:37, Greg KH wrote: > > On Fri, Oct 21, 2022 at 01:29:31AM -0400, Luben Tuikov wrote: > > > On 2022-10-20 22:20, Yang Yingliang wrote: > > > > The previous discussion link: > > > > https://lore.kernel.org/lkml/0db4

[f2fs-dev] [PATCH] f2fs: make gc_idle sysfs node readable

2022-10-21 Thread Yangtao Li via Linux-f2fs-devel
Changed a way of showing values of them to use strings. Signed-off-by: Yangtao Li --- fs/f2fs/sysfs.c | 4 1 file changed, 4 insertions(+) diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c index b4476adea776..555849d4c744 100644 --- a/fs/f2fs/sysfs.c +++ b/fs/f2fs/sysfs.c @@ -332,6 +332,10 @@

Re: [f2fs-dev] [PATCH 00/11] fix memory leak while kset_register() fails

2022-10-21 Thread Luben Tuikov via Linux-f2fs-devel
On 2022-10-21 04:36, Greg KH wrote: > On Fri, Oct 21, 2022 at 04:24:23PM +0800, Yang Yingliang wrote: >> >> On 2022/10/21 13:37, Greg KH wrote: >>> On Fri, Oct 21, 2022 at 01:29:31AM -0400, Luben Tuikov wrote: On 2022-10-20 22:20, Yang Yingliang wrote: > The previous discussion link: >

Re: [f2fs-dev] [PATCH 00/11] fix memory leak while kset_register() fails

2022-10-21 Thread Yang Yingliang via Linux-f2fs-devel
On 2022/10/21 16:36, Greg KH wrote: On Fri, Oct 21, 2022 at 04:24:23PM +0800, Yang Yingliang wrote: On 2022/10/21 13:37, Greg KH wrote: On Fri, Oct 21, 2022 at 01:29:31AM -0400, Luben Tuikov wrote: On 2022-10-20 22:20, Yang Yingliang wrote: The previous discussion link: https://lore.kernel.o

Re: [f2fs-dev] [PATCH 00/11] fix memory leak while kset_register() fails

2022-10-21 Thread Luben Tuikov via Linux-f2fs-devel
On 2022-10-21 04:59, Yang Yingliang wrote: > > On 2022/10/21 16:36, Greg KH wrote: >> On Fri, Oct 21, 2022 at 04:24:23PM +0800, Yang Yingliang wrote: >>> On 2022/10/21 13:37, Greg KH wrote: On Fri, Oct 21, 2022 at 01:29:31AM -0400, Luben Tuikov wrote: > On 2022-10-20 22:20, Yang Yingliang

Re: [f2fs-dev] [PATCH 00/11] fix memory leak while kset_register() fails

2022-10-21 Thread Yang Yingliang via Linux-f2fs-devel
On 2022/10/21 16:36, Greg KH wrote: On Fri, Oct 21, 2022 at 04:24:23PM +0800, Yang Yingliang wrote: On 2022/10/21 13:37, Greg KH wrote: On Fri, Oct 21, 2022 at 01:29:31AM -0400, Luben Tuikov wrote: On 2022-10-20 22:20, Yang Yingliang wrote: The previous discussion link: https://lore.kernel.o

Re: [f2fs-dev] [PATCH 00/11] fix memory leak while kset_register() fails

2022-10-21 Thread Luben Tuikov via Linux-f2fs-devel
On 2022-10-21 04:24, Luben Tuikov wrote: > On 2022-10-21 04:18, Greg KH wrote: >> On Fri, Oct 21, 2022 at 03:55:18AM -0400, Luben Tuikov wrote: >>> On 2022-10-21 01:37, Greg KH wrote: On Fri, Oct 21, 2022 at 01:29:31AM -0400, Luben Tuikov wrote: > On 2022-10-20 22:20, Yang Yingliang wrote:

Re: [f2fs-dev] [PATCH 00/11] fix memory leak while kset_register() fails

2022-10-21 Thread Yang Yingliang via Linux-f2fs-devel
On 2022/10/21 16:41, Luben Tuikov wrote: On 2022-10-21 04:24, Luben Tuikov wrote: On 2022-10-21 04:18, Greg KH wrote: On Fri, Oct 21, 2022 at 03:55:18AM -0400, Luben Tuikov wrote: On 2022-10-21 01:37, Greg KH wrote: On Fri, Oct 21, 2022 at 01:29:31AM -0400, Luben Tuikov wrote: On 2022-10-2

[f2fs-dev] [PATCH] f2fs: show more debug info for discard pend list

2022-10-21 Thread Yangtao Li via Linux-f2fs-devel
This patch shows the discard pend list information: Discard pend list(X:exist .:not exist): 0 X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X 32 X X X X . X X . X X X X X X X X X X X X . X X . X X . X X . X X 64 . . X X . X X . . X . . . X X . X . X . X X . X . X X . . .

Re: [f2fs-dev] [PATCH 00/11] fix memory leak while kset_register() fails

2022-10-21 Thread Yang Yingliang via Linux-f2fs-devel
On 2022/10/21 17:08, Luben Tuikov wrote: On 2022-10-21 04:59, Yang Yingliang wrote: On 2022/10/21 16:36, Greg KH wrote: On Fri, Oct 21, 2022 at 04:24:23PM +0800, Yang Yingliang wrote: On 2022/10/21 13:37, Greg KH wrote: On Fri, Oct 21, 2022 at 01:29:31AM -0400, Luben Tuikov wrote: On 2022-1

[f2fs-dev] [PATCH] f2fs: introduce max_order_discard sysfs node

2022-10-21 Thread Yangtao Li via Linux-f2fs-devel
The current max_order_discard is a fixed value, change it to be configurable through the sys node. Signed-off-by: Yangtao Li --- Documentation/ABI/testing/sysfs-fs-f2fs | 6 ++ fs/f2fs/f2fs.h | 3 +++ fs/f2fs/segment.c | 3 ++- fs/f2fs/sysfs.

Re: [f2fs-dev] [PATCH 00/11] fix memory leak while kset_register() fails

2022-10-21 Thread Luben Tuikov via Linux-f2fs-devel
On 2022-10-21 04:18, Greg KH wrote: > On Fri, Oct 21, 2022 at 03:55:18AM -0400, Luben Tuikov wrote: >> On 2022-10-21 01:37, Greg KH wrote: >>> On Fri, Oct 21, 2022 at 01:29:31AM -0400, Luben Tuikov wrote: On 2022-10-20 22:20, Yang Yingliang wrote: > The previous discussion link: > http

[f2fs-dev] [Bug 215235] page fault in f2fs_setxattr() when mount and operate on corrupted image

2022-10-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215235 alexwriter (alexwriter2...@gmail.com) changed: What|Removed |Added CC||alexwriter2...@gma

[f2fs-dev] [PATCH 1/2] f2fs: fix to correct invalid batched_trim_sections node

2022-10-21 Thread Yangtao Li via Linux-f2fs-devel
commit 377224c47118("f2fs: don't split checkpoint in fstrim") obsolete batch mode and related sysfs entry, but use wrong name. Let's fix it to right name. Signed-off-by: Yangtao Li --- fs/f2fs/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/

[f2fs-dev] [PATCH 2/2] f2fs: remove batched_trim_sections node

2022-10-21 Thread Yangtao Li via Linux-f2fs-devel
This testing sysfs node has been deprecated for a long time, let's remove it. Signed-off-by: Yangtao Li --- fs/f2fs/f2fs.h | 3 --- fs/f2fs/sysfs.c | 5 - 2 files changed, 8 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index e6355a5683b7..9c480835adab 100644 --- a/fs/f2fs/f2fs

[f2fs-dev] [PATCH 2/2] f2fs: introducr gc_urgent_idle_remaining sysfs node and mark gc_urgent_high_remaining node deprecated

2022-10-21 Thread Yangtao Li via Linux-f2fs-devel
Added a new sysfs node called gc_urgent_idle_remaining. The user can set the trial count limit for GC urgent and idle mode with this value. If GC thread gets to the limit, the mode will turn back to GC normal mode finally. This method is not only applicable to gc_urgent_high, but applicable to all

[f2fs-dev] [PATCH 1/2] f2fs: fix gc mode when gc_urgent_high_remaining is 1

2022-10-21 Thread Yangtao Li via Linux-f2fs-devel
Under the current logic, when gc_urgent_high_remaining is set to 1, the mode will be switched to normal at the beginning, instead of running in gc_urgent mode. Let's switch the gc mode back to normal when the gc ends. Fixes: 265576181b4a ("f2fs: remove gc_urgent_high_limited for cleanup") Signed

Re: [f2fs-dev] [PATCH] f2fs: let's avoid to get cp_rwsem twice by f2fs_evict_inode by d_invalidate

2022-10-21 Thread Yangtao Li via Linux-f2fs-devel
Tested-by: Yangtao Li Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH 00/11] fix memory leak while kset_register() fails

2022-10-21 Thread Luben Tuikov via Linux-f2fs-devel
On 2022-10-21 05:56, Yang Yingliang wrote: > > On 2022/10/21 17:08, Luben Tuikov wrote: >> On 2022-10-21 04:59, Yang Yingliang wrote: >>> On 2022/10/21 16:36, Greg KH wrote: On Fri, Oct 21, 2022 at 04:24:23PM +0800, Yang Yingliang wrote: > On 2022/10/21 13:37, Greg KH wrote: >> On Fri

Re: [f2fs-dev] [PATCH 00/11] fix memory leak while kset_register() fails

2022-10-21 Thread Luben Tuikov via Linux-f2fs-devel
On 2022-10-21 05:12, Yang Yingliang wrote: > > On 2022/10/21 16:36, Greg KH wrote: >> On Fri, Oct 21, 2022 at 04:24:23PM +0800, Yang Yingliang wrote: >>> On 2022/10/21 13:37, Greg KH wrote: On Fri, Oct 21, 2022 at 01:29:31AM -0400, Luben Tuikov wrote: > On 2022-10-20 22:20, Yang Yingliang

[f2fs-dev] [Bug 216050] f2fs_gc occupies 100% cpu

2022-10-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216050 --- Comment #65 from bogdan.nico...@gmail.com --- Unfortunately 6.0.1-arch2-1 didn't do the trick for me. I'm still experiencing this bug, especially when my laptop is coming out of sleep. -- You may reply to this email to add a comment. You ar