[f2fs-dev] [PATCH] f2fs: check zone type before sending async reset zone command

2023-08-04 Thread Shin'ichiro Kawasaki via Linux-f2fs-devel
The commit 25f9080576b9 ("f2fs: add async reset zone command support") introduced "async reset zone commands" by calling __submit_zone_reset_cmd() in async discard operations. However, __submit_zone_reset_cmd() is called regardless of zone type of discard target zone. When devices have conventional

Re: [f2fs-dev] [PATCH] f2fs: clean up w/ sbi->log_sectors_per_block

2023-08-04 Thread Shinichiro Kawasaki via Linux-f2fs-devel
On May 23, 2023 / 20:35, Chao Yu wrote: > Use sbi->log_sectors_per_block to clean up below calculated one: > > unsigned int log_sectors_per_block = sbi->log_blocksize - SECTOR_SHIFT; Hello Chao, When I ran workloads on f2fs using v6.5-rcX with fixes [1][2] and a zoned block devices with 4kb logi

Re: [f2fs-dev] more blkdev_get and holder work

2023-08-04 Thread Christian Brauner
On Wed, 02 Aug 2023 17:41:19 +0200, Christoph Hellwig wrote: > this series sits on top of the vfs.super branch in the VFS tree and does a > few closely related things: > > 1) it also converts nilfs2 and btrfs to the new scheme where the file system > only opens the block devices after we kn

Re: [f2fs-dev] [PATCH] f2fs: clean up w/ sbi->log_sectors_per_block

2023-08-04 Thread Jaegeuk Kim
On 08/04, Shinichiro Kawasaki wrote: > On May 23, 2023 / 20:35, Chao Yu wrote: > > Use sbi->log_sectors_per_block to clean up below calculated one: > > > > unsigned int log_sectors_per_block = sbi->log_blocksize - SECTOR_SHIFT; > > Hello Chao, > > When I ran workloads on f2fs using v6.5-rcX with

Re: [f2fs-dev] [PATCH 05/12] ext4: make the IS_EXT2_SB/IS_EXT3_SB checks more robust

2023-08-04 Thread Theodore Ts'o
On Wed, Aug 02, 2023 at 05:41:24PM +0200, Christoph Hellwig wrote: > Check for sb->s_type which is the right place to look at the file system > type, not the holder, which is just an implementation detail in the VFS > helpers. > > Signed-off-by: Christoph Hellwig Acked-by: Theodore Ts'o _

Re: [f2fs-dev] [PATCH 09/12] ext4: drop s_umount over opening the log device

2023-08-04 Thread Theodore Ts'o
On Wed, Aug 02, 2023 at 05:41:28PM +0200, Christoph Hellwig wrote: > Just like get_tree_bdev needs to drop s_umount when opening the main > device, we need to do the same for the ext4 log device to avoid a > potential lock order reversal with s_unmount for the mark_dead path. > > It might be prefe

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-08-04 Thread Jaegeuk Kim
On 07/25, Chao Yu wrote: > On 2023/7/22 4:23, Jaegeuk Kim wrote: > > On 07/13, Chao Yu wrote: > > > On 2023/7/12 23:55, Jaegeuk Kim wrote: > > > > On 07/12, Chao Yu wrote: > > > > > On 2023/7/12 0:37, Jaegeuk Kim wrote: > > > > > > On 07/06, Chao Yu wrote: > > > > > > > On 2023/7/6 1:30, Jaegeuk Ki