Re: [f2fs-dev] [PATCH v2] f2fs: replace blk_finish_plug() with blk_flush_plug()

2023-09-06 Thread Chao Yu
On 2023/9/5 21:42, Chunhai Guo wrote: On 2023/9/5 0:40, Jaegeuk Kim wrote: On 09/04, Chao Yu wrote: On 2023/8/31 15:10, Chunhai Guo wrote: The commit 344150999b7f ("f2fs: fix to avoid potential deadlock") only requires unplugging current->plug. Using blk_finish_plug() is unnecessary as it se

Re: [f2fs-dev] [PATCH] f2fs: fix deadlock in f2f2_add_dentry

2023-09-06 Thread Tetsuo Handa
On 2023/08/25 14:37, Lizhi Xu wrote: > @@ -736,12 +736,12 @@ int f2fs_add_regular_entry(struct inode *dir, const > struct f2fs_filename *fname, > f2fs_wait_on_page_writeback(dentry_page, DATA, true, true); > > if (inode) { > - f2fs_down_write(&F2FS_I(inode)->i_sem); >

[f2fs-dev] [PATCH] f2fs: fix to drop meta_inode's page cache in f2fs_put_super()

2023-09-06 Thread Chao Yu
syzbot reports a kernel bug as below: F2FS-fs (loop1): detect filesystem reference count leak during umount, type: 10, count: 1 kernel BUG at fs/f2fs/super.c:1639! CPU: 0 PID: 15451 Comm: syz-executor.1 Not tainted 6.5.0-syzkaller-09338-ge0152e7481c6 #0 RIP: 0010:f2fs_put_super+0xce1/0xed0 fs/f2

Re: [f2fs-dev] [PATCH 2/2] fsverity: move sysctl registration out of signature.c

2023-09-06 Thread Eric Biggers
On Wed, Sep 06, 2023 at 03:49:04PM +0200, Joel Granados wrote: > On Wed, Jul 05, 2023 at 02:27:43PM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > Currently the registration of the fsverity sysctls happens in > > signature.c, which couples it to CONFIG_FS_VERITY_BUILTIN_SIGNATURES. > >