[f2fs-dev] [bug report] f2fs: use BLKS_PER_SEG, BLKS_PER_SEC, and SEGS_PER_SEC

2024-02-27 Thread Dan Carpenter
Hello Jaegeuk Kim, The patch 9c1d3cd4ff8c: "f2fs: use BLKS_PER_SEG, BLKS_PER_SEC, and SEGS_PER_SEC" from Feb 6, 2024 (linux-next), leads to the following Smatch static checker warning: fs/f2fs/gc.c:2092 update_fs_metadata() warn: cast after binop fs/f2fs/gc.c 2089 static

[f2fs-dev] [bug report] f2fs: stop checkpoint when get a out-of-bounds segment

2024-02-27 Thread Dan Carpenter
Hello Zhiguo Niu, The patch 7a0392932f97: "f2fs: stop checkpoint when get a out-of-bounds segment" from Feb 20, 2024 (linux-next), leads to the following Smatch static checker warning: fs/f2fs/checkpoint.c:34 f2fs_stop_checkpoint() warn: sleeping in atomic context

Re: [f2fs-dev] [PATCH v2 0/4] f2fs: fix panic issue in small capacity device

2024-02-27 Thread Jaegeuk Kim
On 02/27, Zhiguo Niu wrote: > On Tue, Feb 27, 2024 at 9:13 AM Jaegeuk Kim wrote: > > > > On 02/26, Zhiguo Niu wrote: > > > Dear Chao, > > > > > > On Fri, Feb 23, 2024 at 10:38 AM Chao Yu wrote: > > > > > > > > On 2024/2/23 10:01, Zhiguo Niu wrote: > > > > > > > > > > > > > > > On Thu, Feb 22,

Re: [f2fs-dev] [bug report] f2fs: stop checkpoint when get a out-of-bounds segment

2024-02-27 Thread Jaegeuk Kim
Hi, I merged two patches, which addresses this. f2fs: stop checkpoint when get a out-of-bounds segment f2fs: fix to don't call f2fs_stop_checkpoint in spinlock coverage On 02/27, Dan Carpenter wrote: > Hello Zhiguo Niu, > > The patch 7a0392932f97: "f2fs: stop checkpoint when get a >

Re: [f2fs-dev] [PATCH 2/4] f2fs: fix to don't call f2fs_stop_checkpoint in spinlock coverage

2024-02-27 Thread Jaegeuk Kim
On 02/22, Chao Yu wrote: > f2fs_stop_checkpoint(, false) is complex and it may sleep, so we should > move it outside segmap_lock spinlock coverage in get_new_segment(). Chao, I merged this patch into

Re: [f2fs-dev] [PATCH v7 00/10] Set casefold/fscrypt dentry operations through sb->s_d_op

2024-02-27 Thread Gabriel Krisman Bertazi
Eric Biggers writes: > On Wed, Feb 21, 2024 at 12:14:02PM -0500, Gabriel Krisman Bertazi wrote: >> >> When case-insensitive and fscrypt were adapted to work together, we moved the >> code that sets the dentry operations for case-insensitive dentries(d_hash and >> d_compare) to happen from a

Re: [f2fs-dev] [PATCH] f2fs: introduce SEGS_TO_BLKS/BLKS_TO_SEGS for cleanup

2024-02-27 Thread Jaegeuk Kim
On 02/21, Chao Yu wrote: > Just cleanup, no functional change. > > Signed-off-by: Chao Yu > --- > fs/f2fs/debug.c | 7 +++ > fs/f2fs/f2fs.h| 14 -- > fs/f2fs/gc.c | 10 +- > fs/f2fs/gc.h | 4 ++-- > fs/f2fs/segment.c | 12 ++-- >

Re: [f2fs-dev] [bug report] f2fs: use BLKS_PER_SEG, BLKS_PER_SEC, and SEGS_PER_SEC

2024-02-27 Thread Jaegeuk Kim
On 02/27, Dan Carpenter wrote: > Hello Jaegeuk Kim, > > The patch 9c1d3cd4ff8c: "f2fs: use BLKS_PER_SEG, BLKS_PER_SEC, and > SEGS_PER_SEC" from Feb 6, 2024 (linux-next), leads to the following > Smatch static checker warning: > > fs/f2fs/gc.c:2092 update_fs_metadata() > warn: cast

Re: [f2fs-dev] [PATCH v12 3/8] libfs: Introduce case-insensitive string comparison helper

2024-02-27 Thread Gabriel Krisman Bertazi
Eugen Hristev writes: > From: Gabriel Krisman Bertazi > > generic_ci_match can be used by case-insensitive filesystems to compare > strings under lookup with dirents in a case-insensitive way. This > function is currently reimplemented by each filesystem supporting > casefolding, so this

Re: [f2fs-dev] [PATCH 5/5] f2fs: allow to mount if cap is 100

2024-02-27 Thread Daeho Jeong
On Mon, Feb 26, 2024 at 2:47 PM Jaegeuk Kim wrote: > > On 02/26, Daeho Jeong wrote: > > On Fri, Feb 23, 2024 at 12:56 PM Jaegeuk Kim wrote: > > > > > > Don't block mounting the partition, if cap is 100%. > > > > > > Signed-off-by: Jaegeuk Kim > > > --- > > > fs/f2fs/segment.c | 3 +++ > > > 1

[f2fs-dev] 答复: [bug report] f2fs: stop checkpoint when get a out-of-bounds segment

2024-02-27 Thread Zhiguo Niu
Hi Jaegeuk, Chao's patch fix should can fix this warning: f2fs: fix to don't call f2fs_stop_checkpoint in spinlock coverage thanks! -邮件原件- 发件人: Jaegeuk Kim 发送时间: 2024年2月28日 1:38 收件人: Dan Carpenter 抄送: 牛志国 (Zhiguo Niu) ; linux-f2fs-devel@lists.sourceforge.net 主题: Re: [f2fs-dev] [bug

[f2fs-dev] 答复: [bug report] f2fs: stop checkpoint when get a out-of-bounds segment

2024-02-27 Thread Zhiguo Niu
Hi Jaegeuk, I understand what you mean^^, please ignore my last email, sorry again:). Thanks! -邮件原件- 发件人: 牛志国 (Zhiguo Niu) 发送时间: 2024年2月28日 8:55 收件人: 'Jaegeuk Kim' ; 'Dan Carpenter' 抄送: 'linux-f2fs-devel@lists.sourceforge.net' ; 金红宇 (Hongyu Jin) ; 'Chao Yu' 主题: 答复: [f2fs-dev] [bug

Re: [f2fs-dev] [PATCH v12 0/8] Cache insensitive cleanup for ext4/f2fs

2024-02-27 Thread Gabriel Krisman Bertazi
Eugen Hristev writes: > Hello, > > I am trying to respin the series here : > https://www.spinics.net/lists/linux-ext4/msg85081.html This has a reviewed-by tag from Eric, but since its been years and we've been going through more changes now, I'd ask you to drop the r-b until Eric has had a

Re: [f2fs-dev] [PATCH v2 0/4] f2fs: fix panic issue in small capacity device

2024-02-27 Thread Zhiguo Niu
On Wed, Feb 28, 2024 at 1:18 AM Jaegeuk Kim wrote: > > On 02/27, Zhiguo Niu wrote: > > On Tue, Feb 27, 2024 at 9:13 AM Jaegeuk Kim wrote: > > > > > > On 02/26, Zhiguo Niu wrote: > > > > Dear Chao, > > > > > > > > On Fri, Feb 23, 2024 at 10:38 AM Chao Yu wrote: > > > > > > > > > > On 2024/2/23

Re: [f2fs-dev] [PATCH 2/4] f2fs: fix to don't call f2fs_stop_checkpoint in spinlock coverage

2024-02-27 Thread Chao Yu
On 2024/2/28 1:50, Jaegeuk Kim wrote: On 02/22, Chao Yu wrote: f2fs_stop_checkpoint(, false) is complex and it may sleep, so we should move it outside segmap_lock spinlock coverage in get_new_segment(). Chao, I merged this patch into

Re: [f2fs-dev] [PATCH v12 6/8] ext4: Log error when lookup of encoded dentry fails

2024-02-27 Thread Gabriel Krisman Bertazi
Eugen Hristev writes: > From: Gabriel Krisman Bertazi > > If the volume is in strict mode, ext4_ci_compare can report a broken > encoding name. This will not trigger on a bad lookup, which is caught > earlier, only if the actual disk name is bad. > > Reviewed-by: Eric Biggers > Signed-off-by:

Re: [f2fs-dev] [PATCH] f2fs: introduce SEGS_TO_BLKS/BLKS_TO_SEGS for cleanup

2024-02-27 Thread Chao Yu
On 2024/2/28 1:47, Jaegeuk Kim wrote: On 02/21, Chao Yu wrote: Just cleanup, no functional change. Signed-off-by: Chao Yu --- fs/f2fs/debug.c | 7 +++ fs/f2fs/f2fs.h| 14 -- fs/f2fs/gc.c | 10 +- fs/f2fs/gc.h | 4 ++-- fs/f2fs/segment.c | 12

Re: [f2fs-dev] [PATCH v2 0/4] f2fs: fix panic issue in small capacity device

2024-02-27 Thread Chao Yu
On 2024/2/28 1:18, Jaegeuk Kim wrote: On 02/27, Zhiguo Niu wrote: On Tue, Feb 27, 2024 at 9:13 AM Jaegeuk Kim wrote: On 02/26, Zhiguo Niu wrote: Dear Chao, On Fri, Feb 23, 2024 at 10:38 AM Chao Yu wrote: On 2024/2/23 10:01, Zhiguo Niu wrote: On Thu, Feb 22, 2024 at 8:30 PM Chao Yu

Re: [f2fs-dev] [PATCH v12 2/8] f2fs: Simplify the handling of cached insensitive names

2024-02-27 Thread Gabriel Krisman Bertazi
Eugen Hristev writes: > From: Gabriel Krisman Bertazi > > Keeping it as qstr avoids the unnecessary conversion in f2fs_match > > Reviewed-by: Eric Biggers > Signed-off-by: Gabriel Krisman Bertazi > [eugen.hris...@collabora.com: port to 6.8-rc3] > Signed-off-by: Eugen Hristev > --- >