Re: [f2fs-dev] [PATCH 1/2] f2fs: fix to relocate check condition in f2fs_fallocate()

2024-04-06 Thread Zhiguo Niu
On Wed, Apr 3, 2024 at 10:26 PM Chao Yu wrote: > > compress and pinfile flag should be checked after inode lock held to > avoid race condition, fix it. > > Fixes: 4c8ff7095bef ("f2fs: support data compression") > Fixes: 5fed0be8583f ("f2fs: do not allow partial truncation on pinned file") > Signed

Re: [f2fs-dev] [PATCH v7] f2fs: prevent writing without fallocate() for pinned files

2024-04-06 Thread Chao Yu
On 2024/4/1 23:13, Daeho Jeong wrote: From: Daeho Jeong In a case writing without fallocate(), we can't guarantee it's allocated in the conventional area for zoned stroage. To make it consistent across storage devices, we disallow it regardless of storage device types. Signed-off-by: Daeho Jeo

Re: [f2fs-dev] [PATCH v6] f2fs: fix zoned block device information initialization

2024-04-06 Thread Chao Yu
On 2024/4/5 2:20, Daeho Jeong wrote: On Thu, Mar 28, 2024 at 12:23 AM Chao Yu wrote: From: Wenjie Qi If the max open zones of zoned devices are less than the active logs of F2FS, the device may error due to insufficient zone resources when multiple active logs are being written at the same t

Re: [f2fs-dev] [PATCH v2] f2fs: zone: don't block IO if there is remained open zone

2024-04-06 Thread Chao Yu
On 2024/4/2 3:08, Daeho Jeong wrote: On Thu, Mar 28, 2024 at 8:20 PM Chao Yu wrote: max open zone may be larger than log header number of f2fs, for such case, it doesn't need to wait last IO in previous zone, let's introduce available_open_zone semaphore, and reduce it once we submit first wri

Re: [f2fs-dev] [PATCH] f2fs: Fix incorrect return value

2024-04-06 Thread Chao Yu
On 2024/4/4 21:47, Wang Jianjian wrote: dquot_mark_dquot_dirty returns old dirty state not the error code. I think it's fine to just pass return value of dquot_mark_dquot_dirty() to caller, because caller can distinguish status from return value: 1) < 0, there is an error, 2) >= 0, there is no