[f2fs-dev] [PATCH] f2fs: enable atgc if atgc_age_threshold from user is less than elapsed_time

2024-05-20 Thread Zhiguo Niu
Now atgc can be enabled based on the following conditions: -ATGC mount option is set -elapsed_time is more than atgc_age_threshold already but these conditions are check when umounted->mounted device again. If the device has not be umounted->mounted for a long time, atgc can not work even the above

Re: [f2fs-dev] [PATCH 1/2] dump.f2fs: Add ability to dump folders

2024-05-20 Thread Daeho Jeong
On Tue, May 7, 2024 at 6:26 PM Daniel Rosenberg via Linux-f2fs-devel wrote: > > This adds the ability to dump folders as well as files. Folders are > dumped recursively. Additionally, dumped files/folders may be directed > to a folder specified by -o [path] instead of ./lost_found. The -r flag > w

Re: [f2fs-dev] [PATCH 2/2] dump.f2fs: Fix xattr dumping

2024-05-20 Thread Daeho Jeong
On Tue, May 7, 2024 at 6:23 PM Daniel Rosenberg via Linux-f2fs-devel wrote: > > Xattrs for files with inline data were being skipped. This dumps those, > as well as xattrs for folders. > > Signed-off-by: Daniel Rosenberg > --- > fsck/dump.c | 25 + > 1 file changed, 17 in

Re: [f2fs-dev] [PATCH 3/3] f2fs: fix to do sanity check on i_nid for inline_data inode

2024-05-20 Thread Jaegeuk Kim
On 05/15, Chao Yu wrote: > On 2024/5/15 12:39, Jaegeuk Kim wrote: > > On 05/15, Chao Yu wrote: > > > On 2024/5/15 0:07, Jaegeuk Kim wrote: > > > > 外部邮件/External Mail > > > > > > > > > > > > On 05/11, Chao Yu wrote: > > > > > On 2024/5/11 8:38, Jaegeuk Kim wrote: > > > > > > On 05/10, Chao Yu wrot

[f2fs-dev] [GIT PULL] f2fs update for 6.10-rc1

2024-05-20 Thread Jaegeuk Kim
Hi Linus, Could you please consider this pull reuqest? Thanks, The following changes since commit 928a87efa42302a23bb9554be081a28058495f22: Merge tag 'gfs2-v6.8-fix' of git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2 (2024-03-25 10:53:39 -0700) are available in the Git reposi

Re: [f2fs-dev] [PATCH] f2fs: fix to check return value of f2fs_allocate_new_section

2024-05-20 Thread Jaegeuk Kim
On 05/17, Zhiguo Niu wrote: > commit 245930617c9b ("f2fs: fix to handle error paths of > {new,change}_curseg()") > missed this allocated path, fix it. > > Signed-off-by: Zhiguo Niu > --- > fs/f2fs/segment.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/seg

[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

2024-05-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218770 --- Comment #11 from Jaegeuk Kim (jaeg...@kernel.org) --- The patch is in the next pull request. https://patchwork.kernel.org/project/f2fs/patch/zkumxs7pogimb...@google.com/ Once Linus pulled it, I can ask Greg to queue it in -stable. -- You ma

Re: [f2fs-dev] [GIT PULL] f2fs update for 6.10-rc1

2024-05-20 Thread pr-tracker-bot
The pull request you sent on Mon, 20 May 2024 19:37:02 +: > git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git > tags/f2fs-for-6.10.rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/72ece20127a366518d91c5ab8e9dd8bf7d7fdb2f Thank you! -- Deet-doot-d

Re: [f2fs-dev] [PATCH 0/6] Remove page_mapping()

2024-05-20 Thread patchwork-bot+f2fs
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Andrew Morton : On Tue, 23 Apr 2024 23:55:31 +0100 you wrote: > There are only a few users left. Convert them all to either call > folio_mapping() or just use folio->mapping directly. > > Matthew Wilcox (Oracle) (6): > fscrypt: Conve

Re: [f2fs-dev] [GIT PULL] f2fs update for 6.10-rc1

2024-05-20 Thread patchwork-bot+f2fs
Hello: This pull request was applied to jaegeuk/f2fs.git (dev) by Linus Torvalds : On Mon, 20 May 2024 19:37:02 + you wrote: > Hi Linus, > > Could you please consider this pull reuqest? > > Thanks, > > The following changes since commit 928a87efa42302a23bb9554be081a28058495f22: > > [...]

[f2fs-dev] Patchwork summary for: f2fs

2024-05-20 Thread patchwork-bot+f2fs
Hello: The following patches were marked "accepted", because they were applied to jaegeuk/f2fs.git (dev): Patch: [f2fs-dev,GIT,PULL] f2fs update for 6.10-rc1 Submitter: Jaegeuk Kim Committer: Linus Torvalds Patchwork: https://patchwork.kernel.org/project/f2fs/list/?series=854496 Lore li

[f2fs-dev] [Bug 218770] fsck seems unable to solve corruption

2024-05-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218770 --- Comment #12 from Guido (guido.iod...@gmail.com) --- (In reply to Jaegeuk Kim from comment #11) > The patch is in the next pull request. > https://patchwork.kernel.org/project/f2fs/patch/zkumxs7pogimb...@google.com/ > > Once Linus pulled it, I

[f2fs-dev] [PATCH] f2fs: fix false alarm on invalid block address

2024-05-20 Thread Jaegeuk Kim
f2fs_ra_meta_pages can try to read ahead on invalid block address which is not the corruption case. Cc: # v6.9+ Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=218770 Fixes: 31f85ccc84b8 ("f2fs: unify the error handling of f2fs_is_valid_blkaddr") Reviewed-by: Chao Yu Signed-off-by: Jaegeuk

[f2fs-dev] [PATCH v2 1/2] dump.f2fs: Add ability to dump folders

2024-05-20 Thread Daniel Rosenberg via Linux-f2fs-devel
This adds the ability to dump folders as well as files. Folders are dumped recursively. Additionally, dumped files/folders may be directed to a folder specified by -o [path] instead of ./lost_found. The -r flag will dump the entire fs from the root inode. -f or -y will skip the prompt before dumpin

Re: [f2fs-dev] [PATCH] f2fs: fix to check return value of f2fs_allocate_new_section

2024-05-20 Thread Zhiguo Niu
On Tue, May 21, 2024 at 3:52 AM Jaegeuk Kim wrote: > > On 05/17, Zhiguo Niu wrote: > > commit 245930617c9b ("f2fs: fix to handle error paths of > > {new,change}_curseg()") > > missed this allocated path, fix it. > > > > Signed-off-by: Zhiguo Niu > > --- > > fs/f2fs/segment.c | 4 +++- > > 1 fil

[f2fs-dev] [PATCH v2 2/2] dump.f2fs: Fix xattr dumping

2024-05-20 Thread Daniel Rosenberg via Linux-f2fs-devel
Xattrs for files with inline data were being skipped. This dumps those, as well as xattrs for folders. Signed-off-by: Daniel Rosenberg --- fsck/dump.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/fsck/dump.c b/fsck/dump.c index aecc293..17680d9 1

Re: [f2fs-dev] [PATCH v2 1/2] dump.f2fs: Add ability to dump folders

2024-05-20 Thread Daeho Jeong
On Mon, May 20, 2024 at 4:36 PM Daniel Rosenberg wrote: > > This adds the ability to dump folders as well as files. Folders are > dumped recursively. Additionally, dumped files/folders may be directed > to a folder specified by -o [path] instead of ./lost_found. The -r flag > will dump the entire

[f2fs-dev] [PATCH 1/2] f2fs: fix to do sanity check on F2FS_INLINE_DATA flag in inode during GC

2024-05-20 Thread Chao Yu
syzbot reports a f2fs bug as below: [ cut here ] kernel BUG at fs/f2fs/inline.c:258! CPU: 1 PID: 34 Comm: kworker/u8:2 Not tainted 6.9.0-rc6-syzkaller-00012-g9e4bc4bcae01 #0 RIP: 0010:f2fs_write_inline_data+0x781/0x790 fs/f2fs/inline.c:258 Call Trace: f2fs_write_single_da

[f2fs-dev] [PATCH 2/2] f2fs: fix to do sanity check on blocks for inline_data inode

2024-05-20 Thread Chao Yu
inode can be fuzzed, so it can has F2FS_INLINE_DATA flag and valid i_blocks/i_nid value, this patch supports to do extra sanity check to detect such corrupted state. Signed-off-by: Chao Yu --- fs/f2fs/f2fs.h | 2 +- fs/f2fs/inline.c | 20 +++- fs/f2fs/inode.c | 2 +- 3 files