[f2fs-dev] [PATCH] f2fs: fix to don't dirty inode for readonly filesystem

2024-06-04 Thread Chao Yu
syzbot reports f2fs bug as below: kernel BUG at fs/f2fs/inode.c:933! RIP: 0010:f2fs_evict_inode+0x1576/0x1590 fs/f2fs/inode.c:933 Call Trace: evict+0x2a4/0x620 fs/inode.c:664 dispose_list fs/inode.c:697 [inline] evict_inodes+0x5f8/0x690 fs/inode.c:747 generic_shutdown_super+0x9d/0x2c0 fs/super

Re: [f2fs-dev] [syzbot] [f2fs?] kernel BUG in f2fs_evict_inode (2)

2024-06-04 Thread Chao Yu
#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git wip On 2023/11/8 23:01, syzbot wrote: Hello, syzbot found the following issue on: HEAD commit:90b0c2b2edd1 Merge tag 'pinctrl-v6.7-1' of git://git.kerne.. git tree: upstream console+strace: https://syzkaller.ap

Re: [f2fs-dev] [syzbot] [f2fs?] kernel BUG in f2fs_evict_inode (2)

2024-06-04 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger any issue: Reported-and-tested-by: syzbot+31e4659a3fe953aec...@syzkaller.appspotmail.com Tested on: commit: 4d419837 f2fs: fix to don't dirty inode for readonly f.. git tree: https://git.kernel.org/pub

Re: [f2fs-dev] [syzbot] [f2fs?] INFO: task hung in f2fs_balance_fs

2024-06-04 Thread Chao Yu
#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git wip On 2023/3/26 13:17, syzbot wrote: syzbot has found a reproducer for the following issue on: HEAD commit:4bdec23f971b Merge tag 'hwmon-for-v6.3-rc4' of git://git.k.. git tree: upstream console+strace: https:/

Re: [f2fs-dev] [syzbot] [f2fs?] INFO: task hung in f2fs_balance_fs

2024-06-04 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger any issue: Reported-and-tested-by: syzbot+8b85865808c8908a0...@syzkaller.appspotmail.com Tested on: commit: 4d419837 f2fs: fix to don't dirty inode for readonly f.. git tree: https://git.kernel.org/pub

Re: [f2fs-dev] [PATCH v17 4/7] ext4: Reuse generic_ci_match for ci comparisons

2024-06-04 Thread Gabriel Krisman Bertazi
Eugen Hristev writes: > From: Gabriel Krisman Bertazi > > Instead of reimplementing ext4_match_ci, use the new libfs helper. > > It also adds a comment explaining why fname->cf_name.name must be > checked prior to the encryption hash optimization, because that tripped > me before. > > Signed-off

Re: [f2fs-dev] [PATCH v17 3/7] libfs: Introduce case-insensitive string comparison helper

2024-06-04 Thread Gabriel Krisman Bertazi
Eugen Hristev writes: > From: Gabriel Krisman Bertazi > > generic_ci_match can be used by case-insensitive filesystems to compare > strings under lookup with dirents in a case-insensitive way. This > function is currently reimplemented by each filesystem supporting > casefolding, so this reduce

Re: [f2fs-dev] [PATCH] f2fs: enable atgc if atgc_age_threshold from user is less than elapsed_time

2024-06-04 Thread Chao Yu
On 2024/6/3 17:05, Zhiguo Niu wrote: On Mon, Jun 3, 2024 at 3:41 PM Chao Yu wrote: On 2024/5/20 19:36, Zhiguo Niu wrote: Now atgc can be enabled based on the following conditions: -ATGC mount option is set -elapsed_time is more than atgc_age_threshold already but these conditions are check wh

Re: [f2fs-dev] [PATCH] f2fs: enable atgc if atgc_age_threshold from user is less than elapsed_time

2024-06-04 Thread Zhiguo Niu
On Wed, Jun 5, 2024 at 11:48 AM Chao Yu wrote: > > On 2024/6/3 17:05, Zhiguo Niu wrote: > > On Mon, Jun 3, 2024 at 3:41 PM Chao Yu wrote: > >> > >> On 2024/5/20 19:36, Zhiguo Niu wrote: > >>> Now atgc can be enabled based on the following conditions: > >>> -ATGC mount option is set > >>> -elapsed

Re: [f2fs-dev] [PATCH] f2fs: enable atgc if atgc_age_threshold from user is less than elapsed_time

2024-06-04 Thread Zhiguo Niu
On Wed, Jun 5, 2024 at 1:59 PM Zhiguo Niu wrote: > > On Wed, Jun 5, 2024 at 11:48 AM Chao Yu wrote: > > > > On 2024/6/3 17:05, Zhiguo Niu wrote: > > > On Mon, Jun 3, 2024 at 3:41 PM Chao Yu wrote: > > >> > > >> On 2024/5/20 19:36, Zhiguo Niu wrote: > > >>> Now atgc can be enabled based on the fo

Re: [f2fs-dev] [PATCH] f2fs: enable atgc if atgc_age_threshold from user is less than elapsed_time

2024-06-04 Thread Chao Yu
On 2024/6/5 13:59, Zhiguo Niu wrote: On Wed, Jun 5, 2024 at 11:48 AM Chao Yu wrote: On 2024/6/3 17:05, Zhiguo Niu wrote: On Mon, Jun 3, 2024 at 3:41 PM Chao Yu wrote: On 2024/5/20 19:36, Zhiguo Niu wrote: Now atgc can be enabled based on the following conditions: -ATGC mount option is set