Re: [f2fs-dev] [PATCH v4 13/22] xfs: Unmap blocks according to forcealign

2024-06-11 Thread John Garry via Linux-f2fs-devel
On 07/06/2024 15:39, John Garry wrote: For when forcealign is enabled, blocks in an inode need to be unmapped according to extent alignment, like what is already done for rtvol. Signed-off-by: John Garry --- fs/xfs/libxfs/xfs_bmap.c | 33 - 1 file changed, 28

[f2fs-dev] [PATCH] f2fs: add scope based f2fs_putname() cleanup

2024-06-11 Thread jtp . park
From: Jeongtae Park This patch adds a new scope based f2fs_putname() cleanup to reduce the chances of forgetting a f2fs_putname(). And doing so removes a goto statement for error handling. Signed-off-by: Jeongtae Park --- fs/f2fs/f2fs.h | 2 ++ fs/f2fs/file.c | 8 +++- 2 files changed, 5 i

[f2fs-dev] [PATCH] f2fs: fix convert inline inode on readonly mode

2024-06-11 Thread Daejun Park
syzbot reported a bug in f2fs_vm_page_mkwrite() which checks for f2fs_has_inline_data(inode). The bug was caused by f2fs_convert_inline_inode() not returning an error when called on a read-only filesystem, but returning with the inline attribute as set. This patch fixes the problem by ensuring that

Re: [f2fs-dev] [PATCH] f2fs: fix convert inline inode on readonly mode

2024-06-11 Thread Chao Yu
On 2024/6/12 10:20, Daejun Park wrote: syzbot reported a bug in f2fs_vm_page_mkwrite() which checks for f2fs_has_inline_data(inode). The bug was caused by f2fs_convert_inline_inode() not returning an error when called on a read-only filesystem, but returning with the inline attribute as set. This

Re: [f2fs-dev] (2) [PATCH] f2fs: fix convert inline inode on readonly mode

2024-06-11 Thread Daejun Park
> On 2024/6/12 10:20, Daejun Park wrote: > > syzbot reported a bug in f2fs_vm_page_mkwrite() which checks for > > f2fs_has_inline_data(inode). > > The bug was caused by f2fs_convert_inline_inode() not returning an > > error when called on a read-only filesystem, but returning with the > > inline at