Re: [f2fs-dev] [PATCH v2 2/2] f2fs: use meta inode for GC of COW file

2024-07-10 Thread Sunmin Jeong
>On 07/05, Sunmin Jeong wrote: >> In case of the COW file, new updates and GC writes are already >> separated to page caches of the atomic file and COW file. As some >> cases that use the meta inode for GC, there are some race issues >> between a foreground thread and GC thread. >> >> To handle the

[f2fs-dev] [PATCH v3 2/2] f2fs: use meta inode for GC of COW file

2024-07-10 Thread Sunmin Jeong
In case of the COW file, new updates and GC writes are already separated to page caches of the atomic file and COW file. As some cases that use the meta inode for GC, there are some race issues between a foreground thread and GC thread. To handle them, we need to take care when to invalidate and w

[f2fs-dev] [PATCH v3 1/2] f2fs: use meta inode for GC of atomic file

2024-07-10 Thread Sunmin Jeong
The page cache of the atomic file keeps new data pages which will be stored in the COW file. It can also keep old data pages when GCing the atomic file. In this case, new data can be overwritten by old data if a GC thread sets the old data page as dirty after new data page was evicted. Also, since

[f2fs-dev] [6.12] Conversion of aops->write_end to use a folio

2024-07-10 Thread Matthew Wilcox
For the 6.12 merge window, I intend to submit a patch series loosely similar to the one you can find at http://git.infradead.org/?p=users/willy/pagecache.git;a=shortlog;h=refs/heads/write-end (aka git://git.infradead.org/users/willy/pagecache.git write-end) This is split into a few pieces: - D

Re: [f2fs-dev] [RCF PATCH v3 00/10] f2fs-tools: introduce inject.f2fs

2024-07-10 Thread Jaegeuk Kim
Hi Sheng, Can we have a list of tests to check the expected behavior of given inject.f2fs followed by fsck.f2fs? Thanks, On 07/04, Sheng Yong wrote: > This patchset introduces a new tool inject.f2fs to modify metadata or > data (directory entry) of f2fs image offline flexibly. > > With inject.f

[f2fs-dev] [PATCH] inject.f2fs: install makefile

2024-07-10 Thread Jaegeuk Kim
Signed-off-by: Jaegeuk Kim --- fsck/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/fsck/Makefile.am b/fsck/Makefile.am index 48402abfc98f..ea3b26a65aa3 100644 --- a/fsck/Makefile.am +++ b/fsck/Makefile.am @@ -20,3 +20,4 @@ install-data-hook: ln -sf fsck.f2fs $(DESTDIR)/$(

Re: [f2fs-dev] [RCF PATCH v3 00/10] f2fs-tools: introduce inject.f2fs

2024-07-10 Thread Jaegeuk Kim
On 07/10, Jaegeuk Kim wrote: > Hi Sheng, > > Can we have a list of tests to check the expected behavior of given > inject.f2fs followed by fsck.f2fs? And we need this. https://lore.kernel.org/linux-f2fs-devel/20240710230319.33025-1-jaeg...@kernel.org/T/#u > > Thanks, > > On 07/04, Sheng Yong

Re: [f2fs-dev] [PATCH 3/3] f2fs: clean up data_blkaddr() and get_dnode_addr()

2024-07-10 Thread Jaegeuk Kim
On 06/25, Chao Yu wrote: > Introudce a new help get_dnode_base() to wrap common code from > get_dnode_addr() and data_blkaddr() for cleanup. > > Signed-off-by: Chao Yu > --- > fs/f2fs/f2fs.h | 46 +++--- > 1 file changed, 19 insertions(+), 27 deletions(-)

Re: [f2fs-dev] [PATCH] inject.f2fs: install makefile

2024-07-10 Thread Chao Yu
On 2024/7/11 7:03, Jaegeuk Kim wrote: Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

[f2fs-dev] [PATCH v2 3/3] f2fs: clean up data_blkaddr() and get_dnode_addr()

2024-07-10 Thread Chao Yu
Introudce a new help get_dnode_base() to wrap common code from get_dnode_addr() and data_blkaddr() for cleanup. Signed-off-by: Chao Yu --- v2: - clean up get_dnode_base() and remove redundant declaration suggested by Jaegeuk. fs/f2fs/f2fs.h | 46 +- 1

Re: [f2fs-dev] [RCF PATCH v3 00/10] f2fs-tools: introduce inject.f2fs

2024-07-10 Thread Sheng Yong via Linux-f2fs-devel
On 2024/7/11 7:04, Jaegeuk Kim wrote: On 07/10, Jaegeuk Kim wrote: Hi Sheng, Can we have a list of tests to check the expected behavior of given inject.f2fs followed by fsck.f2fs? Hi, Jaegeuk, Yes, I'm working on the testcases of fsck.f2fs and inject.f2fs. The basic idea is: 1. creates an